From patchwork Thu Oct 26 14:19:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 133431 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0CE243209; Thu, 26 Oct 2023 16:28:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C96F8402B5; Thu, 26 Oct 2023 16:27:57 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id CE60C42DE9 for ; Thu, 26 Oct 2023 16:27:56 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 763875C011A; Thu, 26 Oct 2023 10:27:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 26 Oct 2023 10:27:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1698330476; x= 1698416876; bh=3eup8/dMvX2jlj9mkuIghKYFnKATsplc8kPYcpStj/E=; b=m 4PERNgWBSJousPXx5bHn1LzGL+IostKu4ru7jHWkow+i7IAsOCVqROCEU089S4PW 2Ebd1c7CVuK9Dojk1DTxHLeB/RwikNEsjpiWVTfa2w+s1qlicddgEXYzlPTETggo eF3eQyuVLjcUrOkydvV+E9Rf4DsiKwInh3f695ORUfgHktBrr21MXoxhEfIjfBKW l0/f+jJG3/mzMsxppdwefDMIQz37hj7kwoBRM/y29Qihiy2LGUx2HZN/MaTPoj07 L1Ae6WficEt87RRhtD/1Q2KSzX7SxzrMMdgoeuOkt8177QFvkdOaRy5ITQigL48B avDfS4Ypl2BtKLIdRAJjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1698330476; x= 1698416876; bh=3eup8/dMvX2jlj9mkuIghKYFnKATsplc8kPYcpStj/E=; b=m Gr3LpVzmI39Etq8zMRfX2ORMH2i4AnV9PLNdu+63GuPp74r5MkM7lp+OcSOx7JTC efBW521j0vhVqKJIvwAeZnFp69/CyTl8GNKH17tvHQvuBUQlBRBUj0cNV1vdW9jQ Edxruxyw79MXIg3IPvxnPYqhSQmltJEyg7FoKvxbivfTBez0GBPAD8RdMXeGW8TY 3THSato8ErZtt4yGjrTA3SwE7bL9WQipVqWjkL8RkV0Z8BygO/mVmcEFqznrPIxz DknxwXKKSpsnXxZY3Di3HBR8vh1ZztUeiqSxSuU053FPXmQP4l31IvTV8YTRHGfD 8ptkUxzIHPMOPn31iRevA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledvgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Oct 2023 10:27:54 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: David Marchand , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: [PATCH v5 1/2] eal: add thread yield functions Date: Thu, 26 Oct 2023 16:19:36 +0200 Message-ID: <20231026142749.1174372-2-thomas@monjalon.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231026142749.1174372-1-thomas@monjalon.net> References: <20231024125416.798897-1-thomas@monjalon.net> <20231026142749.1174372-1-thomas@monjalon.net> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When running real-time threads, we may need to force scheduling kernel threads or other real-time threads. New functions are added to address these cases. The yield functions should not have any interest for normal threads. Note: other purposes may be addressed with rte_pause() or rte_delay_*(). Signed-off-by: Thomas Monjalon --- lib/eal/include/rte_thread.h | 25 +++++++++++++++++++++++++ lib/eal/unix/rte_thread.c | 16 ++++++++++++++++ lib/eal/version.map | 4 ++++ lib/eal/windows/rte_thread.c | 15 +++++++++++++++ 4 files changed, 60 insertions(+) diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h index 8da9d4d3fb..f2581fe152 100644 --- a/lib/eal/include/rte_thread.h +++ b/lib/eal/include/rte_thread.h @@ -183,6 +183,31 @@ int rte_thread_join(rte_thread_t thread_id, uint32_t *value_ptr); */ int rte_thread_detach(rte_thread_t thread_id); +/** + * Allow another thread to run on the same CPU core. + * + * This is a scheduler request, with minimum latency. + * Lower priority threads may not be scheduled. + * + * Especially useful in real-time thread priority + * to schedule other real-time threads. + * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL + */ +__rte_experimental +void rte_thread_yield(void); + +/** + * Unblock a CPU core running busy in a real-time thread. + * + * This is a sleep call, giving priority to all other threads. + * + * Especially useful in real-time thread priority + * to avoid a busy loop blocking vital threads on a core. + * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL + */ +__rte_experimental +void rte_thread_yield_realtime(void); + /** * Get the id of the calling thread. * diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c index 36a21ab2f9..278d8d342d 100644 --- a/lib/eal/unix/rte_thread.c +++ b/lib/eal/unix/rte_thread.c @@ -5,9 +5,11 @@ #include #include +#include #include #include #include +#include #include #include @@ -227,6 +229,20 @@ rte_thread_detach(rte_thread_t thread_id) return pthread_detach((pthread_t)thread_id.opaque_id); } +void +rte_thread_yield(void) +{ + sched_yield(); +} + +void +rte_thread_yield_realtime(void) +{ + /* A simple yield may not be enough to schedule kernel threads. */ + struct timespec wait = {.tv_nsec = 1000000}; /* 1 ms */ + nanosleep(&wait, NULL); +} + int rte_thread_equal(rte_thread_t t1, rte_thread_t t2) { diff --git a/lib/eal/version.map b/lib/eal/version.map index e00a844805..b81ac3e3af 100644 --- a/lib/eal/version.map +++ b/lib/eal/version.map @@ -413,6 +413,10 @@ EXPERIMENTAL { # added in 23.07 rte_memzone_max_get; rte_memzone_max_set; + + # added in 23.11 + rte_thread_yield; + rte_thread_yield_realtime; }; INTERNAL { diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c index acf648456c..ea17b5de3d 100644 --- a/lib/eal/windows/rte_thread.c +++ b/lib/eal/windows/rte_thread.c @@ -304,6 +304,21 @@ rte_thread_detach(rte_thread_t thread_id) return 0; } +void +rte_thread_yield(void) +{ + SwitchToThread(); +} + +void +rte_thread_yield_realtime(void) +{ + /* Real-time threads are not causing problems on Windows. + * A simple sleep should be more than enough. + */ + Sleep(0); +} + int rte_thread_equal(rte_thread_t t1, rte_thread_t t2) {