From patchwork Thu Nov 2 02:23:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 133754 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A7EB43267; Thu, 2 Nov 2023 03:24:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CA1D42E7A; Thu, 2 Nov 2023 03:24:00 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2101.outbound.protection.outlook.com [40.107.96.101]) by mails.dpdk.org (Postfix) with ESMTP id 195F942E77 for ; Thu, 2 Nov 2023 03:23:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d38oYQFssUn/Mw25aCLFU6sv3bps3X7R6tWSNLYqr3xlEiydCWdMwcZMLyVjLZVwue4CxZRpZgiDg7nD03pqPxrmvI8mF9egwpa8KnVVhaHDKcEhLLasd8iXYrulqayvtBPsCNvtf5newKR4Ac43kuX3ZqN0B2Ec3PWzCTTTa1EOjbAF/OliunVXvyyG7S7xiwdqZ8ydwQhxkF56Dx58q2CupuakSGUZ6d4l0zeVvbUEDp5ZlBfGyzov7K8qtzzYUI/UxDF6hCEwkHKz1fVCWrRALtHA/ZPsKyKJ2LpXO3bPID0EW0XjT/aXQc3bXIjjH9YZ2BYW3xLi68Z9wGqcrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/zz/F3loT0Ix+4jReddxJSIR9V+tK1+muYqKIeM244o=; b=IfuiGMbo72eqnW7QB7wMa5fXesU6Y35T+CQsqgijApMGydBQ0G4XAjIs4Jr+NGIQiSWBBZxHDnNlrUcajLlEZDDVZU6IQrKq5Jc8jXqy4m27o8GSrM4TXNBo9fIAvuAV0zglvw8piwVtSC9fOzbJD9MOjB0x5NxNMZ86benKNAXPOWZjppZfoHYkOfVcBtAebUQbNiV+bJA15+uZ7n/O0YusLn1zuGW6Dw8BAY8Rfc9MJc2orQGYVVEvFQdEV0x6r7uz3gq7qJn4E2IcO3QW4VhFSRbpCi0WWW/AhuvX6gJzY+O7HMVCUTLib01uwtZNcOIRWw7b/WSxbmPj9u5AnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/zz/F3loT0Ix+4jReddxJSIR9V+tK1+muYqKIeM244o=; b=v+X/AccGunRx/OH6NF9/9YKqeW5I6WGjATQ3b/c4cDrpbqhoUng2++IYemEH9ds+Oh0bhrbk8KbqJ+ywrXsrZPvwOsSNZrqnarqgpTMhgZbH0SELe9Y9iDhUPkByh63/PkP/1or6qLwK4/UpTJnEQBPLcorSFC/qiaLo+3WPdUw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB4455.namprd13.prod.outlook.com (2603:10b6:a03:1d4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Thu, 2 Nov 2023 02:23:56 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.027; Thu, 2 Nov 2023 02:23:56 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , Chaoyong He , Long Wu Subject: [PATCH 07/11] net/nfp: add the check about the firmware load Date: Thu, 2 Nov 2023 10:23:17 +0800 Message-Id: <20231102022321.2254224-8-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231102022321.2254224-1-chaoyong.he@corigine.com> References: <20231102022321.2254224-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BY5PR20CA0030.namprd20.prod.outlook.com (2603:10b6:a03:1f4::43) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB4455:EE_ X-MS-Office365-Filtering-Correlation-Id: b0f27eec-72d7-41ca-26ac-08dbdb4ac405 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KGhVxPffPp5AT9q45NjVWB1LRFKlftWJ2GsF6VCiP3DfWDOAPxcf7fcYZJKE727fPmXb4ImcV5djsrhBQayXRP0gpaBsHXjzW43T2aTrJ1TkE40iL527Ib/anamuEJqvxeDrY9uAw8hIvFdHKqrjGmsG+jg3INk2lABNbmgftDf34R9js3KR1pR5QWpIlmYfHxMUPcUAgr4T+Yiuu0XoQ3mSOZ1DDRzedPRMh/OKhtJoO2SdMLiaU/PdgW7MRTeYTDlhBUGn1Qm6QTRty/aZ6KNIL6vaqDLXjcBY/dKNppHAIJQmTjufyuLHIsqCz3XwtfR1kqyWYsD0kwJfFlYEDO0Ypcwb6Wso8h4IwFS8rA5TfXnbFN+jC5FeQh3p+RpoNhhSkIsvvG4/hsI+8NUw6FL9XTxy2WiKGKhoimQLzs0wvNYNTuSSljE//W5q1UXMcrqf/vpTM3f0yZCaq59CqMGDBMPsuN667MniPslKariIAaSmYHkLWxD/nYEUJbgjLYoNaok08UPrWm1TK0JoA7iJUX1joUC0rkNti8VTRc0lpDHIhpSjPnCf6J7QX1zJ8ClL7Eq7MM1eUuBYz+hmAv79iO1HHBUDCnsO2WYT238giOscwL9oOfeUiEJyKmgW+h24UCpXe0cXCwIAxTs0JWGxszcr7uNTZ3qjQLlySXE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(136003)(39830400003)(376002)(366004)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(2906002)(8936002)(4326008)(8676002)(44832011)(6666004)(41300700001)(6486002)(478600001)(66556008)(316002)(66476007)(6916009)(54906003)(5660300002)(66946007)(6506007)(52116002)(107886003)(1076003)(26005)(2616005)(83380400001)(38350700005)(6512007)(36756003)(86362001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FnE8mA5TnJV2flvSYW92LWHM61C2+bIgPS3yTRQvfuWnv7AuVsNbMgG3llAQNtiUZ8xi/dYWETRq1yx+2HgLPGsjAfwiPosmcnVcVF9NSTzEjIOcrWjdT1dsTwCbB9f2mq/g1bk48hWvP1GwVZo7/sNvf4M00ddS5S+8s0pAvfvA6PmZiEEkxjTVpvS7SihB+kk5e5SvAMootT8o4ROyxT8fjeYKHR+e5BwosmAqPlj8a67hRMr9HU7juYOxd9EQkmIvQCRebt1SxyDXoNgVSdfkjO1WQiI8ICJFHCVfpumb6McZMbJ2lnRkgX4k49xiJ754z4jIyGEnK2rawVJgYtCRMl2lMNw3oHvbdz1rsmAkgMG1cVlWHSbOPoz79u9yL7rUTxOmxXoSPY6ZHp9PY4F1MQzFy0OkoIlNBbXNhD6kFs+Jor8WM46YgGiGjH9/zZ/mw6YQXxwsA3BDp40pudoxDI99Df+HPHjFwNyGt8HQCtpBOAud8bzktjo3dEx12EMsQdGc5VQwBprnA4A56uSpQPY3KZSPAgtiWb+PMKQc/ol4vfffG3mqCSzKMsFTIe0jhdc3dV4yvJlAjRxxiXO7n/qEpkZV3/6gVC8MtPQZ6AIiSffUa6bZpStRKk7bTxBvY/eKBMpjNA00aBK3/M66/ueHguAXQHDHAn3FwGnfhK6LwfZjb3vq75kt4cmJ0Jab/1v7Dr1brRMkdg3CIoIzNyca/loAsiiLjZEGthvp6mviDgZcnVuZ2EmK4UKyt7ZJ6tgAUQL/SQVd3LMYCgWD80e7t/UjMz+5gRpKzN+3WYGxBqqZWFEEFJAG1LgKp/rcKJcjs5LzdrvpoUQuDhyYxj78vfezMax5CQLC5VzuU5td8usDnTLdK2nS7u/K6W3Hht6BYGbwhpa7+VQYPgX57eo3MVKtOQm919MWrOBRZGLJCj2nPkXrXrdKZn/uGR0CCETac/tC5KoHoyqqQl8gUI7IfcLovFe4faHdZ16sVKhybPckfAJab5hKSoybdsywaY3jjiqLcRGOw9NCC8eMPM9Mal4q2+YZuXOXlVAq8ZPbnJE2A4/VuNJlsj4QIyZkkD1igqyz1SE9Kztqs+W1Q36bgYCoJBQk8DBwrLKVPLWw4g3zag0vju7jtYHF+clBs3FNKHDXWBHGo12GMs2xHcGOsMml1gkKhJyF5n9dmR+EsEer2UuT5IQNlhmossTKkOul//kI53lWeNCXAM1ir7qlc3eGCKrRCo8Nzp61Iw558Y853GahkaGQWDxrMGiVnOkofWqYLQy8nf7pN8oQuzIYQ1nJZbQ07eBKhDukOTH8Zwnhs4uI7NOGf9wtcB7cKCrR+4kUZHu71RNlV8ei9eda0nPlLc7QaRu4LT5B6NzuGCHlELWb2EfQMa+fb9804ZB/WIHvSG0Yh8s4cTMsFpfH+QrPK5zTxR6acj4V/27F9kPM5QdQqVxapy+eJgN4AowAgHrx9TxicZtzFvq8Ow8eU9saNFW/LgicRJ0lrsUq04SJmAIWTjRnuqrUTJgiz6tIY3GuNqXkbLUiJpfwFP2f8lvBGskfEY0NOrepmZtlUm8Npb1mcqIrSt0m5izVueqscsjXV36gDzpXFA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0f27eec-72d7-41ca-26ac-08dbdb4ac405 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2023 02:23:56.8771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wtq/EYXcdy4khneNPMHvQ4mYMZeO1p6t0rrzpDO/28AfktWsko46zlK7diMjrSrB1ZWgLy8vGx/GpTXid+iOvcDnqjF8DYBnX9XnbitPBms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB4455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peng Zhang When firmware load failed, it doesn't have any notice. So add the check about the firmware load and add an exit point when the firmware load process fail. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/nfp_ethdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 3ebfd444b3..9378a2ebc3 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -654,7 +654,12 @@ nfp_fw_upload(struct rte_pci_device *dev, PMD_DRV_LOG(INFO, "Firmware file found at %s with size: %zu", fw_name, fsize); PMD_DRV_LOG(INFO, "Uploading the firmware ..."); - nfp_nsp_load_fw(nsp, fw_buf, fsize); + if (nfp_nsp_load_fw(nsp, fw_buf, fsize) < 0) { + free(fw_buf); + PMD_DRV_LOG(ERR, "Firmware load failed."); + return -EIO; + } + PMD_DRV_LOG(INFO, "Done"); free(fw_buf);