From patchwork Thu Nov 2 18:11:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 133791 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5834E43270; Thu, 2 Nov 2023 19:12:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAD5A40262; Thu, 2 Nov 2023 19:12:04 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 0AB7040144 for ; Thu, 2 Nov 2023 19:12:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698948723; x=1730484723; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=wsoUpX8e79UHgqQLxPJyCKJdQR5JIjlinRaDLDsIYuM=; b=mp7tO0rBxR8GjqaDDm12nPpJfPGudEJodOspn2y4pNXyk1fCKgv39BUA UUc778h3Uo8oYNBujcEfR0tIC8G8yRl+arfQVQO8uVmMHACjB4hSfafKT PeEJj5UB9APmF2yhcoJ0KfgBuP/339JkQyB5izvbosjsU2NRoahZcUsjT NsVcKZds61uI8g0LtYm75pEx5JUIwPpqj5XKa8g55bmwLDWpX4spDJ+Go cYKQEY88/f983fqS3KcyIYADHXnpijhzKh7thBRVGw8AwNCRWD8O1qdqw 7tWooGz8Yp3HYZK9qPJDGp9eadXStu4xjSfVKndu0gyNns/K6YCIqBLtQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="392663861" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="392663861" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 11:12:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="796337229" X-IronPort-AV: E=Sophos;i="6.03,272,1694761200"; d="scan'208";a="796337229" Received: from silpixa00401385.ir.intel.com ([10.237.214.164]) by orsmga001.jf.intel.com with ESMTP; 02 Nov 2023 11:12:00 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: stephen@networkplumber.org, Bruce Richardson Subject: [PATCH] eal: add const to init function parameter Date: Thu, 2 Nov 2023 18:11:48 +0000 Message-Id: <20231102181148.56930-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Change the parameter type of argv parameter to rte_eal_init from "char **" to "char * const *", since we don't modify the argv pointers passed in. Signed-off-by: Bruce Richardson Acked-by: Konstantin Ananyev --- lib/eal/common/eal_common_options.c | 2 +- lib/eal/common/eal_options.h | 2 +- lib/eal/freebsd/eal.c | 4 ++-- lib/eal/include/rte_eal.h | 2 +- lib/eal/linux/eal.c | 4 ++-- lib/eal/windows/eal.c | 4 ++-- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index a6d21f1cba..7927eb1f1d 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -206,7 +206,7 @@ handle_eal_info_request(const char *cmd, const char *params __rte_unused, } int -eal_save_args(int argc, char **argv) +eal_save_args(int argc, char * const *argv) { int i, j; diff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h index 3cc9cb6412..21ab2492fc 100644 --- a/lib/eal/common/eal_options.h +++ b/lib/eal/common/eal_options.h @@ -105,7 +105,7 @@ int eal_check_common_options(struct internal_config *internal_cfg); void eal_common_usage(void); enum rte_proc_type_t eal_proc_type_detect(void); int eal_plugins_init(void); -int eal_save_args(int argc, char **argv); +int eal_save_args(int argc, char * const *argv); int handle_eal_info_request(const char *cmd, const char *params __rte_unused, struct rte_tel_data *d); diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 568e06e9ed..f241e7dd5e 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -365,7 +365,7 @@ eal_get_hugepage_mem_size(void) /* Parse the arguments for --log-level only */ static void -eal_log_level_parse(int argc, char **argv) +eal_log_level_parse(int argc, char * const *argv) { int opt; char **argvopt; @@ -577,7 +577,7 @@ static void rte_eal_init_alert(const char *msg) /* Launch threads, called at application init(). */ int -rte_eal_init(int argc, char **argv) +rte_eal_init(int argc, char * const *argv) { int i, fctret, ret; static uint32_t run_once; diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h index cd318ee141..e0a74865ad 100644 --- a/lib/eal/include/rte_eal.h +++ b/lib/eal/include/rte_eal.h @@ -109,7 +109,7 @@ int rte_eal_iopl_init(void); * * ENOEXEC indicates that a service core failed to launch successfully. */ -int rte_eal_init(int argc, char **argv); +int rte_eal_init(int argc, char * const *argv); /** * Clean up the Environment Abstraction Layer (EAL) diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 57da058cec..a56b85f2ce 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -548,7 +548,7 @@ eal_parse_vfio_vf_token(const char *vf_token) /* Parse the arguments for --log-level only */ static void -eal_log_level_parse(int argc, char **argv) +eal_log_level_parse(int argc, char * const *argv) { int opt; char **argvopt; @@ -964,7 +964,7 @@ eal_worker_thread_create(unsigned int lcore_id) /* Launch threads, called at application init(). */ int -rte_eal_init(int argc, char **argv) +rte_eal_init(int argc, char * const *argv) { int i, fctret, ret; static RTE_ATOMIC(uint32_t) run_once; diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index 7ec2152211..1abb2eb2f7 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -98,7 +98,7 @@ eal_usage(const char *prgname) /* Parse the arguments for --log-level only */ static void -eal_log_level_parse(int argc, char **argv) +eal_log_level_parse(int argc, char * const *argv) { int opt; char **argvopt; @@ -273,7 +273,7 @@ rte_eal_cleanup(void) /* Launch threads, called at application init(). */ int -rte_eal_init(int argc, char **argv) +rte_eal_init(int argc, char * const *argv) { int i, fctret, bscan; const struct rte_config *config = rte_eal_get_configuration();