From patchwork Fri Nov 3 09:53:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: fengchengwen X-Patchwork-Id: 133824 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A18543279; Fri, 3 Nov 2023 10:56:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10D8840DDC; Fri, 3 Nov 2023 10:56:10 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 1A7F240284 for ; Fri, 3 Nov 2023 10:56:08 +0100 (CET) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SMGN332nPzvQcH; Fri, 3 Nov 2023 17:56:03 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 3 Nov 2023 17:56:05 +0800 From: Chengwen Feng To: , CC: Subject: [PATCH 5/7] app/test: extract parse list value testcase for kvargs Date: Fri, 3 Nov 2023 09:53:23 +0000 Message-ID: <20231103095325.47843-6-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231103095325.47843-1-fengchengwen@huawei.com> References: <20231103095325.47843-1-fengchengwen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extract parse list value test as one stand-alone testcase. Signed-off-by: Chengwen Feng --- app/test/test_kvargs.c | 54 +++++++++++++++++++++++++----------------- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c index 28b93680f0..f4257c176f 100644 --- a/app/test/test_kvargs.c +++ b/app/test/test_kvargs.c @@ -41,28 +41,7 @@ static int test_valid_kvargs(void) { struct rte_kvargs *kvlist; const char *args; - const char *valid_keys_list[] = { "foo", "check", NULL }; - const char **valid_keys; - - /* third test using list as value */ - args = "foo=[0,1],check=value2"; - valid_keys = valid_keys_list; - kvlist = rte_kvargs_parse(args, valid_keys); - if (kvlist == NULL) { - printf("rte_kvargs_parse() error\n"); - goto fail; - } - if (strcmp(kvlist->pairs[0].value, "[0,1]") != 0) { - printf("wrong value %s", kvlist->pairs[0].value); - goto fail; - } - count = kvlist->count; - if (count != 2) { - printf("invalid count value %d\n", count); - rte_kvargs_free(kvlist); - goto fail; - } - rte_kvargs_free(kvlist); + const char **valid_keys = NULL; /* test using empty elements (it is valid) */ args = "foo=1,,check=value2,,"; @@ -235,6 +214,36 @@ test_parse_with_valid_keys(void) return 0; } +static int +test_parse_list_value(void) +{ + const char *valid_keys[] = { "foo", "check", NULL }; + const char *args = "foo=[0,1],check=value2"; + struct rte_kvargs *kvlist; + + kvlist = rte_kvargs_parse(args, valid_keys); + if (kvlist == NULL) { + printf("rte_kvargs_parse() error\n"); + return -1; + } + + count = kvlist->count; + if (count != 2) { + printf("invalid count value %u\n", count); + rte_kvargs_free(kvlist); + return -1; + } + + if (strcmp(kvlist->pairs[0].value, "[0,1]") != 0) { + printf("wrong value %s", kvlist->pairs[0].value); + rte_kvargs_free(kvlist); + return -1; + } + + rte_kvargs_free(kvlist); + return 0; +} + /* test several error cases */ static int test_invalid_kvargs(void) { @@ -279,6 +288,7 @@ static struct unit_test_suite kvargs_test_suite = { TEST_CASE(test_basic_token_count), TEST_CASE(test_parse_without_valid_keys), TEST_CASE(test_parse_with_valid_keys), + TEST_CASE(test_parse_list_value), TEST_CASE(test_invalid_kvargs), TEST_CASES_END() /**< NULL terminate unit test array */ }