diff mbox series

[v2,22/22] devtools: check for some reentrant function

Message ID	20231114084133.3573959-23-haijie1@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net> CC: <haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com> Subject: [PATCH v2 22/22] devtools: check for some reentrant function Date: Tue, 14 Nov 2023 16:41:33 +0800 Message-ID: <20231114084133.3573959-23-haijie1@huawei.com> In-Reply-To: <20231114084133.3573959-1-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20231114084133.3573959-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strtok with reentrant version \| [v2,00/22] replace strtok with reentrant version [v2,01/22] app/graph: replace strtok with reentrant version [v2,02/22] app/bbdev: replace strtok with reentrant version [v2,03/22] app/compress-perf: replace strtok with reentrant version [v2,04/22] app/crypto-perf: replace strtok with reentrant version [v2,05/22] app/dma-perf: replace strtok with reentrant version [v2,06/22] app/test-fib: replace strtok with reentrant version [v2,07/22] app/flow-perf: replace strtok with reentrant version [v2,08/22] app/test-mldev: replace strtok with reentrant version [v2,09/22] dmadev: replace strtok with reentrant version [v2,10/22] eal: replace strtok with reentrant version [v2,11/22] ethdev: replace strtok with reentrant version [v2,12/22] eventdev: replace strtok with reentrant version [v2,13/22] security: replace strtok with reentrant version [v2,14/22] telemetry: replace strtok with reentrant version [v2,15/22] bus/fslmc: replace strtok with reentrant version [v2,16/22] common/cnxk: replace strtok with reentrant version [v2,17/22] event/cnxk: replace strtok with reentrant version [v2,18/22] net/ark: replace strtok with reentrant version [v2,19/22] raw/cnxk_gpio: replace strtok with reentrant version [v2,20/22] examples/l2fwd-crypto: replace strtok with reentrant version [v2,21/22] examples/vhost: replace strtok with reentrant version [v2,22/22] devtools: check for some reentrant function

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/loongarch-compilation	fail	ninja build failure
ci/github-robot: build	fail	github build: failed
ci/Intel-compilation	fail	Compilation issues

Commit Message

Jie Hai Nov. 14, 2023, 8:41 a.m. UTC

  Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

This patch adds check in checkpatches.sh for strtok, which is
non-reentrant.

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 devtools/checkpatches.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff mbox series

Patch

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 066449d147e8..0a936219c069 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -119,6 +119,14 @@  check_forbidden_additions() { # <patch>
 		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
 		"$1" || res=1
 
+	# refrain from using some non-reentrant functions
+	awk -v FOLDERS="lib drivers app examples" \
+		-v EXPRESSIONS="strtok\\\(" \
+		-v RET_ON_FAIL=1 \
+		-v MESSAGE='Using non-reentrant function strtok, prefer strtok_s' \
+		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+		"$1" || res=1
+
 	# refrain from using some pthread functions
 	awk -v FOLDERS="lib drivers app examples" \
 		-v EXPRESSIONS="pthread_(create|join|detach|set(_?name_np|affinity_np)|attr_set(inheritsched|schedpolicy))\\\(" \