net/ice: fix tso tunnel setting to not take effect

Message ID 20231124064441.1774807-1-kaiwenx.deng@intel.com (mailing list archive)
State Superseded
Delegated to: Qi Zhang
Headers
Series net/ice: fix tso tunnel setting to not take effect |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Kaiwen Deng Nov. 24, 2023, 6:44 a.m. UTC
  The Tx offload capabilities of ICE ethdev doesn't include
tso tunnel, which will result in tso tunnel setting to
not take effect.

This commit will add tso tunnel capabilities in ice_dev_info_get().

Fixes: 295968d17407 ("ethdev: add namespace")
Cc: stable@dpdk.org

Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
  

Comments

lihuisong (C) Nov. 24, 2023, 7:50 a.m. UTC | #1
please add Bugzilla ID

在 2023/11/24 14:44, Kaiwen Deng 写道:
> The Tx offload capabilities of ICE ethdev doesn't include
> tso tunnel, which will result in tso tunnel setting to
> not take effect.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Fixes: 295968d17407 ("ethdev: add namespace")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
>   drivers/net/ice/ice_ethdev.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 3ccba4db80..fbc957fcd8 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>   			RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
>   			RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
>   			RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> -			RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> +			RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> +			RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> +			RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> +			RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
> +			RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
>   		dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
>   	}
>   
correct,
Reviewed-by: Huisong Li <lihuisong@huawei.com>
  
David Marchand Nov. 24, 2023, 8:02 a.m. UTC | #2
On Fri, Nov 24, 2023 at 8:27 AM Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
>
> The Tx offload capabilities of ICE ethdev doesn't include
> tso tunnel, which will result in tso tunnel setting to
> not take effect.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Fixes: 295968d17407 ("ethdev: add namespace")

This Fixes: tag is wrong.

> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 3ccba4db80..fbc957fcd8 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>                         RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
>                         RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
>                         RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> -                       RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> +                       RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> +                       RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> +                       RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> +                       RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
> +                       RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
>                 dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
>         }

Is this tunnel + tso feature supported with vector drivers?

Is there some documentation to update to reflect this addition?
  

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 3ccba4db80..fbc957fcd8 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3876,7 +3876,11 @@  ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 			RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
 			RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
 			RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
-			RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
+			RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
+			RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
+			RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
+			RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
+			RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
 		dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
 	}