From patchwork Wed Nov 29 17:26:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 134716 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6221A43403; Wed, 29 Nov 2023 18:33:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C309D42EA7; Wed, 29 Nov 2023 18:31:56 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 0761D42E65 for ; Wed, 29 Nov 2023 18:31:51 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6c320a821c4so6119695b3a.2 for ; Wed, 29 Nov 2023 09:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279110; x=1701883910; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0yfk9EAU7Jewthnsdnd1bGnHGmAnJUoyhDSPGUAzKZA=; b=HrHPp88O6fqrzSwfHxM0iIEYc5kyqfOjeIaHoLXKIrYao4Zo5OctojrSwJDi20qB+U cc3CvhSK0ziYPQn6sG6TBRFqYUlMNCa1xRyrDKUClwucTLjsR111SxzusIzSu2Xdpm0a WBbHzmdb9MhAocJcAi3b6AalYFFxWqT6/JkYiH9ka3h2QKYvr1fzAqRXZSDmYZc0nKb/ 07wR2StNpZ8p3+baI0US6MTuCpFAf84VnuCHfeBI3BvPEfJWozIApnixHsqOotfOhmGM PCg73Zodgny27Sdl+rL6QL2Ng0lBGviwf+tSiUKQZ26n4gWIvW/i/tgx6fELZ495m9Tp WYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279110; x=1701883910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0yfk9EAU7Jewthnsdnd1bGnHGmAnJUoyhDSPGUAzKZA=; b=vuY8jzPs4Kbzws5L64/I6GpNziFHogjeGlrdFhkbfkVm4taPLBxkY6wEz9ZsTWPnwb HMaixuLtzxYPainDxHyeTrlDGHPQqMzOAcqM3cfQUTue/+LFeewfKrxjsTzU09afhPGe oHUPtj12J2VybW+P+i7YjNRqkew24m2iCPBQWWsnL6vOBSpB/Ycetnb1qeTPfr/cQlbq 6zzU8kv2USjpfpWf8GPBSxJV0MMQg2wv/53yhDFhbPWOVTGuseidHzuzV829DAix6Jdj ejqnK1n/qVc6hUZs5JUC2CpzhrLMVIpIJE2Jz9rUcSbNmc38D78JGm2ErToPMGvFQzky SwNA== X-Gm-Message-State: AOJu0YzlEy/KoalL8bH3LMySYgjJzYuRC/FkGmndtRqoNmZuaoUucVCm SgkcssY53BV354ceFhyDjBoYxlwTmRvdtSZ9Y6LPJg== X-Google-Smtp-Source: AGHT+IH3/MU/DnD+QOoMJMzC2hLqFDyVWsTZhyFjZnqr7OFfljtEaQ9lpU5IEjSU2/hRxn590m7O6g== X-Received: by 2002:a05:6a00:93a4:b0:6cb:d28f:7a91 with SMTP id ka36-20020a056a0093a400b006cbd28f7a91mr21448567pfb.9.1701279109910; Wed, 29 Nov 2023 09:31:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:31:49 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v5 14/19] cnxk: replace term sanity Date: Wed, 29 Nov 2023 09:26:08 -0800 Message-ID: <20231129173122.126895-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231129173122.126895-1-stephen@networkplumber.org> References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c | 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index e1cef7a670b6..6060dba0d799 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -527,7 +527,7 @@ roc_nix_tm_hierarchy_disable(struct roc_nix *roc_nix) node->flags &= ~NIX_TM_NODE_ENABLED; } - /* Verify sanity of all tx queues */ + /* Verify all tx queues */ for (i = 0; i < sq_cnt; i++) { sq = nix->sqs[i]; if (!sq) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 6c14c499019a..5e38ecf0414e 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -458,7 +458,7 @@ npa_aura_pool_pair_alloc(struct npa_lf *lf, const uint32_t block_size, char name[PLT_MEMZONE_NAMESIZE]; const struct plt_memzone *mz; - /* Sanity check */ + /* argument checks */ if (!lf || !block_size || !block_count || !pool || !aura || !aura_handle) return NPA_ERR_PARAM; @@ -1096,7 +1096,7 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) uint8_t aura_sz; int rc; - /* Sanity checks */ + /* Input checks */ if (!lf || !base || !mbox) return NPA_ERR_PARAM; diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 5e11bbb017ea..798567592efe 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -636,7 +636,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid, struct rte_mempool *lpb_pool = mp; struct rte_mempool *spb_pool = NULL; - /* Sanity checks */ + /* input checks */ if (rx_conf->rx_deferred_start == 1) { plt_err("Deferred Rx start is not supported"); goto fail; @@ -1205,7 +1205,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) rc = -EINVAL; - /* Sanity checks */ + /* baseline checks */ if (rte_eal_has_hugepages() == 0) { plt_err("Huge page is not configured"); goto fail_configure;