From patchwork Mon Dec 4 18:37:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 134824 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91B834366C; Mon, 4 Dec 2023 19:38:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11A6342DBD; Mon, 4 Dec 2023 19:37:37 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id AEA94427D9 for ; Mon, 4 Dec 2023 19:37:34 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-5c66bbb3d77so821718a12.0 for ; Mon, 04 Dec 2023 10:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1701715053; x=1702319853; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=qXvVv8yDcyOG2H+a/u+dVz+kyoaVNzRQ2mZZBTwRUYo=; b=Iq5bynpntrSVKwiCY73UlQuncfJgMdpWJjfWXqbPuXxVyC+u1CoOdgqLPnllFxoJmR eXZLDDDfUKz5jrzP+v0Gut/0UtcCRfRrzcR5sAWaYxNwa2JWAgnBaSHz3nuMKyflc9pc CW4AIzPVcV+QT2Q2TBinSistM6HLKJ/rLtXW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701715053; x=1702319853; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qXvVv8yDcyOG2H+a/u+dVz+kyoaVNzRQ2mZZBTwRUYo=; b=wT6my5WaAFL8wFujwyXRz/NuzmhamawolKGKRm5XwW40XYYPNttVtShpXlfmbwq4T+ t3xl5kP9wQafGIbOHAsEpTwiPbuoN0kjzrhjJD/d0lmUuIhoT5j7jc+E/CG8xcaeHliC DNC0dNoAoXeFBJ2+GqHMfrAR2YcvU/eYg648aqXe1pH++g3rnmZGD23s6jwxk8MXae/k U6psJsaT9P1R3eNvrtGkkqP2XHrYXTX5WMlO7XMhy4sIti+1Dk6zJMjF5TeZKncp7G7p Q+aBGTYC4HRpYIk5rjF0k532puN3+KFtO8P/n4G72piUJjVtGToLkU+LClEz/G8IPDa0 /kiQ== X-Gm-Message-State: AOJu0YzZDFPMQDBNN+DC4+iRZUdpybC2FP77eEmW6QLe0eOvx63dCTgc OhWdPnsj3xU/BDoA7aCYFHgjwSlRHnbjfzN+kfvsMRwaSEAoj4F0hJPoxgt2fO4mZYtF7VI0xEZ PPuyMAl2oY8szjcEBGIT78WYrRCPwnKQ0kkwSL4+pu2vc+7+vhG684CWrs3qtZtBw/51Q X-Google-Smtp-Source: AGHT+IF92IDrNABQZfrQf+M1Yrg+Zb/hFbPT882AgOufytXWkBEFXPZctyyyy3mTm/h9ags7wpjr/g== X-Received: by 2002:a05:6a20:26a1:b0:18f:97c:8273 with SMTP id h33-20020a056a2026a100b0018f097c8273mr1809814pze.125.1701715053455; Mon, 04 Dec 2023 10:37:33 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id s3-20020a056a00178300b006be5af77f06sm4236664pfg.2.2023.12.04.10.37.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 10:37:32 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Mike Baucom Subject: [PATCH 10/14] net/bnxt: refactor the ulp initialization Date: Mon, 4 Dec 2023 10:37:06 -0800 Message-Id: <20231204183710.86921-11-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231204183710.86921-1-ajit.khaparde@broadcom.com> References: <20231204183710.86921-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kishore Padmanabha Add new method to consider all the conditions to check before the ulp could be initialized. Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 4472268924..8f3bd858da 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -190,6 +190,7 @@ static void bnxt_dev_recover(void *arg); static void bnxt_free_error_recovery_info(struct bnxt *bp); static void bnxt_free_rep_info(struct bnxt *bp); static int bnxt_check_fw_ready(struct bnxt *bp); +static bool bnxt_enable_ulp(struct bnxt *bp); int is_bnxt_in_error(struct bnxt *bp) { @@ -1521,7 +1522,8 @@ static int bnxt_dev_stop(struct rte_eth_dev *eth_dev) return ret; /* delete the bnxt ULP port details */ - bnxt_ulp_port_deinit(bp); + if (bnxt_enable_ulp(bp)) + bnxt_ulp_port_deinit(bp); bnxt_cancel_fw_health_check(bp); @@ -1642,9 +1644,11 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) goto error; /* Initialize bnxt ULP port details */ - rc = bnxt_ulp_port_init(bp); - if (rc) - goto error; + if (bnxt_enable_ulp(bp)) { + rc = bnxt_ulp_port_init(bp); + if (rc) + goto error; + } eth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev); eth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev); @@ -3427,7 +3431,7 @@ bnxt_flow_ops_get_op(struct rte_eth_dev *dev, */ dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE; - if (BNXT_TRUFLOW_EN(bp)) + if (bnxt_enable_ulp(bp)) *ops = &bnxt_ulp_rte_flow_ops; else *ops = &bnxt_flow_ops; @@ -6667,6 +6671,20 @@ struct tf *bnxt_get_tfp_session(struct bnxt *bp, enum bnxt_session_type type) &bp->tfp[BNXT_SESSION_TYPE_REGULAR] : &bp->tfp[type]; } +/* check if ULP should be enabled or not */ +static bool bnxt_enable_ulp(struct bnxt *bp) +{ + /* truflow and MPC should be enabled */ + /* not enabling ulp for cli and no truflow apps */ + if (BNXT_TRUFLOW_EN(bp) && bp->app_id != 254 && + bp->app_id != 255) { + if (BNXT_CHIP_P7(bp)) + return false; + return true; + } + return false; +} + RTE_LOG_REGISTER_SUFFIX(bnxt_logtype_driver, driver, NOTICE); RTE_PMD_REGISTER_PCI(net_bnxt, bnxt_rte_pmd); RTE_PMD_REGISTER_PCI_TABLE(net_bnxt, bnxt_pci_id_map);