From patchwork Mon Dec 4 18:37:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 134825 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBFE94366C; Mon, 4 Dec 2023 19:38:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A1A142DC1; Mon, 4 Dec 2023 19:37:38 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id E016342DA7 for ; Mon, 4 Dec 2023 19:37:35 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6ce387bcb06so988449b3a.0 for ; Mon, 04 Dec 2023 10:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1701715055; x=1702319855; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=lJu7JVfCle6KUEGoDHiryea1PhUfp9UcE9NKfZ7T6UQ=; b=SnFZ1bf1TORSCauILiliReKgf7wl1WSF8DqHz94uBgn/IQkYjmmQZcNRsDzQRfGufF RqxjGhp1UrtMtvCbHqh4hNyGEfIYa+ioPrdl9Y5HLP9RDw3UvaQCAAT+UjHcreWOmiaq zb7r1tk84JLqW+0Fu6f9dDlEkcvsPH2ZbwK8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701715055; x=1702319855; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lJu7JVfCle6KUEGoDHiryea1PhUfp9UcE9NKfZ7T6UQ=; b=EqGScYvw/huZlMgbQ/7+uH35StFy64IfUTGb6MdbWipZQnii3XbZLQnsI2VM+W8Gel rL//WVzdaJBe0CJ9ge7ECWA8IBoYl6iqKjdPE94FFEK37UpIjKGky6UwO3dR6Qm/SWX/ xWEM8QgGf3OVJxl3exJofr7OSHo5f9arBogUhwJootUpT2NxjLxMYL2k9ef6MXX5PCyo Zq57QZuWPP8JbzHPpgZbLCKHnQFbCDsnFgCwupy7WpAhni1GFC0um7v8rpkn13FKP8Zk OHxjox5O/7tRtTWp9Yd+RakYZSY+Uxl/bbIU2P1tYEq7LmAZJAUCKJijRvcZsttAz8wP 7n9A== X-Gm-Message-State: AOJu0YwKojPiyImxeDLpUArEfIANu3+Ea8vAFWxumOWAsOPdEuaULVmF YJOi9em7fz5/GEbvKSBTjybKigtBjtMTAgx74xWuXcSw7gtazvY2ug2E17wKh032Wn3s0+mV+07 NSI+szDBE/UV0goA9ns93Z1yQHFTYm/8lhnSCN+Pr6ISJqgIkSXq6NoeAWAJkW6V3e0n+ X-Google-Smtp-Source: AGHT+IGQtRMVkvM2LDmjwaktt5MFvH7SRFwZxRHWbT30ei7xS4YNX+lO1narxLmjbOKxPWNsLMrzxg== X-Received: by 2002:a05:6a00:800e:b0:6ce:6407:2264 with SMTP id eg14-20020a056a00800e00b006ce64072264mr795481pfb.56.1701715054595; Mon, 04 Dec 2023 10:37:34 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id s3-20020a056a00178300b006be5af77f06sm4236664pfg.2.2023.12.04.10.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 10:37:33 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli Subject: [PATCH 11/14] net/bnxt: modify sending new HWRM commands to firmware Date: Mon, 4 Dec 2023 10:37:07 -0800 Message-Id: <20231204183710.86921-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231204183710.86921-1-ajit.khaparde@broadcom.com> References: <20231204183710.86921-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If the firmware fails to respond a HWRM command in a certain time, it may be because the firmware is in a bad state. Do not send any new HWRM commands in such a scenario. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 68c4778dc3..f7a60eb9a1 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -745,6 +745,7 @@ struct bnxt { #define BNXT_FLAG_DFLT_MAC_SET BIT(26) #define BNXT_FLAG_GFID_ENABLE BIT(27) #define BNXT_FLAG_CHIP_P7 BIT(30) +#define BNXT_FLAG_FW_TIMEDOUT BIT(31) #define BNXT_PF(bp) (!((bp)->flags & BNXT_FLAG_VF)) #define BNXT_VF(bp) ((bp)->flags & BNXT_FLAG_VF) #define BNXT_NPAR(bp) ((bp)->flags & BNXT_FLAG_NPAR_PF) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 67f8020e3c..ccc5417af1 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -200,6 +200,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, if (bp->flags & BNXT_FLAG_FATAL_ERROR) return 0; + /* If previous HWRM command timed out, donot send new HWRM command */ + if (bp->flags & BNXT_FLAG_FW_TIMEDOUT) + return 0; + timeout = bp->hwrm_cmd_timeout; /* Update the message length for backing store config for new FW. */ @@ -300,6 +304,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, PMD_DRV_LOG(ERR, "Error(timeout) sending msg 0x%04x, seq_id %d\n", req->req_type, req->seq_id); + bp->flags |= BNXT_FLAG_FW_TIMEDOUT; return -ETIMEDOUT; } return 0;