From patchwork Sun Dec 10 01:24:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 134990 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96FEF436BE; Sun, 10 Dec 2023 02:33:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 976CB40ED9; Sun, 10 Dec 2023 02:31:59 +0100 (CET) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by mails.dpdk.org (Postfix) with ESMTP id 9FA7440DCE for ; Sun, 10 Dec 2023 02:31:55 +0100 (CET) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1fb04fb8d28so2015769fac.3 for ; Sat, 09 Dec 2023 17:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702171914; x=1702776714; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=dqaTeIe5rP8O548/FdoiAFmXeb8rPwoZ0/wzlUTixPc=; b=YBslGo2ZmP+DUaUOqbuSyBr0oDdSx2RX3sMgE9XwOrHZsSwxgSvyH2bWlEIZJH67Jm kOrjyQcufESNHL2tJFI5R/G6+UiDD6vP9C6KjApsBvB1W2CDUjVKqO0cox8q2HSNDE6j o+NOV+gf+nym5FzGbaD1rqmwMiuwDHGdSKeZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702171914; x=1702776714; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dqaTeIe5rP8O548/FdoiAFmXeb8rPwoZ0/wzlUTixPc=; b=T4X/eQISmi81PA+CtI4w8qxW+6nEEGefVlkFnk8SUiV5S+RWha0Yg7X6biqgnBd5qA +n4F4wP0sMgfnajyVvK6jOFm3Fn0FIblrKQk2+z+hZRkBfttK0XsthnwOcvJvfL0fACj ouh6+oMZZjmwwwHFIQYQikodr10dzGDIIQloXjNTJyMzViU+B3iluIgJ+W8QLlPozlAc 7UdPU3A4bkqNZa0LDcw2xrquetRX7Fz2nzACr9RMbNiK/+imeEChrHoetuBc96OqSHf+ vdJCkzOpWKPgPzrmwLtajMzqy3V4wqIBH5+xtv15L10lyN27Ux7IIGRoKh2XrM2ve7lL nXfw== X-Gm-Message-State: AOJu0Yxp1JnvAhrBtI72f5+uQH/F1WlxO6pHuoR+V04rS+qGFo6fN+Xr p0RcGLvGg4kqq6d+EOHVchZZSwl1gzvdw2lhAUpKY3jf31iU/IDQAh9WtncWmFhi7u1o5nkV6kg +nh/sceTAEf1pEh1WTp84UYiUe6GBfRuPjdhbSoV3gppSZWihQw30Np3jf7+MyjiJtyzC X-Google-Smtp-Source: AGHT+IG9Du8XXE8g41XI1a79V8WmfY3myDvLdMz3u9eWVpCGXlHAlHmIEPzqqGW8L35TY+WzDMo3nQ== X-Received: by 2002:a05:6358:cd20:b0:170:30db:119c with SMTP id gv32-20020a056358cd2000b0017030db119cmr812668rwb.29.1702171914399; Sat, 09 Dec 2023 17:31:54 -0800 (PST) Received: from localhost.localdomain ([2605:a601:a780:1400:6d20:fff:e413:282a]) by smtp.gmail.com with ESMTPSA id q3-20020a170902f78300b001d083fed5f3sm4006050pln.60.2023.12.09.17.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 17:31:53 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli Subject: [PATCH v2 11/14] net/bnxt: modify sending new HWRM commands to firmware Date: Sat, 9 Dec 2023 17:24:52 -0800 Message-Id: <20231210012455.20229-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231210012455.20229-1-ajit.khaparde@broadcom.com> References: <20231210012455.20229-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If the firmware fails to respond a HWRM command in a certain time, it may be because the firmware is in a bad state. Do not send any new HWRM commands in such a scenario. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 68c4778dc3..f7a60eb9a1 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -745,6 +745,7 @@ struct bnxt { #define BNXT_FLAG_DFLT_MAC_SET BIT(26) #define BNXT_FLAG_GFID_ENABLE BIT(27) #define BNXT_FLAG_CHIP_P7 BIT(30) +#define BNXT_FLAG_FW_TIMEDOUT BIT(31) #define BNXT_PF(bp) (!((bp)->flags & BNXT_FLAG_VF)) #define BNXT_VF(bp) ((bp)->flags & BNXT_FLAG_VF) #define BNXT_NPAR(bp) ((bp)->flags & BNXT_FLAG_NPAR_PF) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index dda3d3a6ac..2835d48a0e 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -215,6 +215,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, if (bp->flags & BNXT_FLAG_FATAL_ERROR) return 0; + /* If previous HWRM command timed out, donot send new HWRM command */ + if (bp->flags & BNXT_FLAG_FW_TIMEDOUT) + return 0; + timeout = bp->hwrm_cmd_timeout; /* Update the message length for backing store config for new FW. */ @@ -315,6 +319,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, PMD_DRV_LOG(ERR, "Error(timeout) sending msg 0x%04x, seq_id %d\n", req->req_type, req->seq_id); + bp->flags |= BNXT_FLAG_FW_TIMEDOUT; return -ETIMEDOUT; } return 0;