From patchwork Mon Dec 11 17:11:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135038 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7D57436C8; Mon, 11 Dec 2023 18:12:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A04B42DD4; Mon, 11 Dec 2023 18:11:42 +0100 (CET) Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by mails.dpdk.org (Postfix) with ESMTP id 26DF942DEC for ; Mon, 11 Dec 2023 18:11:41 +0100 (CET) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-1fb9c24a16aso3423723fac.0 for ; Mon, 11 Dec 2023 09:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702314700; x=1702919500; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=walHHvkbVOR7tCKXSU/LUIhTPw3kSMiMmPV206igwv4=; b=NlVz349PzYZXs88HqmTY2NIYehv4OjUfr75SaKJ/JlQEjaiqA5/45N1GV14sKNogWc 3dnIiJtI8uJHuKal+vgkBI6HsTk8ryVb52dJoNoIwjBFsWOZv/KXa2ilWTzbmjiYjQ5B u5pDoJw5Y5AqX4eaA/V3Q1DNwNvng7YUA1LXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702314700; x=1702919500; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=walHHvkbVOR7tCKXSU/LUIhTPw3kSMiMmPV206igwv4=; b=BqFAznAmw5BraCqjkWHuW/YOXK7MH6pBi72jJQHqjBowoOuwX6dGE7T96OKI4sfoz2 QnzshhDsdOR2YPelkM7sOq1nn6uUyCCHGNust/r3kzeNLSt34W4L2dmtK/ks7hgIytj9 dW0igURtLa0kt4s0CNDMVPyjL46oALvcP/4W7hAlNHbOZGjgTIuCFUZKyLr2h+UaeWI8 Tgw1mTVPUP8LdlgxaUzkGzpy4+Dbyhcip0XpVIaCgb3NXxXHNy32mb+DUssuMXSgxfsU dSh6/mss6pa/zGN+WNuylKkmYoX2zoZl6frJ8NQ1K5PNx9TnSX7t4vXFDfLGgC+EE8Mq o7Fw== X-Gm-Message-State: AOJu0Yxius7+Q7j43u6S5DVsSMNL2Ji1aEbEB5EhXtyZjdm795SFIeAK ppAZ+rrnYwzJL5WjBKqQT/sR3myVb9jUvRHX5joH2K+cW7MqKd2Qka39RrMy2TADI9OkD+4E5fp K1rCVchcvbI6O8OHBWqg9nicelCCjOFai7wX7wJMw24oNsXzRgBaQgD+JbKNCZGa5/Np5 X-Google-Smtp-Source: AGHT+IEcTjarIBdpemNHJqt9no749Of9FhDQr6iKlfJf2L2JFXxHm+Wy7nxubkabjBj2TnAsJcp36w== X-Received: by 2002:a05:6871:58a1:b0:1fa:fcfb:2a7d with SMTP id ok33-20020a05687158a100b001fafcfb2a7dmr5886330oac.19.1702314700071; Mon, 11 Dec 2023 09:11:40 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id qz16-20020a05620a8c1000b0077efdfbd730sm3094581qkn.34.2023.12.11.09.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 09:11:39 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli Subject: [PATCH v3 11/14] net/bnxt: modify sending new HWRM commands to firmware Date: Mon, 11 Dec 2023 09:11:06 -0800 Message-Id: <20231211171109.89716-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231211171109.89716-1-ajit.khaparde@broadcom.com> References: <20231211171109.89716-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If the firmware fails to respond a HWRM command in a certain time, it may be because the firmware is in a bad state. Do not send any new HWRM commands in such a scenario. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 68c4778dc3..f7a60eb9a1 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -745,6 +745,7 @@ struct bnxt { #define BNXT_FLAG_DFLT_MAC_SET BIT(26) #define BNXT_FLAG_GFID_ENABLE BIT(27) #define BNXT_FLAG_CHIP_P7 BIT(30) +#define BNXT_FLAG_FW_TIMEDOUT BIT(31) #define BNXT_PF(bp) (!((bp)->flags & BNXT_FLAG_VF)) #define BNXT_VF(bp) ((bp)->flags & BNXT_FLAG_VF) #define BNXT_NPAR(bp) ((bp)->flags & BNXT_FLAG_NPAR_PF) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index a2182af036..1cc2c532dd 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -215,6 +215,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, if (bp->flags & BNXT_FLAG_FATAL_ERROR) return 0; + /* If previous HWRM command timed out, donot send new HWRM command */ + if (bp->flags & BNXT_FLAG_FW_TIMEDOUT) + return 0; + timeout = bp->hwrm_cmd_timeout; /* Update the message length for backing store config for new FW. */ @@ -315,6 +319,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, PMD_DRV_LOG(ERR, "Error(timeout) sending msg 0x%04x, seq_id %d\n", req->req_type, req->seq_id); + bp->flags |= BNXT_FLAG_FW_TIMEDOUT; return -ETIMEDOUT; } return 0;