From patchwork Wed Dec 13 03:24:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 135103 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F941436D9; Wed, 13 Dec 2023 04:25:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91AC942EA6; Wed, 13 Dec 2023 04:24:44 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2123.outbound.protection.outlook.com [40.107.93.123]) by mails.dpdk.org (Postfix) with ESMTP id 2E43B42E98 for ; Wed, 13 Dec 2023 04:24:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uy6ScTyL1g8ZwElLZvKM0widVpBRXtEcLoYyd85Y9fFlPSZspC7kEutwP26KawBewQz/YOQkeZppoOSeDmhrKN1PCPLbR98w8wG3ioaiqn/r0heAo5mvACBmhSMLd2O5DeztUahCxOuWD/FqCX1H9YSORMheWEx2uuk8lBLt4ypQnaJ/YT+Qx1PGU79XVMrsSNWuU2r24SALEo9CBFeFQSQ3vDqYpWp3Prxj+FYiamUr8vIU6g3sTp5LzduFHOGJEvR2C17X1rGtYM2kAcBd9wvLFeXe3ThoCzy0q+sAKkIVYzm8rDHRmAezz3jHtcKORuLAwXfYGqRxhVflclA5fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sqMUidzzypRe6ziUPzzLsMDj1zZ0xOjpQXSijQRnJv0=; b=UTH6eZfTZCkyKH5++DAqpzHPlO2lfNkMixrIZncFrTapTCtEMIJJdCM7/GFVY+e4DAbKd3kNsnja34GPKAYf8WGpkDx6CID1xX8zGhvxYRxsvEGV1PFUQuj9a3IVYxFazUCI1JUc6q4g3l+pF9cFsITi1BKs8dGFi5GzrfP/xoOVVSYzflyLfzljL89KbWm2kLeAAxJ8Rg7AQMLksSpkvHnrj6Ji1oSDZo9RbNN/Sdfk6xT8xEFPm/UQkWY7GUrrebuheWQCuwBiaqJeYBMotqjYjyGswwRgsLONu2vHT7SXYpZn84xJPEtLfca18hm2i6jYSWo/ydQjEPrMuZjTow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sqMUidzzypRe6ziUPzzLsMDj1zZ0xOjpQXSijQRnJv0=; b=stnRSPUBwDIUFOSSaIr2QMDW3AayEVXqtPVXxCgSngXsCPM77+H50AoDKPULP2OErUApTQsv+8mW0kAjlhS9+yyNvxFO5sbRyQDTXcQPjU73cTk3xIkkRCfsJi5UbLMEdiV01y8bvVUOOVzAGoS21n1lSXSnrzuE+oCe9t5Dz+U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA3PR13MB6259.namprd13.prod.outlook.com (2603:10b6:806:2f3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Wed, 13 Dec 2023 03:24:41 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7091.022; Wed, 13 Dec 2023 03:24:41 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , Peng Zhang , Long Wu Subject: [PATCH 3/5] net/nfp: modify the logic of set MAC address Date: Wed, 13 Dec 2023 11:24:14 +0800 Message-Id: <20231213032416.1988817-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231213032416.1988817-1-chaoyong.he@corigine.com> References: <20231213032416.1988817-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SJ0PR03CA0351.namprd03.prod.outlook.com (2603:10b6:a03:39c::26) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SA3PR13MB6259:EE_ X-MS-Office365-Filtering-Correlation-Id: f89b70d6-720d-42c0-9b06-08dbfb8b0b8a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SIUCf+tlEpzXuf6aJSMA4X+2Ingg4IlOdUZJ7qMIMBsec9rWvx1jthPEgunkYnchsaQ2tPWbZEoOFjXdYdqFHElE+nDuf+gtVy74ZT6QVb1JfYaPRijJ4UtKR8fps3Bo6g1kd9tf9PIGfQcUPk3fT9o+HXF+zYR4crlnU8ag+LRSJmC/gSZxy696/Cn1b0pH3BgO6NIVh3Z6L+HXVU6+hzrti2hEcrGW5yGFFzrEJt2hHsKR3NrwOXL4t4Nur0LM4c9WmOVA8110tS7cE2BhWzxD/SVCbhlQO/P/FoEnMklNCni+CvNmL0pHj4KEGYgibQAUD5ex4I33Z2ZGKkm8+jdCqye/L9r3uYbtySwWUqYYV8wr4PmPS5VSUtPC4SmZz4HktdVlg7yc04pPaIONxwdq223RF2c7Ex4ToE2Lo01DFv5NNpZKwIYnXkUnsGTNhq5v9zxSuB9dKvSizHeX/L7E2Fc980uSvlQ+8mZWuy37Tcv4Xr/xooIwwjy7mX7nxiH2Sy8eomEwOtFg649+cBJrFsNwTh/I7mYb13NHmewOq2TM81RY+Ed8acjRMO57jjw5TjUlIXbxYhu2whsiyRKClP5AcRhIdA0o+waU/lVq0Tp68qPOlm7aaQvE5wguKB1j/fUwvoY2F9JuGBRSc9H4SwHSMA0s9mWQ9b4XP4g= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(136003)(376002)(396003)(366004)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(54906003)(66556008)(66946007)(66476007)(41300700001)(1076003)(6506007)(2616005)(107886003)(26005)(6666004)(6512007)(36756003)(38350700005)(38100700002)(52116002)(86362001)(478600001)(6486002)(44832011)(4744005)(8676002)(8936002)(2906002)(4326008)(5660300002)(6916009)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JSEj5kejtNJkvNmWFkgERBHkWFJ2SoUVh80bGQ4H/egUW+6R5JUC5hejCqmhl7oqFkCLP4WvvAI6wAgjYi4pCZgIDKL5yUpkNgeADU7zJszqTHkXx9TFQKEjX7Go5P4K3/oMGNvQMBasG3xo7JjsYmdPImfIvezLejL2wVIZaGJkvHKa3DWUSB7roUsjKaB7fimzWw187DYN2w678xK1aG7TniyQ9hbHsizcnNdcC0omM06BSKQC1MbMHyikUk1De0nQ1hBeDzeAAXRN67LE2GjacJOexcaysPdEHT8lNvq0kiaJzgdG5CKvGML/7SO/H16le+ZqBrlzIAXcNU8jQOGp6AhzG3ZSj9b3WCZUcSpdkaB+ZY0alOH4JE4h948EojI3VPKazioSffQe90B5PYeFr7r2ZyNUOGuM9lcJmUb8qtz+P5xs7LmVZJpX2dWRWGSpn1ywAlE5/z1+5Y37KeRbyUKdF6UjF8tHU7u1/aehk+hdM26zGVXziBaAWXaO+YBhgjjoxxm0AorqNrDWHEmZ6DcfhqUDpxOjgHJ04Ms1v1bGGrbe08fB4aKIl6COTAQ4ZZvjJY2EtlB5a3jrurXBHd1NGk5uBclk9KYD3JseGWHbmY4yOgMeahFsgAHKzDYm4KxD6GmI/9iMGAOHQM0/ZCWIeZiiMeB60ZDm6oQTPJGOgGk8lPrRIQEY95JWJzgDhFBCQwKanGFOQ8C7HMVhOpWL7K/ZJvlx31uKHjK8LaAJA3SjmHaV52/LOmEiUdbNo7bTKuOm4vpjzy7A9Zmst2f4tHj2XT9nkPl4FbemWETeb7LZ8Mie1zYP5h90M4QxLQC5GbpXUDs8yv2oOHETV0vFkP3h5p9MDiF+Q+RES5KeNwGJRFS5CsZ+Y/Tb0eCw9v5jtOvrGr+69kOiujMdQLyP79bkOOVx4v7MoLBOzPUzvdwiFx+W/vpX5rA2rbqIBpMDXzURKqR+Lw1mQFtUG3Nhslszg7iTDKpBGEPNbwAc6CW/msnbqi9h7qX9+4u15zpRyAvUhYdXAfbPz2vNXo+z7RMiLhGin3qu18beB5lfrcIk21mSGgZ1BAOxlZocoq4pQCZnSUXfZunUbAnRA4ix93cUdgZy3CFZZPKT5MZcfBZ4XtMaYTb+753ueSmxsvd25j45k0odgGkoWn1kM1Mi1qNo7pbPxXHE4WR748lvW0ot2V5rHTnP4o8ND9jmzt5To6bhdbFf0ri71ksw3f8Jhlvg7aFmVwBkeru4lXwKnuyO8X+wd6tHlRdwS2sQLm/JA36FheHaXVAfLdKjhkXzy5M/KZ1Rg/LA1HfuYC28WeKGvD1/r43WtgBcXfXbGD4tcdsfEKKTNv9QvpRe4a/Z3y6BDr1Ix6TycoKeA1nGH9Q8N5VSUB4VIE+5CqJiMIIIIozc4alEAntwfWCmHBCmyJdB2yPidDzaT2MTxUG+mQRaND3+5+GYpoDG17BRDietO1jz8CLmLIWI15XvaWYZ9nj/gT8YF7Zq0W9MjisCUxuTRgNTBDUyq89zuGQosQ+KEFOnc3pQhgVeOGlxmBuLVFLrLXfMKFst6w5hpJsBRT6kqeZE57yWy0lwHX7clEomWqafcY0kfTdqWg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: f89b70d6-720d-42c0-9b06-08dbfb8b0b8a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 03:24:41.8534 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u0dd/1qZ+hhYUgb7ntmQjDqUTOjqyKovl8MPA2krsW+tkk+uM3uA4R7eFnEnxhm6qN4I3bZBbDpNNMfIo7JlcR/9jWpqLpBQ9V/Z54CR7lc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR13MB6259 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Modify the logic of set MAC address, add the check logic of MAC address. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang Reviewed-by: Long Wu --- drivers/net/nfp/nfp_net_common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index 12b62c1958..99e2fc54e0 100644 --- a/drivers/net/nfp/nfp_net_common.c +++ b/drivers/net/nfp/nfp_net_common.c @@ -417,6 +417,11 @@ nfp_net_set_mac_addr(struct rte_eth_dev *dev, return -EBUSY; } + if (rte_is_valid_assigned_ether_addr(mac_addr) == 0) { + PMD_DRV_LOG(ERR, "Invalid MAC address"); + return -EINVAL; + } + /* Writing new MAC to the specific port BAR address */ nfp_write_mac(hw, (uint8_t *)mac_addr);