diff mbox series

[v3,30/37] raw/ifpga: replace PMD logtype with dynamic type

Message ID 20231213163820.894987-31-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Replace uso of RTE_LOGTYPE_PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Dec. 13, 2023, 4:36 p.m. UTC 
  Driver should not be using PMD logtype, they should have their
own logtype.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Xu, Rosen Dec. 14, 2023, 12:01 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, December 14, 2023 12:36 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Xu, Rosen
> <rosen.xu@intel.com>; Tianfei Zhang <tianfei.zhang@intel.com>
> Subject: [PATCH v3 30/37] raw/ifpga: replace PMD logtype with dynamic type
> 
> Driver should not be using PMD logtype, they should have their own logtype.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
> b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
> index 33041c907e19..ad885107ab7d 100644
> --- a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
> +++ b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
> @@ -16,8 +16,10 @@
>  #include <rte_byteorder.h>
>  #include <rte_memcpy.h>
> 
> +extern int ifpga_rawdev_logtype;
> +
>  #define dev_printf(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "osdep_rte: " fmt, ## args)
> +	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "osdep_rte: "
> fmt, ##
> +args)
> 
>  #define osdep_panic(...) rte_panic(...)
> 
> --
> 2.43.0

Reviewed-by: Rosen Xu <rosen.xu@intel.com>
diff mbox series

Patch

diff --git a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
index 33041c907e19..ad885107ab7d 100644
--- a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
+++ b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h
@@ -16,8 +16,10 @@ 
 #include <rte_byteorder.h>
 #include <rte_memcpy.h>
 
+extern int ifpga_rawdev_logtype;
+
 #define dev_printf(level, fmt, args...) \
-	RTE_LOG(level, PMD, "osdep_rte: " fmt, ## args)
+	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "osdep_rte: " fmt, ## args)
 
 #define osdep_panic(...) rte_panic(...)