[2/2] net/cnxk: support PPPoE flow item type

Message ID 20231214071759.411405-2-psatheesh@marvell.com (mailing list archive)
State Changes Requested, archived
Delegated to: Jerin Jacob
Headers
Series [1/2] common/cnxk: support PPPoE flow item type in ROC API |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Satheesh Paul Antonysamy Dec. 14, 2023, 7:17 a.m. UTC
  From: Satheesh Paul <psatheesh@marvell.com>

Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item
type for cnxk device.

Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
 doc/guides/nics/features/cnxk.ini     | 1 +
 doc/guides/nics/features/cnxk_vec.ini | 1 +
 doc/guides/nics/features/cnxk_vf.ini  | 1 +
 drivers/net/cnxk/cnxk_flow.c          | 7 ++++---
 4 files changed, 7 insertions(+), 3 deletions(-)
  

Comments

Jerin Jacob Kollanukkaran Dec. 14, 2023, 1:42 p.m. UTC | #1
> -----Original Message-----
> From: psatheesh@marvell.com <psatheesh@marvell.com>
> Sent: Thursday, December 14, 2023 12:48 PM
> To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar
> Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori
> <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>
> Cc: dev@dpdk.org; Satheesh Paul Antonysamy <psatheesh@marvell.com>
> Subject: [EXT] [dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Satheesh Paul <psatheesh@marvell.com>
> 
> Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item type for cnxk
> device.
> 
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>

Please update the release notes for this new feature.


> ---
>  doc/guides/nics/features/cnxk.ini     | 1 +
>  doc/guides/nics/features/cnxk_vec.ini | 1 +
> doc/guides/nics/features/cnxk_vf.ini  | 1 +
>  drivers/net/cnxk/cnxk_flow.c          | 7 ++++---
>  4 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/features/cnxk.ini
> b/doc/guides/nics/features/cnxk.ini
> index ac7de9a0f0..cc7deaeaa9 100644
> --- a/doc/guides/nics/features/cnxk.ini
> +++ b/doc/guides/nics/features/cnxk.ini
> @@ -71,6 +71,7 @@ ipv6_routing_ext     = Y
>  mark                 = Y
>  mpls                 = Y
>  nvgre                = Y
> +pppoes               = Y
>  raw                  = Y
>  sctp                 = Y
>  tcp                  = Y
> diff --git a/doc/guides/nics/features/cnxk_vec.ini
> b/doc/guides/nics/features/cnxk_vec.ini
> index e2cac64e4b..6086b3d73f 100644
> --- a/doc/guides/nics/features/cnxk_vec.ini
> +++ b/doc/guides/nics/features/cnxk_vec.ini
> @@ -65,6 +65,7 @@ ipv6_frag_ext        = Y
>  mark                 = Y
>  mpls                 = Y
>  nvgre                = Y
> +pppoes               = Y
>  raw                  = Y
>  sctp                 = Y
>  tcp                  = Y
> diff --git a/doc/guides/nics/features/cnxk_vf.ini
> b/doc/guides/nics/features/cnxk_vf.ini
> index b03e8b35c3..53aa2a3d0c 100644
> --- a/doc/guides/nics/features/cnxk_vf.ini
> +++ b/doc/guides/nics/features/cnxk_vf.ini
> @@ -62,6 +62,7 @@ ipv6_routing_ext     = Y
>  mark                 = Y
>  mpls                 = Y
>  nvgre                = Y
> +pppoes               = Y
>  raw                  = Y
>  sctp                 = Y
>  tcp                  = Y
> diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c index
> 08ab75e2bb..2eee44ed09 100644
> --- a/drivers/net/cnxk/cnxk_flow.c
> +++ b/drivers/net/cnxk/cnxk_flow.c
> @@ -62,11 +62,12 @@ const struct cnxk_rte_flow_term_info term[] = {
>  	[RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT] =
> {ROC_NPC_ITEM_TYPE_IPV6_ROUTING_EXT,
>  				     sizeof(struct
> rte_flow_item_ipv6_routing_ext)},
>  	[RTE_FLOW_ITEM_TYPE_TX_QUEUE] =
> {ROC_NPC_ITEM_TYPE_TX_QUEUE,
> -				     sizeof(struct rte_flow_item_tx_queue)}};
> +				     sizeof(struct rte_flow_item_tx_queue)},
> +	[RTE_FLOW_ITEM_TYPE_PPPOES] = {ROC_NPC_ITEM_TYPE_PPPOES,
> +				     sizeof(struct rte_flow_item_pppoe)}};
> 
>  static int
> -npc_rss_action_validate(struct rte_eth_dev *eth_dev,
> -			const struct rte_flow_attr *attr,
> +npc_rss_action_validate(struct rte_eth_dev *eth_dev, const struct
> +rte_flow_attr *attr,
>  			const struct rte_flow_action *act)
>  {
>  	const struct rte_flow_action_rss *rss;
> --
> 2.39.2
  

Patch

diff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini
index ac7de9a0f0..cc7deaeaa9 100644
--- a/doc/guides/nics/features/cnxk.ini
+++ b/doc/guides/nics/features/cnxk.ini
@@ -71,6 +71,7 @@  ipv6_routing_ext     = Y
 mark                 = Y
 mpls                 = Y
 nvgre                = Y
+pppoes               = Y
 raw                  = Y
 sctp                 = Y
 tcp                  = Y
diff --git a/doc/guides/nics/features/cnxk_vec.ini b/doc/guides/nics/features/cnxk_vec.ini
index e2cac64e4b..6086b3d73f 100644
--- a/doc/guides/nics/features/cnxk_vec.ini
+++ b/doc/guides/nics/features/cnxk_vec.ini
@@ -65,6 +65,7 @@  ipv6_frag_ext        = Y
 mark                 = Y
 mpls                 = Y
 nvgre                = Y
+pppoes               = Y
 raw                  = Y
 sctp                 = Y
 tcp                  = Y
diff --git a/doc/guides/nics/features/cnxk_vf.ini b/doc/guides/nics/features/cnxk_vf.ini
index b03e8b35c3..53aa2a3d0c 100644
--- a/doc/guides/nics/features/cnxk_vf.ini
+++ b/doc/guides/nics/features/cnxk_vf.ini
@@ -62,6 +62,7 @@  ipv6_routing_ext     = Y
 mark                 = Y
 mpls                 = Y
 nvgre                = Y
+pppoes               = Y
 raw                  = Y
 sctp                 = Y
 tcp                  = Y
diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
index 08ab75e2bb..2eee44ed09 100644
--- a/drivers/net/cnxk/cnxk_flow.c
+++ b/drivers/net/cnxk/cnxk_flow.c
@@ -62,11 +62,12 @@  const struct cnxk_rte_flow_term_info term[] = {
 	[RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT] = {ROC_NPC_ITEM_TYPE_IPV6_ROUTING_EXT,
 				     sizeof(struct rte_flow_item_ipv6_routing_ext)},
 	[RTE_FLOW_ITEM_TYPE_TX_QUEUE] = {ROC_NPC_ITEM_TYPE_TX_QUEUE,
-				     sizeof(struct rte_flow_item_tx_queue)}};
+				     sizeof(struct rte_flow_item_tx_queue)},
+	[RTE_FLOW_ITEM_TYPE_PPPOES] = {ROC_NPC_ITEM_TYPE_PPPOES,
+				     sizeof(struct rte_flow_item_pppoe)}};
 
 static int
-npc_rss_action_validate(struct rte_eth_dev *eth_dev,
-			const struct rte_flow_attr *attr,
+npc_rss_action_validate(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,
 			const struct rte_flow_action *act)
 {
 	const struct rte_flow_action_rss *rss;