diff mbox series

[v2] config/x86: config support for AMD EPYC processors

Message ID 20231221051152.2450-1-sivaprasad.tummala@amd.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] config/x86: config support for AMD EPYC processors |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

Sivaprasad Tummala Dec. 21, 2023, 5:11 a.m. UTC 
  On x86 platforms, max lcores are limited to 128 by default.

On AMD EPYC processors, this limit was adjusted for native
builds in the previous patch.
https://patches.dpdk.org/project/dpdk/patch/
20230925151027.558546-1-sivaprasad.tummala@amd.com/

As agreed earlier in mailing list, this patch adjusts the limit
for specific AMD EPYC target/cross builds.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 config/x86/meson.build | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Konstantin Ananyev Jan. 2, 2024, 6:18 p.m. UTC | #1 
> On x86 platforms, max lcores are limited to 128 by default.
> 
> On AMD EPYC processors, this limit was adjusted for native
> builds in the previous patch.
> https://patches.dpdk.org/project/dpdk/patch/
> 20230925151027.558546-1-sivaprasad.tummala@amd.com/
> 
> As agreed earlier in mailing list, this patch adjusts the limit
> for specific AMD EPYC target/cross builds.
> 
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
>  config/x86/meson.build | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/config/x86/meson.build b/config/x86/meson.build
> index 5355731cef..8087b9ae91 100644
> --- a/config/x86/meson.build
> +++ b/config/x86/meson.build
> @@ -91,13 +91,21 @@ epyc_zen_cores = {
>      '__znver1__':128
>      }
> 
> -if get_option('platform') == 'native'
> +cpu_instruction_set = get_option('cpu_instruction_set')
> +if cpu_instruction_set == 'native'
>      foreach m:epyc_zen_cores.keys()
>          if cc.get_define(m, args: machine_args) != ''
>              dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
>              break
>          endif
>      endforeach
> +else
> +    foreach m:epyc_zen_cores.keys()
> +        if m.contains(cpu_instruction_set)
> +            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> +            break
> +        endif
> +    endforeach
>  endif
> 
>  dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
 

> 2.25.1
Thomas Monjalon Feb. 13, 2024, 2:28 p.m. UTC | #2 
02/01/2024 19:18, Konstantin Ananyev:
> 
> > On x86 platforms, max lcores are limited to 128 by default.
> > 
> > On AMD EPYC processors, this limit was adjusted for native
> > builds in the previous patch.
> > https://patches.dpdk.org/project/dpdk/patch/
> > 20230925151027.558546-1-sivaprasad.tummala@amd.com/
> > 
> > As agreed earlier in mailing list, this patch adjusts the limit
> > for specific AMD EPYC target/cross builds.
> > 
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/config/x86/meson.build b/config/x86/meson.build
index 5355731cef..8087b9ae91 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -91,13 +91,21 @@  epyc_zen_cores = {
     '__znver1__':128
     }
 
-if get_option('platform') == 'native'
+cpu_instruction_set = get_option('cpu_instruction_set')
+if cpu_instruction_set == 'native'
     foreach m:epyc_zen_cores.keys()
         if cc.get_define(m, args: machine_args) != ''
             dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
             break
         endif
     endforeach
+else
+    foreach m:epyc_zen_cores.keys()
+        if m.contains(cpu_instruction_set)
+            dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
+            break
+        endif
+    endforeach
 endif
 
 dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)