From patchwork Thu Dec 21 18:05:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135478 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9F6443752; Thu, 21 Dec 2023 19:05:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A10B042E65; Thu, 21 Dec 2023 19:05:41 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 7D48340A7A for ; Thu, 21 Dec 2023 19:05:39 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d3ed1ca402so8899235ad.2 for ; Thu, 21 Dec 2023 10:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703181938; x=1703786738; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=zVhl1e7MluG7hd8WZJF+7GNnwoCtObqIPeEo121Civw=; b=LtbjuM++HkVP1w2Ka0Lbterf+xHxIB/hRpsyrClO2+tUZ5v6heNmYvzj74sQzEKO9X Vx+CdNtim3LAJKRh4rq4p1KSf+G5OJFahNwco0ahwZfSQo9MSoX8j6oOfJKEsSaxZ+bH YdIJ1CYQOfhaLreFDKWBCv+8H4jx7FNxzBDJY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703181938; x=1703786738; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zVhl1e7MluG7hd8WZJF+7GNnwoCtObqIPeEo121Civw=; b=OK9hIwA6MzSafCOqtmzqf6ydQmm8ztUXkB9Kf6aMPbrpYjm3mLtJQfrpv8DdJE+nxA B4An7XRzItpi1AINqed1vh9qqs2g54NFap/sx2DWwO4xzPpbQp3ZG+bmQInMBWzyquAn xZycG+viW6hM1gtH9ogf4EvItn35DmlW4gx6KP2sfH1X0p6Xshs1O0BOeCMg0Sw+l6xR QLWB/Xpi7jrLFwnCPM4ygG4h/t05MflCDRKtrONuJxpTmgBfzCFoIlZCLuFgsvGlauMt HFMb8bGVvLn5lNCLyndKPj48L8ZiWtKLU0LpxesllGNC4y4PV5q0BGIHGFhxT2vWnmRH lrJw== X-Gm-Message-State: AOJu0YzH95eS09CzguWhoZJ85/fY6nnoy+Rl+joa5CavnEhmVzRmIvi4 6h+g5KUFuGps5GRE7Q6k0WRxWExUzyAkCu4OeH9dwFpZBfvKE+48hnMk/ifIc49YJc5tK7L2Q9i zvEE60nkLitQ8xzvpwrW6NAT53HBM4PNC5+mqkFd4Zk+aigSjZu2onZw1RW2PIMa2n0y1ONzhta w= X-Google-Smtp-Source: AGHT+IHoB12lqOE50wFANWU8cOxlECaan8VGJZxrWKqBCRf8sEWF85je3dk2Ga3eaj9TgtiAq3TTAg== X-Received: by 2002:a17:903:1247:b0:1d0:6b95:9c0d with SMTP id u7-20020a170903124700b001d06b959c0dmr18967plh.65.1703181938000; Thu, 21 Dec 2023 10:05:38 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j17-20020a170902da9100b001d3b3ac2d7bsm1916379plx.245.2023.12.21.10.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:05:37 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP Subject: [PATCH 03/18] net/bnxt: fix a typo while parsing link speed Date: Thu, 21 Dec 2023 10:05:14 -0800 Message-Id: <20231221180529.18687-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231221180529.18687-1-ajit.khaparde@broadcom.com> References: <20231221180529.18687-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP While setting forced speed, the speed should have mapped to macro "HWRM_PORT_PHY_CFG_INPUT_FORCE_xxx" instead of "HWRM_PORT_PHY_CFG_INPUT_AUTO_xxx". We do not see any issue as both these macros are defined to the same value. Fixing it for better convey the intent. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 378be997d3..8f99582819 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3168,15 +3168,15 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, case RTE_ETH_LINK_SPEED_100M_HD: /* FALLTHROUGH */ eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_100MB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_100MB; break; case RTE_ETH_LINK_SPEED_1G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_1GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_1GB; break; case RTE_ETH_LINK_SPEED_2_5G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_2_5GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_2_5GB; break; case RTE_ETH_LINK_SPEED_10G: eth_link_speed = @@ -3184,11 +3184,11 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, break; case RTE_ETH_LINK_SPEED_20G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_20GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_20GB; break; case RTE_ETH_LINK_SPEED_25G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_25GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_25GB; break; case RTE_ETH_LINK_SPEED_40G: eth_link_speed =