From patchwork Wed Dec 27 04:21:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135591 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 724E3437A1; Wed, 27 Dec 2023 05:21:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30A5A402F1; Wed, 27 Dec 2023 05:21:33 +0100 (CET) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by mails.dpdk.org (Postfix) with ESMTP id 52BA2402E5 for ; Wed, 27 Dec 2023 05:21:30 +0100 (CET) Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-78104f6f692so376088585a.1 for ; Tue, 26 Dec 2023 20:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703650889; x=1704255689; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=GYbFZxWf+uxmltZ5jehAfAQL5FbAF+Gl6saPHeuLmHQ=; b=OLqgpMw6DChCPzkvtkCrFlkAyora03vAC0f3mcH0aCtq/RXnUlrCFJaMI7tPGEk+3P w0D5f00RVqREjsNntHfvpBTN6GqS7IbTlHStw48qo+d9wU+uQDeT+7a5O1l7I1CJoJob dipyLhF/v6lehW4ougPMrym7BgORXCuBD/Iqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703650889; x=1704255689; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GYbFZxWf+uxmltZ5jehAfAQL5FbAF+Gl6saPHeuLmHQ=; b=uhqBzFYq3oixF0e5xc+EHsym9T97mrL2Hcx1qDICfe9bKNDiJ4kq/gdIRdhCAMdfqS nD5vofEEfO3834sHu/eeuvVwrdN6ehrCaIuqk0rIunUAFWVskwCTUJOU45/cGj6KYcWC ZpuUl9Vy6TB8J/mmZz4w7MXbvYEOUtRioC3LLixnpWNvBzUHI1yd5/Q++d1ydHINAtBW PWDcxV6idladiV2vPGkLLhgNue+3gZ5I1ktAnDeuHvzFw6eJtehEjUJ8smH1VSGBtj3d I8BIgrzDX/jz3xh8YeeFAewEaZXPUDGMYD1YXZc/01oySOq1F6rmvaXbgvjGpDrQ82bi ibRg== X-Gm-Message-State: AOJu0YxqkeNSnG0dwbr5syyIqAfHKkOTSFiSIF7krO4jwEdc5m5hj8Sd RqQQP38B9Tya5xyTkn61qRR8zKR8zDnBBWNQBXf7FtrGLm4LbhPb66c3r4jRQ6q13xCuBlX8FRv aSP5sp4waXVzk541l/t20+DnwuRg+WC8kHvJ9RGyqVjvXwUxGiNqUdtDad1ey7X4MJuitOFupZu 8= X-Google-Smtp-Source: AGHT+IGOZpU/ajhokjXOtdZV774mA4aUPKoZJSh1LUMA7dMfJCw7TW2AHrLRwDh/32ET3zcrQO9f4Q== X-Received: by 2002:a05:620a:4aca:b0:781:5a79:ef98 with SMTP id sq10-20020a05620a4aca00b007815a79ef98mr1509197qkn.0.1703650889118; Tue, 26 Dec 2023 20:21:29 -0800 (PST) Received: from localhost.localdomain ([2605:a601:a780:1400:c066:75e3:74c8:50e6]) by smtp.gmail.com with ESMTPSA id bt7-20020ac86907000000b00427e120889bsm1415488qtb.91.2023.12.26.20.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 20:21:28 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP Subject: [PATCH v3 03/18] net/bnxt: fix a typo while parsing link speed Date: Tue, 26 Dec 2023 20:21:04 -0800 Message-Id: <20231227042119.72469-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231227042119.72469-1-ajit.khaparde@broadcom.com> References: <20231227042119.72469-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP While setting forced speed, the speed should have mapped to macro "HWRM_PORT_PHY_CFG_INPUT_FORCE_xxx" instead of "HWRM_PORT_PHY_CFG_INPUT_AUTO_xxx". We do not see any issue as both these macros are defined to the same value. Fixing it for better convey the intent. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 378be997d3..8f99582819 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3168,15 +3168,15 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, case RTE_ETH_LINK_SPEED_100M_HD: /* FALLTHROUGH */ eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_100MB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_100MB; break; case RTE_ETH_LINK_SPEED_1G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_1GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_1GB; break; case RTE_ETH_LINK_SPEED_2_5G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_2_5GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_2_5GB; break; case RTE_ETH_LINK_SPEED_10G: eth_link_speed = @@ -3184,11 +3184,11 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t conf_link_speed, break; case RTE_ETH_LINK_SPEED_20G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_20GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_20GB; break; case RTE_ETH_LINK_SPEED_25G: eth_link_speed = - HWRM_PORT_PHY_CFG_INPUT_AUTO_LINK_SPEED_25GB; + HWRM_PORT_PHY_CFG_INPUT_FORCE_LINK_SPEED_25GB; break; case RTE_ETH_LINK_SPEED_40G: eth_link_speed =