From patchwork Fri Jan 12 07:50:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Li X-Patchwork-Id: 135847 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E4984389F; Fri, 12 Jan 2024 08:51:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCC84064E; Fri, 12 Jan 2024 08:51:33 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2064.outbound.protection.outlook.com [40.107.220.64]) by mails.dpdk.org (Postfix) with ESMTP id 5A3E44064A for ; Fri, 12 Jan 2024 08:51:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ChfugGX2xmQoHhgnYbKDe5wUYjeZBLMZ5Irh5mmsqjcXYbXNlTe917QYXgwD5VBlThcBvbPtj3+uK4CLFNBqWMf/tDBmFi2XRPDJX83Jo38jjgl5pqeZiy5eBGZedqeparn5Ic5i5tg6vM2sT1NsV5+oxSSZhe87Ngaa93w5dRcJWvr/pFoJHp0NZjMTKPPsSNpVT5vNpQ5RimT66cRwJN7uSEPUbzt+Vqw9nb/pwZw5ihVa3beapzNFQmWSyn1iwSh60WpvzZ6ALtpPlikZShHnVwJhGvnrNeakLyxngNRbxj84mVgTehmlpdbRm3rsQsB5YJKx7w0WuNPneOHwcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xweu5PjNsV6taB0p7Bc3RlU3N6MTcmei58Lx2vln1us=; b=Fr7tPPeVqOP16cZ/JJobgI90y2LzBk+z8mQulsWzDmhrZ7H1zyX3X+7GVD4GjtnHYlzHhpAHkxHTQktFmlvXcsLjZzPmq/NErxvDHQ6G7AfY5l6NEm3/hP0uDmCBp3kSD7I75tSVExwcuRFowvv3l9/+QJGN7OXxibAZo4MteLzvffe5fXJfDTT2BZXNUNLW5L65kYg1YK3AlWNUU3dPushE1B9xHwgohRQnXe8RoIz6ZM5i2Syv9ceUeCsYVO5QjOuNPl/VFaILUZGxkRugQHGeK3Ri2W/74iXb2pPIbzdmwgOdTm/8GdqcujRQL37tEXCZDenyGOtLsisw8VJ2mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xweu5PjNsV6taB0p7Bc3RlU3N6MTcmei58Lx2vln1us=; b=jope8JXp9RN7b6JOs/+cOvaNR2i6qLQH8hgA2oNG2X7dIk4DJB1mOuSb7k4iIfQSoHqac9K/IWrZnZMIbhv5VYkoyFybPyNL/oqUfuQXYVt3Xu0KWFJqSMiXPJFsMoBLT6a1RUL9bPfMwZEaeGoS/GRCJPOpkoaTRjLLohRc5TLJOLlE91oKQFj2eBs/i+IKIlTtPe8xgQpV+JZQHJhRUZw0zDtrSYhDxmNOdVd7+FskZMVdAbdlgq84fX+cntgMal6iMRRnHwz70W+9nWCILOtMao8IauXL3yfmhH7trA8ZjXgB9pvnO+aRQ1/w/Vw5lXomDmobgMJKQ5K6+X2HXw== Received: from MW4PR03CA0280.namprd03.prod.outlook.com (2603:10b6:303:b5::15) by DM4PR12MB6256.namprd12.prod.outlook.com (2603:10b6:8:a3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17; Fri, 12 Jan 2024 07:51:29 +0000 Received: from CO1PEPF000044FA.namprd21.prod.outlook.com (2603:10b6:303:b5:cafe::b4) by MW4PR03CA0280.outlook.office365.com (2603:10b6:303:b5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21 via Frontend Transport; Fri, 12 Jan 2024 07:51:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000044FA.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.4 via Frontend Transport; Fri, 12 Jan 2024 07:51:29 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 11 Jan 2024 23:51:15 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 11 Jan 2024 23:51:13 -0800 From: Gavin Li To: , , , , , CC: , Subject: [V1 1/2] net/mlx5: discover IPv6 traffic class support in RDMA core Date: Fri, 12 Jan 2024 09:50:54 +0200 Message-ID: <20240112075055.1288263-2-gavinl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240112075055.1288263-1-gavinl@nvidia.com> References: <20240112075055.1288263-1-gavinl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044FA:EE_|DM4PR12MB6256:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cc726b9-edc0-4fe2-94e2-08dc13434950 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6oy4ci3wuzXkn4569IGzdPDBeU/Zcz7fkC9J8gYUg6k7yvF2wWY24J8FoXLXaCSaD9/p2abssJ/c7mFq3j2CBmB1GrCSE3tod3kyot2WeoKirtpiCULRiFLY7S3AX58dusxtOKd8vqDYk2Ign6yB27EZPavNJ66JFXcj/XPBRonC4ToqE2mIXeCKxB4tCbzuTYsgEtgBfu10ChwwC+jNpQSvB/L8vyZh4r3fiUw6igFB1BqnP2CNmryOBhOHRH//N6NwYOuHHi5cYBkNitnSN/rLMOQX5I3Z9uu5dX04j8lR8VQ2sOzw9N7o24WzMZgvPsWksiMKgobukhzNEO/sjAPVhdQPj0CUbkkxRh+lJih/f8Y+I5HzQGudGIIFsFOa93bmbp6LZ2d0etm2lUesUYWjFgLWbqOXyAQ2KY3KHBXJfGtBZPHyZuiKVVUk3ytmvzD4nZ7rz4zeVPYyFT/0LxfIfrCu9xkunpIZjR9I6sa0n/n7/UEqSlm1FhYCwqVRwVTT1NfDhp4HvM2/XhmAhsfv/vE96ZzUpdOugaMak+g2XECJZvGeK/K9Wvx+V2OEQFCJ3DkJ5+Hc8fH0quQpFm7hHU0dNg7kAFO1kymTZODJJhADRVv7JeMOntVtnQRq40mFoJT2lN1qcpVXElMK7+lvNIOYY9TvZNmqwt9Ju4l1YWnuj0DjuZvZU5GA5OHyVKrN+5j+Bz9aFHwWj0/GHzOy/uXWwejJPESAnTdQDLtafV3KQsz9RFOyzer8FGnu/HUE6Ra0fiXGIbrgx4C4GA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(136003)(396003)(39860400002)(376002)(230922051799003)(1800799012)(186009)(64100799003)(82310400011)(451199024)(40470700004)(46966006)(36840700001)(2616005)(16526019)(83380400001)(336012)(26005)(1076003)(426003)(110136005)(70206006)(107886003)(6666004)(36860700001)(6286002)(5660300002)(8676002)(478600001)(7696005)(2906002)(54906003)(4326008)(8936002)(6636002)(316002)(41300700001)(70586007)(7636003)(47076005)(82740400003)(86362001)(36756003)(356005)(40480700001)(40460700003)(55016003)(2101003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 07:51:29.1959 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cc726b9-edc0-4fe2-94e2-08dc13434950 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044FA.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6256 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Previously, IPv6 traffic class used the same ids of IPv4 DSCP and ECN by rdam core and firmware. New FW support new IPv6 traffic class id which is recommended to be used though the old way is still working. FW exposed a new cap bit to indicate the supporting of the new id while RDMA core does not have such mechanism. To fix the backward compatibility issue of combination of RDMA core and FW of different versions, a new function and a new flag were introduced to check if the new IPv6 traffic class id is supported by RDMA core. Signed-off-by: Gavin Li Acked-by: Suanming Mou --- drivers/net/mlx5/linux/mlx5_os.c | 4 +++ drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.c | 42 ++++++++++++++++++++++++++++++++ drivers/net/mlx5/mlx5_flow.h | 1 + 4 files changed, 48 insertions(+) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index ae82e1e5d8..5ae31c88f4 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1602,6 +1602,10 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, goto error; } rte_rwlock_init(&priv->ind_tbls_lock); + if (sh->config.dv_flow_en == 1 && + !priv->sh->ipv6_tc_fallback && + mlx5_flow_discover_ipv6_tc_support(eth_dev)) + priv->sh->ipv6_tc_fallback = 1; if (priv->sh->config.dv_flow_en == 2) { #ifdef HAVE_MLX5_HWS_SUPPORT if (priv->sh->config.dv_esw_en) { diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 263ebead7f..779805bcd8 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1444,6 +1444,7 @@ struct mlx5_dev_ctx_shared { uint32_t lag_rx_port_affinity_en:1; /* lag_rx_port_affinity is supported. */ uint32_t hws_max_log_bulk_sz:5; + uint32_t ipv6_tc_fallback:1; /* Log of minimal HWS counters created hard coded. */ uint32_t hws_max_nb_counters; /* Maximal number for HWS counters. */ uint32_t max_port; /* Maximal IB device port index. */ diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 85e8c77c81..90b72b7b0a 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -12476,3 +12476,45 @@ mlx5_flow_pick_transfer_proxy(struct rte_eth_dev *dev, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "unable to find a proxy port"); } + +/** + * Discover ipv6 traffic class id support in rdma core and firmware. + * + * @param dev + * Ethernet device. + * + * @return + * 0, rdma core is good to work with firmware. + * -EOPNOTSUPP, rdma core could not work with new ipv6 tc id. + */ +int +mlx5_flow_discover_ipv6_tc_support(struct rte_eth_dev *dev) +{ + struct rte_flow_action_set_dscp set_dscp; + struct rte_flow_attr attr; + struct rte_flow_action actions[2]; + struct rte_flow_item items[3]; + struct rte_flow_error error; + uint32_t flow_idx; + + memset(&attr, 0, sizeof(attr)); + memset(actions, 0, sizeof(actions)); + memset(items, 0, sizeof(items)); + attr.group = 1; + attr.egress = 1; + items[0].type = RTE_FLOW_ITEM_TYPE_ETH; + items[1].type = RTE_FLOW_ITEM_TYPE_IPV6; + items[2].type = RTE_FLOW_ITEM_TYPE_END; + /* Random value */ + set_dscp.dscp = 9; + actions[0].type = RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP; + actions[0].conf = &set_dscp; + actions[1].type = RTE_FLOW_ACTION_TYPE_END; + + flow_idx = flow_list_create(dev, MLX5_FLOW_TYPE_GEN, &attr, items, actions, true, &error); + if (!flow_idx) + return -EOPNOTSUPP; + + flow_list_destroy(dev, MLX5_FLOW_TYPE_GEN, flow_idx); + return 0; +} diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index 120609c595..33d4a28077 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -2638,6 +2638,7 @@ void mlx5_flow_destroy_sub_policy_with_rxq(struct rte_eth_dev *dev, struct mlx5_flow_meter_policy *mtr_policy); int mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev); int mlx5_flow_discover_dr_action_support(struct rte_eth_dev *dev); +int mlx5_flow_discover_ipv6_tc_support(struct rte_eth_dev *dev); int mlx5_action_handle_attach(struct rte_eth_dev *dev); int mlx5_action_handle_detach(struct rte_eth_dev *dev); int mlx5_action_handle_flush(struct rte_eth_dev *dev);