From patchwork Mon Jan 15 02:54:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 135864 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2A8C438C7; Mon, 15 Jan 2024 03:55:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F12C40649; Mon, 15 Jan 2024 03:54:50 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 43496402E4 for ; Mon, 15 Jan 2024 03:54:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ATen5dgdvXWDvL+sT9e6zK9CQtHeUUeWER/ModeYmD18yjQkCxp49ksVCMK6ctjEbbehU8oxztD45Y/NX9Ct59cImcr0uXIfgPUJ+gX1cjPTptxHO2UsmrL2eIFfBAX4KPurOkVyhNuNsiCxm3xr+kcJNVQsj5IqgEzECnKo3A0NmygfKvgk3DVa4g8dAeCSpK9wejdpLnrkwhlr4VE+ztWM+3P09bMEuj23i3POUVg+tfMgFqJSyxdBKMMyl23REcL6Fji/TMYwQVNcmSi4H+ZZe6DIw1+VlXi42kbRD330iRmFLjJlwZG71CrtICPU+tIpkwgmJN/flvlN52AL4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G9GnIchBegFOaTDe8+HZJrODsUVM8irxcvt7MF3t0Dc=; b=SaNzxjd2PSTXBv7ScqCxivf7B5FhQJTdHenFZ90Tw0mlNddUc+IPTxEiUy9on8M+ODMxOUm9OfhrKYGnrGLRvI2+ZupIU1+PScS8UKZ/RqzAIJBQO55ncL6XOx0DUCs1lT+KzbemR0Fv8SRtgz8PH3llOkn/7Icoz2BkxgayrFvxbCFADVgUZBpbSebK7UCehGc9aktHS9mr8mwkZG7ZicpRT6esKNa+HHOOFTun1roeNkFucjX8EsAr5zIzybIHi889n3IC5ihr1Hz4cIwnbynsQQDz+LKpggl6Styi/pbH6FcchlLBLwZirKAitQ5SwVRkncI4dHNFcsnx2Ftgmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G9GnIchBegFOaTDe8+HZJrODsUVM8irxcvt7MF3t0Dc=; b=t/aKiyyE9aOtq/ju2xkmEhXOW3vEAfL8wUWeyvdnWFHae2DVvB/TAa7KZM/sp2fNJHIXmhFibtyLM7V3SMdBb+FSW9T2P1vmP4sFbS6NuhK7lsQW+SVu+/m1hYKe/Y5CnTziIMK2D2Lp9H200mmntifLQVKD++iKoaBsEkqFseE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BL3PR13MB5242.namprd13.prod.outlook.com (2603:10b6:208:345::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Mon, 15 Jan 2024 02:54:47 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::8e02:f738:570a:f8aa]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::8e02:f738:570a:f8aa%7]) with mapi id 15.20.7181.026; Mon, 15 Jan 2024 02:54:47 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , Chaoyong He , Long Wu Subject: [PATCH 2/8] net/nfp: speed up the firmware loading process Date: Mon, 15 Jan 2024 10:54:13 +0800 Message-Id: <20240115025419.2447759-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240115025419.2447759-1-chaoyong.he@corigine.com> References: <20240115025419.2447759-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH0PR07CA0025.namprd07.prod.outlook.com (2603:10b6:510:5::30) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BL3PR13MB5242:EE_ X-MS-Office365-Filtering-Correlation-Id: af600b3a-438f-4ac6-7484-08dc157555aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y05/ndfejTBnx6VreClIpqaav7r9RMidGGbmxW9Jq63ef0Nm/PjwJSk9ekaw06MuySI8lAmuKfYwgY7g5Y2Wn168K1ACp9HYrYRDLyeej8V4m6VzzcrVG7mKu0G325j+X58wJVFVnpNchKpOLVmqZqT0X2c7I5nxbBrO686d33i9StlJYwkaXIcQkmBpmdl+ovWFe8qxb9bkHK1vzq47eu2ZrNCgdPWSU60AUiTlbJfvv8eFvadWiFkfg3dcDI9+bjUmvtl0bfCretMxngUKiYulb+iZFkN3fsVBgzoBOA3KflN9wcVH4b2wiW10hzrOFJK2aThs0gQyVIiQwz6F4LRP0yDf4/RrYC0jFvyWfGeJJeKxMI4oM7uCYwFfvbpRt6LD3K3VfKnnGNHC9164LZNYmkbcRLd6LRC5A3F6UF9obgtRKFPffM57ZcFjO8P+wYlQoLAmZusuuhHCveLf7vhOYF+37fH8+lEL8YI0f5pbjgbkbAgQ+7DyQ6eMaoOo2B8lzROfN+LneAews8AmKEK1CKa4d4Ei4UIVjm2aLE5CFOjaejrI3PFyQL0ThFct+VuGJTU+6LpFjOy+Nv37BUHnR7ylXPWXeJyXvUvQ7ICk4p9wtUI68oRvKPdwl1Q8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(136003)(396003)(346002)(376002)(366004)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(6512007)(2616005)(26005)(1076003)(107886003)(83380400001)(54906003)(6486002)(316002)(52116002)(8676002)(4326008)(66476007)(478600001)(6916009)(86362001)(6506007)(6666004)(66556008)(66946007)(38100700002)(44832011)(8936002)(38350700005)(41300700001)(5660300002)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iW4ADu0LH6fMaP/FYQkRxFYuwUIYRvs5dMU19HdS9KBdmCXzDUfob8tNZBHkzz7+Y823/ev8egHRDcV8XQRGnqg8m/2Nhgpf0tZ7mvG7EQItaSWxU97TSx5xLTO+gCe8wqB/J22ojjpHTkU+rN32x1C7KCNF6lju5WvQZxdRcR2Ue8EUAs6xJuJbvm1tURqiY3KArV5UYWMft4GjXo2XsWjc6bAfpu5rsq84LQip5pH70XlbHeUU+SbbrSKcBnpeLsjU2foCkDf2pkuR7pIeQHs+JDYWTtpaYtFdqwzcgJftaO3/xjcyay/E+qIw77xsDdfKQiZtIPJwwLCook4UQXpW53EW2yMne7j2h6ydORtEhbJQ+gfremEosLNxV/0FQ8B778mSuqdJWUCe68dE6YNKzrlSF0qduyN75gNy0WWslt86woLXHyBMnVDy+1RdN+CrddHCVNM0OVdYrEOV+6s4DqhO7VrR0K2Sh5O51YJjJYR7FajbCTSI/SoMlRujkCCG++ChEa/Zr1Bn8O1b7qCzJydD52YAVa+qDEABjBmaPlteD8A4uDETSiYPlP7o2CGQrqD7U00HQQjlj3v84tGkBQ5L9hONPV2MbUyiLOBlQ6lBqFPseseMTNDPxZdXufNyJIGgCY8YzlmMXOWoTPe9LJR3Zie/IE9bptFqEDbi0H0mTY4O926Yun1i5HZj5wIeqreuaoEOAUWC0c3SFk8bWXtISNNyq1PUHx/xSYoD5OzIxKYgv/3dqmzHNrZ5VwHVHFyttgV8O+OeZ3PSEao7VPyZ3j7jKV1RIsD5b4zuz4H9M/0cmb8GQJJtOzFh+AIzsgnsaZRvncU922nKP1QHLT+jf4QkqvDoHi2BfY2t678QxlhwHGEA0AEJCdCZTEzmHSfYS67xmKUjgxJ3+dHRUEMNaqlhR40l01tMIn7d3T84WDzP+xEdqGTMNhXTLXD2e64fhznu6kWsfLyRjtrdNnzL9VhcLyYV07nzUZGHk4hR9k3RPvp5gi4XZ5K22t0WhjZnHq3tAcq8bqRq9M8Mu9nFh9KBoWXvINfe0ZuqX60bqyHwIw8q8AEYsG+kDEb03CN+enlcdTaGvue6PwnFwHJ6ohvzDQThCadjrZPYdgfrjvOsA3oo2B5B0L8HGU20PpHmVZKe/56wd2zaepYNvoDXDjKUcwQb5jG2OEEbM20LQMRPQs0zbHsAtzqb9llEiMFQGmI1W5YqJInbrRLmJFjfps0ti74FrSV8HUJW/CP+hy2ikngCf2JhNMyseWy6lmZHLVsV88YbxL66irbTNHKtI0hYSqCvGs2hOwafZq9vwY84hmXM93/vhIMY2sYA5pjDzYItM0t2weqocKckz9iZeTMLrWzbhHhhZLuCQRE9No9hZOQ1FkuNszRA2V4POSj35peUEzaAOkgef6SZadmoAm3BmJntSs42cuHS8jjz2hX/yQcOpVjqwv2TAb8fgVvnyQOIUFIhn1pxsakIzF2crtvcUW+qlXJhsEA+iOKJmXo9RppYY/Q/GlAtaiVeIeFvHIrKCgUtV6Ms5KpqkPbPcIPY5l43I0doCx2SHkx12RkzkleNgMq/6FSbiGH4qsWv2wA1iT7cC2D3DA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: af600b3a-438f-4ac6-7484-08dc157555aa X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 02:54:47.5315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HWfdIv7Z6aHEt61oAwujKT4gxlzcGDYL+1mheXomrAC1FzzsuaPgFfr6jYZc2uwFreOFylPw6ToBVY4EHwr+pyeHq5l7WLQvrw4KBw83rOE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR13MB5242 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peng Zhang The previous design spent too much time checking whether the port was alive, now optimize this process and speed up the firmware loading process. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/nfp_ethdev.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 434d664573..e06e6b7f59 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -1065,24 +1065,29 @@ nfp_fw_loaded_check_alive(struct nfp_nsp *nsp, const struct nfp_dev_info *dev_info, struct nfp_multi_pf *multi_pf) { - int offset; - uint32_t i; - uint64_t beat; + uint8_t i; + uint64_t tmp_beat; uint32_t port_num; + uint64_t beat[dev_info->pf_num_per_unit]; + uint32_t offset[dev_info->pf_num_per_unit]; + + for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) { + offset[port_num] = NFP_BEAT_OFFSET(port_num); + beat[port_num] = nn_readq(multi_pf->beat_addr + offset[port_num]); + } /* * If the beats of any other port changed in 3s, * we should not reload the firmware. */ - for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) { - if (port_num == multi_pf->function_id) - continue; - - offset = NFP_BEAT_OFFSET(port_num); - beat = nn_readq(multi_pf->beat_addr + offset); - for (i = 0; i < 3; i++) { - sleep(1); - if (nn_readq(multi_pf->beat_addr + offset) != beat) + for (i = 0; i < 3; i++) { + sleep(1); + for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) { + if (port_num == multi_pf->function_id) + continue; + + tmp_beat = nn_readq(multi_pf->beat_addr + offset[port_num]); + if (tmp_beat != beat[port_num]) return 0; } }