From patchwork Wed Jan 31 19:53:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 136240 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F36D543A20; Wed, 31 Jan 2024 20:53:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C891B42D91; Wed, 31 Jan 2024 20:53:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C063641143 for ; Wed, 31 Jan 2024 20:53:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706730797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K9VLnU6gDl6X8pc+IgpHqQJ4KA+9QT5vUEdm3jEXK48=; b=aZcUk4IivztAT81+XAh+jBRu72W+KpaVE87Y6nAQNtPeDhqtmOc4DAyAuiwawUb2JoAk8E kzECHZ3LhhUB/LmpUF3T46hqONp+T8Z7nGsoUrCcdoWnJQCbEh68Avm7XyoilBNJACOs6u dnWj9Pa+kTFRqor4l3s8tL8rLEeNbqA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-EDWzEw0ZNz6ZTwmYBWrSNQ-1; Wed, 31 Jan 2024 14:53:15 -0500 X-MC-Unique: EDWzEw0ZNz6ZTwmYBWrSNQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C913185A782; Wed, 31 Jan 2024 19:53:15 +0000 (UTC) Received: from max-p1.redhat.com (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4D4F1C060AF; Wed, 31 Jan 2024 19:53:13 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbox@nvidia.com, david.marchand@redhat.com, bnemeth@redhat.com, echaudro@redhat.com Cc: Maxime Coquelin Subject: [PATCH v2 2/2] vhost: add new mbuf allocation failure statistic Date: Wed, 31 Jan 2024 20:53:09 +0100 Message-ID: <20240131195309.2808015-2-maxime.coquelin@redhat.com> In-Reply-To: <20240131195309.2808015-1-maxime.coquelin@redhat.com> References: <20240131195309.2808015-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch introduces a new, per virtqueue, mbuf allocation failure statistic. It can be useful to troubleshoot packets drops due to insufficient mempool size or memory leaks. Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --- lib/vhost/vhost.c | 1 + lib/vhost/vhost.h | 1 + lib/vhost/virtio_net.c | 17 +++++++++++++---- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 5912a42979..ac71d17784 100644 --- a/lib/vhost/vhost.c +++ b/lib/vhost/vhost.c @@ -55,6 +55,7 @@ static const struct vhost_vq_stats_name_off vhost_vq_stat_strings[] = { {"iotlb_misses", offsetof(struct vhost_virtqueue, stats.iotlb_misses)}, {"inflight_submitted", offsetof(struct vhost_virtqueue, stats.inflight_submitted)}, {"inflight_completed", offsetof(struct vhost_virtqueue, stats.inflight_completed)}, + {"mbuf_alloc_failed", offsetof(struct vhost_virtqueue, stats.mbuf_alloc_failed)}, }; #define VHOST_NB_VQ_STATS RTE_DIM(vhost_vq_stat_strings) diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index 16fe6d4ddb..82ea25b3e1 100644 --- a/lib/vhost/vhost.h +++ b/lib/vhost/vhost.h @@ -156,6 +156,7 @@ struct virtqueue_stats { uint64_t iotlb_misses; uint64_t inflight_submitted; uint64_t inflight_completed; + uint64_t mbuf_alloc_failed; uint64_t guest_notifications_suppressed; /* Counters below are atomic, and should be incremented as such. */ RTE_ATOMIC(uint64_t) guest_notifications; diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 9951842b9f..1359c5fb1f 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -2996,6 +2996,7 @@ desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq, if (mbuf_avail == 0) { cur = rte_pktmbuf_alloc(mbuf_pool); if (unlikely(cur == NULL)) { + vq->stats.mbuf_alloc_failed++; VHOST_DATA_LOG(dev->ifname, ERR, "failed to allocate memory for mbuf."); goto error; @@ -3123,8 +3124,10 @@ virtio_dev_tx_split(struct virtio_net *dev, struct vhost_virtqueue *vq, count = RTE_MIN(count, avail_entries); VHOST_DATA_LOG(dev->ifname, DEBUG, "about to dequeue %u buffers", count); - if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts, count)) + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts, count)) { + vq->stats.mbuf_alloc_failed += count; return 0; + } for (i = 0; i < count; i++) { struct buf_vector buf_vec[BUF_VECTOR_MAX]; @@ -3494,8 +3497,10 @@ virtio_dev_tx_packed(struct virtio_net *dev, { uint32_t pkt_idx = 0; - if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts, count)) + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts, count)) { + vq->stats.mbuf_alloc_failed += count; return 0; + } do { rte_prefetch0(&vq->desc_packed[vq->last_avail_idx]); @@ -3745,8 +3750,10 @@ virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue *vq, count = RTE_MIN(count, avail_entries); VHOST_DATA_LOG(dev->ifname, DEBUG, "about to dequeue %u buffers", count); - if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts_prealloc, count)) + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts_prealloc, count)) { + vq->stats.mbuf_alloc_failed += count; goto out; + } for (pkt_idx = 0; pkt_idx < count; pkt_idx++) { uint16_t head_idx = 0; @@ -4035,8 +4042,10 @@ virtio_dev_tx_async_packed(struct virtio_net *dev, struct vhost_virtqueue *vq, async_iter_reset(async); - if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts_prealloc, count)) + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts_prealloc, count)) { + vq->stats.mbuf_alloc_failed += count; goto out; + } do { struct rte_mbuf *pkt = pkts_prealloc[pkt_idx];