From patchwork Fri Feb 2 11:56:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 136317 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC3B743A4F; Fri, 2 Feb 2024 12:57:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E06B942E53; Fri, 2 Feb 2024 12:56:55 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2065.outbound.protection.outlook.com [40.107.220.65]) by mails.dpdk.org (Postfix) with ESMTP id 0F0A542E42 for ; Fri, 2 Feb 2024 12:56:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSWgQZYkY4pqDJxRYgWadHiqIAjtKprPro03PM7XLDA445ZNI5O21vsnBugI24V5leKzHMCbCBH2yndaejG3ndXqlggNAbDcN2no+hN312kPDvKWxf1Jx3OrEuFvhl+wIxSASv9FTJCiMD7GN84fE1E46J026CsodY2oIiQCCrXL90Bd9/Rb0XAIADXiQD9/q30kiKdR21cgC8YlmlZHVMl9atkxqSnzIIuwI0vFuC9z4FxsVaokaAwQORy7XAE31gjJdvOPUUSTJqf8RC5A+go6ftC7gHC+rlYHPH97mIyy6RGsutt4MiDz5xJ1rMpZjkOWacJFM7un++RtR3Bi2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HZykOJNh7JY1g2UVbAGeRnAKkwjVpBeFuwmlt21v/WA=; b=VQVOTchwjI2PW1wylEr171dtKfmvz+0hv7Js760/ePmKYc2DXGAD+yUClSvVP5MfHjgXJC7+Is5CogEo1I0NQ23E7E+fOSr3iES8LqwAS+6pD31+hNHHliXZtlxbUcopbmRCqvM+Tp1JIPh6K9OEfkdEro2iwHtxGuelIJ1c4TIeC34WZn4uRshkaUj+Rv++Eh7MrKQQTBFiplxcYY3PfT9/uHw/7FRN1sZB88IKZWkCXtb2Oy9/aGYe79DBX3ezHNU58V+K/5hrWgDKt0w+W/P8HC2Afxrkv5vwdC0dlxo7tiem6CnQ6ba9mneo9g83JMOjKAOdVWrUz5ScLieHxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HZykOJNh7JY1g2UVbAGeRnAKkwjVpBeFuwmlt21v/WA=; b=ubyBxUbtrNyTRcFXRRUgrlfqzHfv62NJ8SyvF1V29e1T7cSkIrvcoblYztt4VSfdgbU/5Qvdsp9+ON0rgyAQBG8wdiwT09gqVB7QjPwC3yzNZViO1DLZLidCLvQmYGAEsF3k2OxJ7Ug0uu5onGkF4OEKrFnhDbfAshameusf+JG3gYV+ScuiW2CCCppF6z2ftE5P+D7c/fMdenVTr6a5m1J5ZJ1u2BkwLBfsIiaU9VBPP8U1xcorWiOSEUVIlvUS3WMHuTX7K7LX+VHgHF7xhLauTUi64ovCPSqzMcaNxcRS05DcH4kaQKIfsoBpc6gPGXyi5/4l6MB7r05Edi4lkA== Received: from SA1P222CA0074.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::20) by PH0PR12MB5629.namprd12.prod.outlook.com (2603:10b6:510:141::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Fri, 2 Feb 2024 11:56:51 +0000 Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:2c1:cafe::8c) by SA1P222CA0074.outlook.office365.com (2603:10b6:806:2c1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.29 via Frontend Transport; Fri, 2 Feb 2024 11:56:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.19 via Frontend Transport; Fri, 2 Feb 2024 11:56:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 2 Feb 2024 03:56:34 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 2 Feb 2024 03:56:31 -0800 From: Gregory Etelson To: CC: , =?utf-8?b?wqA=?= , , , Dariusz Sosnowski , Viacheslav Ovsiienko , "Ori Kam" , Suanming Mou , Matan Azrad Subject: [PATCH 2/5] net/mlx5: add resize function to ipool Date: Fri, 2 Feb 2024 13:56:08 +0200 Message-ID: <20240202115611.288892-3-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240202115611.288892-1-getelson@nvidia.com> References: <20240202115611.288892-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|PH0PR12MB5629:EE_ X-MS-Office365-Filtering-Correlation-Id: 891f25e1-fbdf-4d06-1f1b-08dc23e60aeb X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CD/z/6RqQIyHNbDdEmKb9zjJux/zQkf9leApLsiIYvsfS3D+gq0EMtv6rEK86MEDFGF4QLvr9TVq3npGKB2/efczHpiYV9vWv+ygB6BgxnVu/HlWdPhDnT8qsz43YSwVDBSzu0LPXAskEMiFsUocnoHktL7T7hM981MYfSmPJ7LeE0sfrCA5LmlhQfZG+iHyMAOoXbXtw5vQRhxDeNyfTahb8DZxW0L+HCpqJHfM9SQkqsaUijapfkjnN1bqCb8pvc/fXXkEUziVGrAFsOcgl+rhwn3Iu5NBTTI0E0QhKhAzENrq4iHEp9mXERO/pHTIDckFBIzAb6csYpCIvuyuBso4QxepaYGvSZHd3mZZf0N13gibLzl6w1vwGEkyDfY4skBhLyo2veNvKZsJDKwdkr/GDheDfWEG0W1Pn+YKqXHNxhtsZOxk9FGYh6Q6TiKdH5FAHlr2u+07eRrKr+lfmFGIWqwKf2lgWHPEVGJKoNk2OQeAEkHs6k0U17CN/slTyih7qEoWcL+ifZ1G+EFY9RCBo2z6x0T+lUSZnPhYlVeB5dk2C5B5bwNJ5l33Nk6qnA6zdxzXNbtjI6my68BCOs1a3y8g/T8H3HTpX590bBtNOdrMD2pez112eJn37J3xIsHKBi2/rI91CTJL3geuctJScPi6/cN2U1Wx/wlBAai9TRz5KCaKKK39WPvAG4Zi X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(230922051799003)(82310400011)(186009)(451199024)(1800799012)(36840700001)(46966006)(55016003)(83380400001)(26005)(6286002)(36756003)(86362001)(16526019)(356005)(426003)(7696005)(36860700001)(107886003)(47076005)(336012)(6916009)(2616005)(1076003)(70586007)(54906003)(2906002)(5660300002)(4326008)(6666004)(7636003)(8676002)(316002)(70206006)(508600001)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:56:51.0992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 891f25e1-fbdf-4d06-1f1b-08dc23e60aeb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5629 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Maayan Kashani Before this patch, ipool size could be fixed by setting max_idx in mlx5_indexed_pool_config upon ipool creation. Or it can be auto resized to the maximum limit by setting max_idx to zero upon ipool creation and the saved value is the maximum index possible. This patch adds ipool_resize API that enables to update the value of max_idx in case it is not set to maximum, meaning not in auto resize mode. It enables the allocation of new trunk when using malloc/zmalloc up to the max_idx limit. Please notice the resize number of entries should be divisible by trunk_size. Signed-off-by: Maayan Kashani --- drivers/net/mlx5/mlx5_utils.c | 29 +++++++++++++++++++++++++++++ drivers/net/mlx5/mlx5_utils.h | 16 ++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index 4db738785f..e28db2ec43 100644 --- a/drivers/net/mlx5/mlx5_utils.c +++ b/drivers/net/mlx5/mlx5_utils.c @@ -809,6 +809,35 @@ mlx5_ipool_get_next(struct mlx5_indexed_pool *pool, uint32_t *pos) return NULL; } +int +mlx5_ipool_resize(struct mlx5_indexed_pool *pool, uint32_t num_entries) +{ + uint32_t cur_max_idx; + uint32_t max_index = mlx5_trunk_idx_offset_get(pool, TRUNK_MAX_IDX + 1); + + if (num_entries % pool->cfg.trunk_size) { + DRV_LOG(ERR, "num_entries param should be trunk_size(=%u) multiplication\n", + pool->cfg.trunk_size); + return -EINVAL; + } + + mlx5_ipool_lock(pool); + cur_max_idx = pool->cfg.max_idx + num_entries; + /* If the ipool max idx is above maximum or uint overflow occurred. */ + if (cur_max_idx > max_index || cur_max_idx < num_entries) { + DRV_LOG(ERR, "Ipool resize failed\n"); + DRV_LOG(ERR, "Adding %u entries to existing %u entries, will cross max limit(=%u)\n", + num_entries, cur_max_idx, max_index); + mlx5_ipool_unlock(pool); + return -EINVAL; + } + + /* Update maximum entries number. */ + pool->cfg.max_idx = cur_max_idx; + mlx5_ipool_unlock(pool); + return 0; +} + void mlx5_ipool_dump(struct mlx5_indexed_pool *pool) { diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h index 82e8298781..f3c0d76a6d 100644 --- a/drivers/net/mlx5/mlx5_utils.h +++ b/drivers/net/mlx5/mlx5_utils.h @@ -427,6 +427,22 @@ void mlx5_ipool_flush_cache(struct mlx5_indexed_pool *pool); */ void *mlx5_ipool_get_next(struct mlx5_indexed_pool *pool, uint32_t *pos); +/** + * This function resize the ipool. + * + * @param pool + * Pointer to the index memory pool handler. + * @param num_entries + * Number of entries to be added to the pool. + * This number should be divisible by trunk_size. + * + * @return + * - non-zero value on error. + * - 0 on success. + * + */ +int mlx5_ipool_resize(struct mlx5_indexed_pool *pool, uint32_t num_entries); + /** * This function allocates new empty Three-level table. *