From patchwork Tue Feb 13 17:22:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vignesh Purushotham Srinivas X-Patchwork-Id: 136650 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED4BF43B0D; Tue, 13 Feb 2024 18:22:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D96C242E23; Tue, 13 Feb 2024 18:22:59 +0100 (CET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2083.outbound.protection.outlook.com [40.107.105.83]) by mails.dpdk.org (Postfix) with ESMTP id 72BE242E17 for ; Tue, 13 Feb 2024 18:22:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MqBbuiVJ8P9Zd7++SDHsuvoM5OMKWbBFKyyxH8m64ziS8TKOtAai/229LDtvXhUmqrB4QoN0qcUoJj3SOx+k4XEQ/BuxusGwkRzq3yNWDpdSWTVwhFRuTdMDfp/86BasI2tAlsPwSaRNtSNPHtBxCw7GYSn56RyPDHpMEf7wsaGnDyFyQNI3QFZOU0agucl3k6j+rJTs2q0plbZxsTKkYYssFOJ7XOIYPQXwHMlzWnPGOuCLhyZMfhS0EzVpq2VyAfgMhHjpt7DYcFB6jCjk2+SovT+cKKDHCQeiWz516uGZP5M2LXwmOPhzERPxn/aic4Ow+/V1ILWYixhWdmg5HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/PneVlzOLnKR8D7nb+ikwSliKvOWZPaORzekO+f5Yvk=; b=CEI7gDGW2xp8MdmI2LuS9eHrovmnh19MmtxB0iQz54xUNKkhWrKF+AxIgOs8yie94rHlY+v+cnPdNjuBOGfFK9pT6XOOnMlpB1gNzPezN2MccXfZ3/r4Wj+y6kPggHez4jGPPC3MUKsNhZ/UqRf99wcaJHGryKOuBIHJvDM0RyiGB/h+8eD1NfiNT+7Arulo+RZagcu1taQoaKpFXPkHTJc9C1Ry3CE5bd6pEHnu5KGKwIQhsRHw34R29g+mMt8FAAsw+5++Z9KOLJqg5ICM2oGwySWWl1Iof7ZFEW7qqDrwtH+5qJ/5WSO3rd2JADSt0tWIfmrf8VOaH7h9NcYjfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=att.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/PneVlzOLnKR8D7nb+ikwSliKvOWZPaORzekO+f5Yvk=; b=Yp3XGD/3hm+sqeH2PjSNnT1Jd3s438Uxnd99oRbk+boByQJXgusLopPQRcjRbEIjtgX31GZlTY/v2pm7YBnk7ZlcIZprYe67Q1Uf6uGCATe0ALetotxjWEsotKRDPH2gVJw8RmxO15EiVLAizj2MckbK5K+eh6/NItYKzf7G9vbcj1MTb6ryjTh6zizhZ50k+Cbl2V/wCaGhSPTzZ2Flrr7ZVGGhQ46cdzf87RH9ianmPZLompYbq/D5yPtSI3GN0k7qWH81iqz278oLpGMqzefyJB2ltJgGAfVEaonPyvLNAutzULn8mR1gfyVxAwfPoVyBdFT+BakDdP4gLbI6IA== Received: from AS4P195CA0045.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:65a::18) by DB9PR07MB9930.eurprd07.prod.outlook.com (2603:10a6:10:4cb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39; Tue, 13 Feb 2024 17:22:57 +0000 Received: from AM3PEPF0000A792.eurprd04.prod.outlook.com (2603:10a6:20b:65a:cafe::b6) by AS4P195CA0045.outlook.office365.com (2603:10a6:20b:65a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39 via Frontend Transport; Tue, 13 Feb 2024 17:22:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AM3PEPF0000A792.mail.protection.outlook.com (10.167.16.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Tue, 13 Feb 2024 17:22:56 +0000 Received: from seroius18814.sero.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 13 Feb 2024 18:22:56 +0100 Received: from seroiuts03116.sero.gic.ericsson.se (seroiuts03116.sero.gic.ericsson.se [10.210.134.60]) by seroius18814.sero.gic.ericsson.se (Postfix) with ESMTP id E6CF9C000090; Tue, 13 Feb 2024 18:22:55 +0100 (CET) Received: by seroiuts03116.sero.gic.ericsson.se (Postfix, from userid 7401342) id B846661A731C; Tue, 13 Feb 2024 18:22:55 +0100 (CET) From: To: , CC: , Vignesh PS Subject: [RFC] net/bonding: add user callback for bond xmit policy Date: Tue, 13 Feb 2024 18:22:46 +0100 Message-ID: <20240213172246.1094308-1-vignesh.purushotham.srinivas@ericsson.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A792:EE_|DB9PR07MB9930:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a6fbb49-a99a-4cfb-11d2-08dc2cb86b8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NfXcKfGOEZG+kXzSOmFX/e917KTn6xFyCHMWBFugUUz+kR4MW1nXzb9XDCZaa9peoDs1A/5KWyjz7WAv8L+Nptx0A+4Jry8NHSbOFdeESD8o49HeHm7qZHjYYS+90GDOPCgOZ9BCTqULuZZY+ImB/Y5fT90PNC+PMoklQZIVbYbT1D8pcG02aAxiEdTZvgTzT7R6Tu236n2wraTGnkjdv8KrkOsICZvJnuEJ1C0dxZLdOZ/uJR6IDKHKbFnIgh1BxTO0OC4M7RXmx6n/rve+zWB58MMg07g399/NvKoMeOzf6J1ezYlhAmBG1ZhsP0oEfHD4yIYg7u1kHn6fwKc/grgEJwbdxpV7XEeJE4nEHRuavuUVYu2aMunVpJ6nylSVFyRnTKgvKS7/71IkYeuo4iNzCwRmLikPGaoRqIurV8tfh8jDS+pxWRinr5m2X49HAdq2arR+8rxs1qJmJlHZCGjIvVsLuNsKprgo2gkyaErl1yrq1OnX6EbgtLkoyilkgGVbGmIHnKD7iNo6gp19qvkiZv3TMd+0c+uCHHDSsj9PcUkR3Y8EU4r3Y9j5qFU1ZyRSgwo4wFAYlc2qZj0jq7j+2z1QboNmsmtDaQI6yUo= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(4636009)(136003)(39860400002)(396003)(376002)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(82310400011)(36840700001)(40470700004)(46966006)(103116003)(41300700001)(6266002)(83380400001)(26005)(336012)(1076003)(2876002)(2906002)(5660300002)(478600001)(316002)(110136005)(42186006)(70586007)(70206006)(54906003)(6666004)(356005)(7636003)(2616005)(82960400001)(107886003)(36756003)(8936002)(4326008)(8676002)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 17:22:56.9285 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a6fbb49-a99a-4cfb-11d2-08dc2cb86b8f X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A792.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB9930 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Vignesh PS Add support to bonding PMD to allow user callback function registration for TX transmit policy. Signed-off-by: Vignesh PS --- .mailmap | 1 + drivers/net/bonding/eth_bond_private.h | 6 ++---- drivers/net/bonding/rte_eth_bond.h | 17 +++++++++++++++++ drivers/net/bonding/rte_eth_bond_api.c | 15 +++++++++++++++ drivers/net/bonding/rte_eth_bond_args.c | 2 ++ drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- drivers/net/bonding/version.map | 1 + 7 files changed, 39 insertions(+), 5 deletions(-) diff --git a/.mailmap b/.mailmap index de339562f4..6c068d5af3 100644 --- a/.mailmap +++ b/.mailmap @@ -1476,6 +1476,7 @@ Viacheslav Ovsiienko Victor Kaplansky Victor Raj Vidya Sagar Velumuri +Vignesh PS Vignesh Sridhar Vijayakumar Muthuvel Manickam Vijaya Mohan Guvva diff --git a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h index e688894210..4141b6e09f 100644 --- a/drivers/net/bonding/eth_bond_private.h +++ b/drivers/net/bonding/eth_bond_private.h @@ -32,6 +32,7 @@ #define PMD_BOND_XMIT_POLICY_LAYER2_KVARG ("l2") #define PMD_BOND_XMIT_POLICY_LAYER23_KVARG ("l23") #define PMD_BOND_XMIT_POLICY_LAYER34_KVARG ("l34") +#define PMD_BOND_XMIT_POLICY_USER_KVARG ("user") extern int bond_logtype; @@ -101,9 +102,6 @@ struct rte_flow { uint8_t rule_data[]; }; -typedef void (*burst_xmit_hash_t)(struct rte_mbuf **buf, uint16_t nb_pkts, - uint16_t member_count, uint16_t *members); - /** Link Bonding PMD device private configuration Structure */ struct bond_dev_private { uint16_t port_id; /**< Port Id of Bonding Port */ @@ -118,7 +116,7 @@ struct bond_dev_private { /**< Flag for whether primary port is user defined or not */ uint8_t balance_xmit_policy; - /**< Transmit policy - l2 / l23 / l34 for operation in balance mode */ + /**< Transmit policy - l2 / l23 / l34 / user for operation in balance mode */ burst_xmit_hash_t burst_xmit_hash; /**< Transmit policy hash function */ diff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h index f10165f2c6..66bc41097a 100644 --- a/drivers/net/bonding/rte_eth_bond.h +++ b/drivers/net/bonding/rte_eth_bond.h @@ -91,6 +91,11 @@ extern "C" { /**< Layer 2+3 (Ethernet MAC + IP Addresses) transmit load balancing */ #define BALANCE_XMIT_POLICY_LAYER34 (2) /**< Layer 3+4 (IP Addresses + UDP Ports) transmit load balancing */ +#define BALANCE_XMIT_POLICY_USER (3) +/**< User callback function to transmit load balancing */ + +typedef void (*burst_xmit_hash_t)(struct rte_mbuf **buf, uint16_t nb_pkts, + uint16_t slave_count, uint16_t *slaves); /** * Create a bonding rte_eth_dev device @@ -351,6 +356,18 @@ rte_eth_bond_link_up_prop_delay_set(uint16_t bonding_port_id, int rte_eth_bond_link_up_prop_delay_get(uint16_t bonding_port_id); +/** + * Register transmit callback function for bonded device to use when it is operating in + * balance mode. The callback is ignored in other modes of operation. + * + * @param cb_fn User defined callback function to determine the xmit slave + * + * @return + * 0 on success, negative value otherwise. + */ +__rte_experimental +int +rte_eth_bond_xmit_policy_cb_register(burst_xmit_hash_t cb_fn); #ifdef __cplusplus } diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 99e496556a..b53038eeda 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -15,6 +15,8 @@ #include "eth_bond_private.h" #include "eth_bond_8023ad_private.h" +static burst_xmit_hash_t burst_xmit_user_hash; + int check_for_bonding_ethdev(const struct rte_eth_dev *eth_dev) { @@ -972,6 +974,13 @@ rte_eth_bond_mac_address_reset(uint16_t bonding_port_id) return 0; } +int +rte_eth_bond_xmit_policy_cb_register(burst_xmit_hash_t cb_fn) +{ + burst_xmit_user_hash = cb_fn; + return 0; +} + int rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy) { @@ -995,6 +1004,12 @@ rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy) internals->balance_xmit_policy = policy; internals->burst_xmit_hash = burst_xmit_l34_hash; break; + case BALANCE_XMIT_POLICY_USER: + if (burst_xmit_user_hash == NULL) + return -1; + internals->balance_xmit_policy = policy; + internals->burst_xmit_hash = burst_xmit_user_hash; + break; default: return -1; diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index bdec5d61d4..eaa313bf73 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -261,6 +261,8 @@ bond_ethdev_parse_balance_xmit_policy_kvarg(const char *key __rte_unused, *xmit_policy = BALANCE_XMIT_POLICY_LAYER23; else if (strcmp(PMD_BOND_XMIT_POLICY_LAYER34_KVARG, value) == 0) *xmit_policy = BALANCE_XMIT_POLICY_LAYER34; + else if (strcmp(PMD_BOND_XMIT_POLICY_USER_KVARG, value) == 0) + *xmit_policy = BALANCE_XMIT_POLICY_USER; else return -1; diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index c40d18d128..92b0126a6d 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -4251,7 +4251,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_bonding, "member= " "primary= " "mode=[0-6] " - "xmit_policy=[l2 | l23 | l34] " + "xmit_policy=[l2 | l23 | l34 | user] " "agg_mode=[count | stable | bandwidth] " "socket_id= " "mac= " diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map index 09ee21c55f..6e82d2c72f 100644 --- a/drivers/net/bonding/version.map +++ b/drivers/net/bonding/version.map @@ -35,4 +35,5 @@ EXPERIMENTAL { rte_eth_bond_member_add; rte_eth_bond_member_remove; rte_eth_bond_members_get; + rte_eth_bond_xmit_policy_cb_register; };