From patchwork Thu Feb 22 19:47:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 137051 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8C2A43B84; Thu, 22 Feb 2024 20:48:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73B0F4027F; Thu, 22 Feb 2024 20:48:17 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 27AF2410F6 for ; Thu, 22 Feb 2024 20:48:15 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6e4d48a5823so21524b3a.1 for ; Thu, 22 Feb 2024 11:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1708631294; x=1709236094; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=AhI9EYPFOCCdLp0En/AegRaY11BVxU1mtw1cMp9myZw=; b=ghzPcmq8g3ZuoIUIYF59pvogwIxu9p6Jsm6hK5NvHtx0ZkVpbcJdp0QLNLlFnPbS/E PRfRp0EGIrPKgaDP7VA3K49L0tMH8KYRG4mjf/L4h6tp6FqlpH1p7R5X9vcAi1X/mZXL Iy74QyatCwcSvfzWLrcIoKuiGE/oiP1lDnRno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708631294; x=1709236094; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AhI9EYPFOCCdLp0En/AegRaY11BVxU1mtw1cMp9myZw=; b=Tv/N2tLZ+WEtnbpW5Tfm5oj/h1i7MT5jXE1hxar5qVVT9HM88HMnpIcNmBHzvR+PX3 Iw3YQ67i6KPWFLZ6a/gywjRM7ysomvbdORQ/7AC3dwgDC1rlXurlP7HdAkuclcmqZRoB TIVws3Vs1cArsm7ptsSvWHNgwr0WH77cQpFKpkUOKSO+TrW+/m5kEcQWOygkwrpp64WT MOoJKOwWiqfaDBKzemFYkcdGftrRvAKCIb/aWevNjOG61tmPjlNMrB0MvdjWTtUYwaMt c3/SZIT3fHpGroiVFunbYw5nJUHbUrqS/sLUnxAaPex+R+JGBrubwGTkBtDq3KmaoqpW Zaxw== X-Gm-Message-State: AOJu0YwLfa7uSXcMeC7dzHaV6gtOoneLrKuIuwkRBhpg+OfMBDpmURN6 Rt1gC8GpIfs9z57EII1XWKIb9/AiuCy02NuFcyYQEnYuO+VeE/9Qsn22dcEmuioNlWjpe6vKhL1 yFx7DjJTTfApQni/tlrXQ30f3n1d9j8mfN1VD4TPAptdlvG5qNaPtkPBjpMTBI5ilTuFkyk4mxV 7Z8cnIUNWZ83Ux/eSYPP+h8egsDvpM X-Google-Smtp-Source: AGHT+IF+55nzLQa4C/8y3jOXAFZGvoMUht2Je+NMjEdE3GBS6yih5sm/DG3yacrn2UziA1coE1DE9g== X-Received: by 2002:a05:6a00:139e:b0:6e4:6187:a7d8 with SMTP id t30-20020a056a00139e00b006e46187a7d8mr16250859pfg.30.1708631293891; Thu, 22 Feb 2024 11:48:13 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id gu12-20020a056a004e4c00b006e025e1fa61sm9538452pfb.14.2024.02.22.11.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 11:48:13 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@amd.com, thomas@monjalon.net Subject: [PATCH v2 06/10] net/bnxt: handle UDP GSO Tx Date: Thu, 22 Feb 2024 11:47:56 -0800 Message-Id: <20240222194800.80648-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20240222194800.80648-1-ajit.khaparde@broadcom.com> References: <20240221212044.27209-1-ajit.khaparde@broadcom.com> <20240222194800.80648-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The UDP GSO capability is not being detected and reported correctly. This is causing UDP GSO to not happen in some cases. This patch fixes the issue. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 ++- drivers/net/bnxt/bnxt_txr.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 7923d4cbd2..7f49b4b40e 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1141,6 +1141,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) bp->max_ring_grps = rte_le_to_cpu_32(resp->max_hw_ring_grps); flags = rte_le_to_cpu_32(resp->flags); + flags_ext2 = rte_le_to_cpu_32(resp->flags_ext2); + if (BNXT_PF(bp)) { bp->pf->port_id = resp->port_id; bp->pf->first_vf_id = rte_le_to_cpu_16(resp->first_vf_id); @@ -1225,7 +1227,6 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) PMD_DRV_LOG(DEBUG, "Tunnel parsing capability is disabled, flags : %#x\n", bp->tunnel_disable_flag); - flags_ext2 = rte_le_to_cpu_32(resp->flags_ext2); if (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_RX_ALL_PKTS_TIMESTAMPS_SUPPORTED) bp->fw_cap |= BNXT_FW_CAP_RX_ALL_PKT_TS; if (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_UDP_GSO_SUPPORTED) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 7cbb2104a0..83c003d258 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -116,7 +116,8 @@ bnxt_xmit_need_long_bd(struct rte_mbuf *tx_pkt, struct bnxt_tx_queue *txq) RTE_MBUF_F_TX_VLAN | RTE_MBUF_F_TX_OUTER_IP_CKSUM | RTE_MBUF_F_TX_TUNNEL_GRE | RTE_MBUF_F_TX_TUNNEL_VXLAN | RTE_MBUF_F_TX_TUNNEL_GENEVE | RTE_MBUF_F_TX_IEEE1588_TMST | - RTE_MBUF_F_TX_QINQ | RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE) || + RTE_MBUF_F_TX_QINQ | RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE | + RTE_MBUF_F_TX_UDP_SEG) || (BNXT_TRUFLOW_EN(txq->bp) && (txq->bp->tx_cfa_action || txq->vfr_tx_cfa_action))) return true;