diff mbox series

[13/21] test/crypto: update verification of header

Message ID	20240305072213.283205-14-asasidharan@marvell.com (mailing list archive)
State	Superseded, archived
Delegated to:	akhil goyal
Headers	From: Aakash Sasidharan <asasidharan@marvell.com> To: Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com> CC: <jerinj@marvell.com>, <anoobj@marvell.com>, <vvelumuri@marvell.com>, <asasidharan@marvell.com>, <dev@dpdk.org> Subject: [PATCH 13/21] test/crypto: update verification of header Date: Tue, 5 Mar 2024 12:52:05 +0530 Message-ID: <20240305072213.283205-14-asasidharan@marvell.com> In-Reply-To: <20240305072213.283205-1-asasidharan@marvell.com> References: <20240305072213.283205-1-asasidharan@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Improvements and new test cases \| [00/21] Improvements and new test cases [01/21] test/security: enable AES-GCM in combined mode TLS [02/21] test/security: add TLS 1.2 data walkthrough test [03/21] test/security: add DTLS 1.2 data walkthrough test [04/21] test/security: add TLS SG data walkthrough test [05/21] test/security: unit test for TLS packet corruption [06/21] test/security: unit test for custom content verification [07/21] test/cryptodev: allow zero packet length buffers [08/21] test/security: unit test to verify zero TLS records [09/21] test/security: add unit tests for DTLS-1.2 [10/21] test/security: add TLS/DTLS 1.2 AES-256-SHA384 vectors [11/21] test/security: add DTLS 1.2 anti-replay tests [12/21] test/security: add more DTLS anti-replay window sz [13/21] test/crypto: update verification of header [14/21] test/crypto: add TLS 1.3 vectors [15/21] test/crypto: update framework to verify tls-1.3 [16/21] test/crypto: test to verify hdr corruption in TLS [17/21] test/crypto: test to verify custom content type in TLS [18/21] test/crypto: test to verify zero len record in TLS [19/21] test/crypto: unit tests to verify padding in TLS [20/21] test/crypto: unit tests for padding in DTLS-1.2 [21/21] test/security: add out of place sgl test case for TLS 1.2

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Aakash Sasidharan March 5, 2024, 7:22 a.m. UTC

  From: Vidya Sagar Velumuri <vvelumuri@marvell.com>

In TLS 1.3, the version in the header would be TLS 1.2 and the content
type would be APP irrespective of the type of the payload.

Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
---
 app/test/test_cryptodev_security_tls_record.c | 20 +++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff mbox series

Patch

diff --git a/app/test/test_cryptodev_security_tls_record.c b/app/test/test_cryptodev_security_tls_record.c
index 907e043ddd..498c4923e0 100644
--- a/app/test/test_cryptodev_security_tls_record.c
+++ b/app/test/test_cryptodev_security_tls_record.c
@@ -275,9 +275,9 @@  tls_record_hdr_verify(const struct tls_record_test_data *td, const uint8_t *outp
 		hdr_len = sizeof(struct rte_tls_hdr);
 	} else if (td->tls_record_xform.ver == RTE_SECURITY_VERSION_TLS_1_3) {
 		const struct rte_tls_hdr *hdr = (const struct rte_tls_hdr *)output_text;
-		if (rte_be_to_cpu_16(hdr->version) != RTE_TLS_VERSION_1_3) {
+		if (rte_be_to_cpu_16(hdr->version) != RTE_TLS_VERSION_1_2) {
 			printf("Incorrect header version [expected - %4x, received - %4x]\n",
-			       RTE_TLS_VERSION_1_3, rte_be_to_cpu_16(hdr->version));
+			       RTE_TLS_VERSION_1_2, rte_be_to_cpu_16(hdr->version));
 			return TEST_FAILED;
 		}
 		content_type = hdr->type;
@@ -297,10 +297,18 @@  tls_record_hdr_verify(const struct tls_record_test_data *td, const uint8_t *outp
 		return TEST_FAILED;
 	}
 
-	if (content_type != td->app_type) {
-		printf("Incorrect content type in packet [expected - %d, received - %d]\n",
-		       td->app_type, content_type);
-		return TEST_FAILED;
+	if (td->tls_record_xform.ver == RTE_SECURITY_VERSION_TLS_1_3) {
+		if (content_type != RTE_TLS_TYPE_APPDATA) {
+			printf("Incorrect content type in packet [expected - %d, received - %d]\n",
+			       td->app_type, content_type);
+			return TEST_FAILED;
+		}
+	} else {
+		if (content_type != td->app_type) {
+			printf("Incorrect content type in packet [expected - %d, received - %d]\n",
+			       td->app_type, content_type);
+			return TEST_FAILED;
+		}
 	}
 
 	if (length != td->output_text.len - hdr_len) {