diff mbox series

net/mlx5: prevent ioctl failure log from flood

Message ID 20240307061345.310225-1-bingz@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: prevent ioctl failure log from flood |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Bing Zhao March 7, 2024, 6:13 a.m. UTC 
  From: Eli Britstein <elibr@nvidia.com>

The following log is printed in WARNING severity:

mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:
    Operation not supported

Reduce the severity to DEBUG to prevent this log from flooding
when there are hundreds of ports probed without supporting this
flow ctrl query.

Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions")
Cc: ophirmu@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Eli Britstein <elibr@nvidia.com>
---
 drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Slava Ovsiienko March 7, 2024, 12:46 p.m. UTC | #1 
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Thursday, March 7, 2024 8:14 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan
> Azrad <matan@nvidia.com>; Eli Britstein <elibr@nvidia.com>; Ophir Munk
> <ophirmu@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: prevent ioctl failure log from flood
> 
> From: Eli Britstein <elibr@nvidia.com>
> 
> The following log is printed in WARNING severity:
> 
> mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:
>     Operation not supported
> 
> Reduce the severity to DEBUG to prevent this log from flooding when there are
> hundreds of ports probed without supporting this flow ctrl query.
> 
> Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions")
> Cc: ophirmu@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Raslan Darawsheh March 13, 2024, 7:47 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Thursday, March 7, 2024 8:14 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; Eli Britstein <elibr@nvidia.com>; Ophir
> Munk <ophirmu@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: prevent ioctl failure log from flood
> 
> From: Eli Britstein <elibr@nvidia.com>
> 
> The following log is printed in WARNING severity:
> 
> mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:
>     Operation not supported
> 
> Reduce the severity to DEBUG to prevent this log from flooding when there
> are hundreds of ports probed without supporting this flow ctrl query.
> 
> Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions")
> Cc: ophirmu@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index eb47c284ec..b713354b09 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -671,7 +671,7 @@  mlx5_dev_get_flow_ctrl(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 	ifr.ifr_data = (void *)&ethpause;
 	ret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);
 	if (ret) {
-		DRV_LOG(WARNING,
+		DRV_LOG(DEBUG,
 			"port %u ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:"
 			" %s",
 			dev->data->port_id, strerror(rte_errno));