From patchwork Fri Mar 8 10:50:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138122 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC7AB43C27; Fri, 8 Mar 2024 11:50:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6356D42FAD; Fri, 8 Mar 2024 11:50:29 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2097.outbound.protection.outlook.com [40.107.212.97]) by mails.dpdk.org (Postfix) with ESMTP id A001E42F8D; Fri, 8 Mar 2024 11:50:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6ItVa6ZFC1G+X+B25ls0og/nvVRGN/yZRBWmVYWi1LCUwj3IxQmhUSSyno9I4TWBs5UoY6l7KfI0cCkL9Gm/Oa2v1L4Yt+O8I3YFCfZTHKEQodiWCuUDGui/TaduC4piC76aEGJnrLBIEt96I9lJunHKeUDdfRZ5shlgMUM6OmRI9cO2vP/uAwSq8L6kHyMZZYWW+ql2VNN3X+69xDC7V/lRdhT3DesmGBqcFayv0G62flWyyAqyN7S3SsteGpKcmMMltgYx9GrzyNq7IpLf2RauzekhuLpHPwqufLkYN5Je5GJ9bIkOv1EaLtS5KNk3gm9iz6d3jWBR59iFFyESQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HLmetmvuqTRMOr5/bnU58T1sjFShaY+lQ5Lt/Vity0o=; b=SwQBlX5QjrmBwueJUH0etjIGWoRMaduiG2nL028SEr0rBDSqngNepC7LpT+4VGszJB/61uIJqOyi8jehTQ52SWo94wt2bY59qvSSWbX1P5XbLhAonIO7mJm0WQp6VoYskgEue+dp1CHxD74L/srI8g2+zMLz1hr861n9XPugLl4Kv2yFBfctrY+eVK20w8H6WN+MczEbN2CcVH95pcvq4t4Dcwxy62PnX+nLJ8Nv+dsZ/7xV8KA3XSbuZXs24falLHzAejNcCPIqirH63nKPSxEZYDNOQrwUjl1RHifdQ7O9Kml3YuZnW9x9Y/IzAfmnIneKeBET+68esH6j22YIRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HLmetmvuqTRMOr5/bnU58T1sjFShaY+lQ5Lt/Vity0o=; b=TI27ib3DOI+j7OhrlYcuSmXR5MX3RqcxISbR/P/9jPN/5XcukHUENm4qzjSOjFFRC5siVQOn2DRWibUvU6IBU89x2H81Gsnyyv/JDyvaxOmNa3aFCw9431oYii+Jl1+Ob7/xpV/Y2HW9k9XRxXWHFuqpU1U31VzeMEpRe+cuCTI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DS7PR13MB4703.namprd13.prod.outlook.com (2603:10b6:5:3a0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Fri, 8 Mar 2024 10:50:24 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7339.035; Fri, 8 Mar 2024 10:50:24 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , stable@dpdk.org, Chaoyong He Subject: [PATCH] net/nfp: fix skip reload firmware issue Date: Fri, 8 Mar 2024 18:50:04 +0800 Message-Id: <20240308105004.2146837-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: BYAPR11CA0104.namprd11.prod.outlook.com (2603:10b6:a03:f4::45) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|DS7PR13MB4703:EE_ X-MS-Office365-Filtering-Correlation-Id: 94eabf60-8454-4096-1715-08dc3f5d8f17 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W7jLHtRlamk4gxeC9XtOZvef2cYRdfKU2J4aN+6YzmTBTOOqEafyTwf1ANjQccq6jYlPo5+5A0edXm0d34MQa1QbG4N6bMF6EICHEZrjmmk81Zskh1nQkF8BWyz2c8grPk2DAzbwwZL9kM2R2uy/PKVHEznfz0WMyKKLiNFw841nP5eX//3PIXzBTFqrvDWjVKLCCwWpvdGLbq64ZooSOfhN9ymHd574SClJ92Ya/UpEUw8kgm7bNpcKP+0ZunhT6P0mgm9WUM/tOs2gAUbjwRf8V+/3wd89n5/HSt5J+1BwBgnlKn3Lp9PLAx4dQanjciq3uaCIZL6NZ0j/M6L8yBdWou9juCTU/c02ogD6UKWhQnQ/qaObi6kKNQ4M2HHSGsfuEoW8bqFZNHsBDjQrKekoVu4eLgfp9pw82eA+3nH2q+V8NibBLoHNOL9sQoXpOOwMeh5BLuNzZKcH/yNrgtJeDtuOIfUp4+NvsRtg+9bYORums9jC/jeTBE2jxacGD+oE7L/MmpV4eEZvUXWjdZ1dxH+GkKy/kD1WgP2HwloV8XJ3aRqWsCbCrqowbB4kGnTU/65Bh+UCkCyVArk0VuRqJ6fs4VNmR8EAKrGKul/xy5Q+CnyD8vVKuH6d5iLljlKMkS3RP0N8fmi9aW6em3BH+0oBukiWR50GYJceRZ3SmlMHohHBrgYATfk0JxFLyZc5hRSeqVYKDx7ALZH9fw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(52116005)(1800799015)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oqJB5vScKh8jRxn33E2GzArpOlafFOllwdxu18wJVuE+3xtfkVrpcN2y7qPPzwPW9RrP1ADWEwCRYszjVTTI53JNTlDqGkw0z5O+iPmdyT6yD36IlLyVHbyK4SX1L230N19+geejHTndkV4ZH6m7BCjPPM20Eg4aiHBh0gI+iAEShAEd8C0KBs5eI6hRV3ytAh/uTFFsPPxGKz5YTWdeozb4AAHLA+46uzRNZpz9HUs7/1IvWLnazI3PgHOnAeJAE2EFewPskDQVHBQRRtLxD6W7YI46KcNuCLQJWNZt406kekezistg+hVdFsQjJcQxIYlgXZVfSGwrQTE2OifAAj5NiLMP6L4Zc7b3nZUoIo1G+NNa0LU3LhwDWuZ8/pLxsYowMoZ2q4FHPc2soTkHwDZywqTRdOKJyE6Fq6Qp21lnkE765fRpfHk6Q8JZ8Wgdi85Du9TrbK1hcn7CROBdtqHmWYn+VN898avWEckgKHxLMveee6xty/pliYfGccL/v564lUehUdNyfI5LPyIkI+nmIhn3OGN41x9q2qi16FiXdisT2wGOgHQXcRLMTi1YRHXM7RM6oIX2x6Wx3tt+GPXKA2xwPAcv/gmvm2fiAEFBpDI36kAE0aZkYlYvhYgQ7XGiat5dcSSAOFc7jTyXfl5BF1OeJLMkvHip9hW3q4alL+uYDYg9ShN3wTujbtbTBEgfVkh+RLT/iqrgljYr0Iq807/w1/9CzPeIUccvAUCYZCw+QVCm8kHzzY6OuRQlTrARVQ4mRkVdDqBt91mVtJniie6RF8vYwoPr/TBArvrQLkeIBYU9S0C+rgjkHPhi3FnR2/gclKWegI0X0d6049JP1dkhawjqCrtEUwqYtDpjtZl/u6236NkCUUrqwx8e3ly9NoFzAff6qYNmmHAdzetjdNLtpltHVeXOYuZSdG1Gt9uEBqtPvZ4mwzRcxQRoYfP/kEe4bPtETvxcrt1j2QzZvmCQSSCpPgLh0+ghArpZD8XcPbKqJEs2o4vttUtWEbsifninaSy0o18gcnqFyC9LGDc37KYXDw86DCyoLrEQU8W52AnUOqQ+oD8FPal2iJoUM9F6EYf4sslzBb+qMld1Cx3UAQsj2xh5M5Fsfxq+t6iRaFFCKLfHm2d271FOWji+WyuAuFrSDzI7SWLCdrMBbkh/OWRpfDDaKiUfeyvR5YRtc/xfnTUwi9qqKrcrO8nB7T8nYwCfms5OxfcXcCTqW6EpCx6Te2nIcrGHh+cI+6bx4OpLbPh7aY/beaTDoWsAXTOBtuNyaypZhR4Q9UDHPXK+1uax7Eion56h/aIecImNg4/43dk5KChMeIE+0GKVyYy5O8o2obod3NYS1t72WuKTdoA9lzJof1APGb7NoJbTuEqh1UbCCvbFCeNVC1lTOfJATbHL0XvLJ6jEFgtxrMJBoqtq4FmUHdXUngym9x30YrEo8S74oEEuwf91SDFCIdHfSRqN0g21MhOoLpUGhH3h23sEKq5IdPo5+S/NVxZrCZxOeMkx8z1oqNKf0Z57Bx8IOAESjg9vqR3V/btFuvmoHzgcyoqmtkC28sVvu0eysP5Jn5WoUSCrMlHw9BJZMQaJKa1BWwPFGKOdYg== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94eabf60-8454-4096-1715-08dc3f5d8f17 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 10:50:24.7787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V7AYXRldFwD/IPx4/v/QViTbUYLP1QaQSuu9iNy/arM+QJgW/8B6l3q/RA683hbX4/5zxEuah021jWH7kyPzWgveBktreBSX32AggxeyC14= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4703 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peng Zhang When the beat value of all ports are 0, which represent all ports are unused. But the current port starts beat before the check process, so it needs to sleep 1 second waiting the beat value change and to ignore the current port. Fixes: 8b9a83ea2af2 ("net/nfp: enlarge range of skipping loading firmware") Cc: stable@dpdk.org Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 1e713ee111..31c54a595c 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -1193,7 +1193,13 @@ nfp_fw_skip_load(const struct nfp_dev_info *dev_info, uint32_t offset[dev_info->pf_num_per_unit]; uint8_t abnormal = dev_info->pf_num_per_unit; + sleep(1); for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) { + if (port_num == multi_pf->function_id) { + abnormal--; + continue; + } + offset[port_num] = NFP_BEAT_OFFSET(port_num); beat[port_num] = nn_readq(multi_pf->beat_addr + offset[port_num]); if (beat[port_num] == 0)