From patchwork Mon Mar 11 11:51:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Herbelot X-Patchwork-Id: 138150 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CBDD43C87; Mon, 11 Mar 2024 12:51:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B32274026B; Mon, 11 Mar 2024 12:51:42 +0100 (CET) Received: from mail-ej1-f99.google.com (mail-ej1-f99.google.com [209.85.218.99]) by mails.dpdk.org (Postfix) with ESMTP id 3E4C140156 for ; Mon, 11 Mar 2024 12:51:41 +0100 (CET) Received: by mail-ej1-f99.google.com with SMTP id a640c23a62f3a-a449c5411e1so548525066b.1 for ; Mon, 11 Mar 2024 04:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1710157901; x=1710762701; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SE0GgDiEE0HZQEdPTUkuNKimVttArtx26pE81mrjTzY=; b=jHqxayUJjM7mN8YMsX1moWL3TYt2VZKH6dKakA19eEIizQNPPoR2bb6RNt2tfJAnSc a4NWTdpYx3GGnMMJ5ul7avtEEASLVjO08zRsFHxAk9PUoCn17jnpbt9/z81VgMx6q3ij Ca0GBYj9bojWOxxnf7o/Tc1vUdpN8IuCGnHKIQWYImQbt6RnKUr1YnE+QCaZHOy5HTS7 5ys7UWDTwowNBkwvdQDM+0bt9u6V27L2M3e3hZgCbfSQJ1ZI8OwsGeIkuMoFiFQDEvwZ TEHp906L+5rMcPl/2Im6IRnUjFxxtUAOrba8gF/dCBiEU8FPQy07Xx8V8rjAHrBB/QUM kDVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710157901; x=1710762701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SE0GgDiEE0HZQEdPTUkuNKimVttArtx26pE81mrjTzY=; b=i1BS+4jDz7+Xj2Oan2xXJ6o48tEA3rEJutmxaG+2l/hjxwRRfPsR+ejnODG97yQ1c9 51M5Jkq3ojtBfHj9Bn20+F4dyUEP6QqatomrCrbPetUOXPi/ecbwEbkd2u3QzuDAJPsv YFqbGuP3UFSm+KWM5K/XD2NPQKyCMuif6fSNnyZNhx0TMqhJheT1KWSOeqSmJ/3+DHFX qPbasA/CKqB5+Sm9d2CFBXWMCkGNmbf9mY+4tb2Y5zJUP1DceDZJGrxyBB5jptBEfkwJ WDd3yrVXaGIkY2NRlOg+J1udd8HtNDOjsGcR0hLN+nk/SFeIOGZhs+YCudLte8howVuH /0Ig== X-Gm-Message-State: AOJu0Yxt3Z8Y7Gfuvy8/5su64+LCujJ6p7Vulb5HSgJxbOYjgEJN+fB5 lyO+GaYv9AIXDTGYtDUbkc8KRpHRphnweUk7iLeIayh8aDX1ix+Yqc9SOfdh2KJaCBXi/Nrz8n2 8kHnN3ZdhuNDm/95b3CdTXSHqwtEWBqM= X-Google-Smtp-Source: AGHT+IGwy2jFp9JDTiaUBaj/ehkLmoPgs4XsJeWvecRwmMKJlXZX/rMxVrEJALGgKzgRY3InGO4sGLYlQAIr X-Received: by 2002:a17:907:c207:b0:a45:6f9e:a93b with SMTP id ti7-20020a170907c20700b00a456f9ea93bmr4750596ejc.11.1710157900758; Mon, 11 Mar 2024 04:51:40 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id go33-20020a1709070da100b00a3f753f7544sm140837ejc.238.2024.03.11.04.51.40; Mon, 11 Mar 2024 04:51:40 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (vader.dev.6wind.com [10.17.1.39]) by smtpservice.6wind.com (Postfix) with ESMTP id 7983160235; Mon, 11 Mar 2024 12:51:40 +0100 (CET) From: Thierry Herbelot To: dev@dpdk.org Cc: Thierry Herbelot , Thomas Monjalon , Harman Kalra , Ferruh Yigit Subject: [V2] ethdev: restore eth_da init at startup of rte_eth_devargs_parse() Date: Mon, 11 Mar 2024 12:51:29 +0100 Message-Id: <20240311115129.2708247-1-thierry.herbelot@6wind.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240311114420.2706521-1-thierry.herbelot@6wind.com> References: <20240311114420.2706521-1-thierry.herbelot@6wind.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Commit 9a9eb104edf6 ("ethdev: parse multiple representor devargs") removes the following variable initialization in rte_eth_devargs_parse(): memset(eth_da, 0, sizeof(*eth_da)); Restore the memset, as this causes regression in ixgbe PCI probe. Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs") Signed-off-by: Thierry Herbelot --- V2: fix git hash length lib/ethdev/ethdev_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index 1660dd3f2a46..7513b990157f 100644 --- a/lib/ethdev/ethdev_driver.c +++ b/lib/ethdev/ethdev_driver.c @@ -617,6 +617,8 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_devargs, unsigned int i; int result = 0; + memset(eth_da, 0, sizeof(*eth_da)); + result = eth_dev_devargs_tokenise(&args, dargs); if (result < 0) goto parse_cleanup;