From: Shai Brandes <shaibran@amazon.com>
ENA device will send asynchronous notifications to the
driver in order to notify users about sub-optimal configurations
and refer them to public AWS documentation for further action.
Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
---
doc/guides/rel_notes/release_24_03.rst | 1 +
.../net/ena/base/ena_defs/ena_admin_defs.h | 11 +++++++-
drivers/net/ena/ena_ethdev.c | 26 +++++++++++++++++--
3 files changed, 35 insertions(+), 3 deletions(-)
@@ -106,6 +106,7 @@ New Features
* **Updated Amazon ena (Elastic Network Adapter) net driver.**
* Removed the reporting of `rx_overruns` errors from xstats and instead updated `imissed` stat with its value.
+ * Added support for sub-optimal configuration notifications from the device.
* **Updated Atomic Rules' Arkville driver.**
@@ -1214,7 +1214,8 @@ enum ena_admin_aenq_group {
ENA_ADMIN_NOTIFICATION = 3,
ENA_ADMIN_KEEP_ALIVE = 4,
ENA_ADMIN_REFRESH_CAPABILITIES = 5,
- ENA_ADMIN_AENQ_GROUPS_NUM = 6,
+ ENA_ADMIN_CONF_NOTIFICATIONS = 6,
+ ENA_ADMIN_AENQ_GROUPS_NUM = 7,
};
enum ena_admin_aenq_notification_syndrome {
@@ -1251,6 +1252,14 @@ struct ena_admin_aenq_keep_alive_desc {
uint32_t rx_overruns_high;
};
+struct ena_admin_aenq_conf_notifications_desc {
+ struct ena_admin_aenq_common_desc aenq_common_desc;
+
+ uint64_t notifications_bitmap;
+
+ uint64_t reserved;
+};
+
struct ena_admin_ena_mmio_req_read_less_resp {
uint16_t req_id;
@@ -36,6 +36,10 @@
#define ENA_MIN_RING_DESC 128
+#define BITS_PER_BYTE 8
+
+#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE)
+
/*
* We should try to keep ENA_CLEANUP_BUF_SIZE lower than
* RTE_MEMPOOL_CACHE_MAX_SIZE, so we can fit this in mempool local cache.
@@ -1842,7 +1846,8 @@ static int ena_device_init(struct ena_adapter *adapter,
BIT(ENA_ADMIN_NOTIFICATION) |
BIT(ENA_ADMIN_KEEP_ALIVE) |
BIT(ENA_ADMIN_FATAL_ERROR) |
- BIT(ENA_ADMIN_WARNING);
+ BIT(ENA_ADMIN_WARNING) |
+ BIT(ENA_ADMIN_CONF_NOTIFICATIONS);
aenq_groups &= get_feat_ctx->aenq.supported_groups;
@@ -4021,6 +4026,22 @@ static void ena_keep_alive(void *adapter_data,
adapter->dev_stats.tx_drops = tx_drops;
}
+static void ena_suboptimal_configuration(__rte_unused void *adapter_data,
+ struct ena_admin_aenq_entry *aenq_e)
+{
+ struct ena_admin_aenq_conf_notifications_desc *desc;
+ int bit, num_bits;
+
+ desc = (struct ena_admin_aenq_conf_notifications_desc *)aenq_e;
+ num_bits = BITS_PER_TYPE(desc->notifications_bitmap);
+ for (bit = 0; bit < num_bits; bit++) {
+ if (desc->notifications_bitmap & RTE_BIT64(bit)) {
+ PMD_DRV_LOG(WARNING,
+ "Sub-optimal configuration notification code: %d\n", bit + 1);
+ }
+ }
+}
+
/**
* This handler will called for unknown event group or unimplemented handlers
**/
@@ -4035,7 +4056,8 @@ static struct ena_aenq_handlers aenq_handlers = {
.handlers = {
[ENA_ADMIN_LINK_CHANGE] = ena_update_on_link_change,
[ENA_ADMIN_NOTIFICATION] = ena_notification,
- [ENA_ADMIN_KEEP_ALIVE] = ena_keep_alive
+ [ENA_ADMIN_KEEP_ALIVE] = ena_keep_alive,
+ [ENA_ADMIN_CONF_NOTIFICATIONS] = ena_suboptimal_configuration
},
.unimplemented_handler = unimplemented_aenq_handler
};