From patchwork Thu Mar 14 11:42:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 138388 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F1B743CA5; Thu, 14 Mar 2024 12:43:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F3BA42EB4; Thu, 14 Mar 2024 12:43:24 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2044.outbound.protection.outlook.com [40.107.102.44]) by mails.dpdk.org (Postfix) with ESMTP id 38B2442E9C for ; Thu, 14 Mar 2024 12:43:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxqEcmT7KrIkvn97fdDAxN5zkwp2dm44u59HZapotuoPqc28ZCOydl0cDlj/gAoy0QhXhUwHyQO7bfNiZVXK734nQzypCQipdlYUYrzn6v0xNR0QjVTGEwVa+tPXcZURvUGjgWCXUVZTlpoUscK7F32xbb7rWbDDQCJHNnvSxu93xwuHJihC02G1wgs0OhGvFPpBMOKyocoU0D2LgFnLyuX6lv7wFS2rfTcasvyG7o/2PvbBMcA6zjuScvBt1tV1SWQFdOLF0I8s60F2W0kSOGDUH35kzT2UX6eCXbYebMRm58TCpAQes4iO1BwI5Dzu6WRg+W+xUZFRqV25LSB6kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=fK3AmYYsh3XKeemPuXa8AarHSVREeIKLjMbrM89/O77N0+lxk9sPb7+omDpoQAdu0qPqipBcrB5Q1blfRfAqRkNQiCEKrxfcVCNtOqLQvQVos8N91PM+Mr4lrlpHmql1BiqWuoEvxwtdSAoWRk2eQR1+UAUNQdJH4r97DPQR4ZwFIdVRRCmwXRKPEVbGO/BaynTFoeax0DLYNyJcykU1meqesQLaoK/5DX2c6Q9yV6ERUN31uZWg+4YPpT94DYOJkTxd+v/vG/FSH9QG/H25By1awnNpwgcDl7QWMg/jQDKPJDw+A97KXK7FslHREPtnpyf2T3FvnZPaUuV+UNR8qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=GtxEQu9YEvtymcbF27oyj7vIamSOiChAxcWK6Zdb6SZsk8z6VNOHjHcZyPF1GXtSURsky4aTrPbZvDaTtWGibonXtapfMUXMf3nf+6MAicTRbU6g3WW7fENK1VxqdXKgazjyn1XZ6awjri4+VEWLMKFK+eCJCVzS4f/Rie8RITZSOGR2bg0mB/C4j6w+hKClhS8O7xwCBjhHr/oBl6uOvUBsnpIWXOAG/9hhFU3DIC1yaoAzQMhMvxc9kLq57QDJladvXuSpLiaLBzUj6uj1vk9owVSCk/HqdYbUn3bcpphaC9jNPt3lxlDkcJZO+j82ze4ckmRUrmbqCOhY+p8kog== Received: from CY8PR19CA0018.namprd19.prod.outlook.com (2603:10b6:930:44::15) by SA1PR12MB5615.namprd12.prod.outlook.com (2603:10b6:806:229::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar 2024 11:43:13 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:930:44:cafe::eb) by CY8PR19CA0018.outlook.office365.com (2603:10b6:930:44::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21 via Frontend Transport; Thu, 14 Mar 2024 11:43:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 11:43:12 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Mar 2024 04:43:03 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 14 Mar 2024 04:43:03 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Thu, 14 Mar 2024 04:42:59 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Suanming Mou , Matan Azrad CC: , Subject: [PATCH 05/13] net/mlx5/hws: return -rte_errno on rule creation failure Date: Thu, 14 Mar 2024 13:42:12 +0200 Message-ID: <20240314114220.203241-5-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240314114220.203241-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|SA1PR12MB5615:EE_ X-MS-Office365-Filtering-Correlation-Id: 40010e34-11f3-4c18-b712-08dc441bee29 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MebJz4n7l48/M/sfxX+6K+huNPAgtF5xDj7XygySr27I2XcBE4k+C8HeRxZo8PVdj5zkDElsHOvCto1by9DHI9DGIP+fiDgo9DhVZWt2JxhMxr+FQIRzBXELw4DOcXyzEfJrS9GQAoF+iHsALc4BzM53rb64q5Oc2tOSdqHPA8qtST2ga+qmS/zmCbA2EBFeJBwJhx+/DekJkPpSRoopJpueQQYuMeC7r4uTJw2Ky19tGK2sw7dL9NIMqdLjrYv9bID0faPrI1+shHSN7kEb3N/ld6Kw0eRLOEKzMs+yP9/xBZ7ZAStD4vEl5rDrPXPqLJYM09eix4El5aElHzHUaY8D5/toWlTt3uHmPCUfhSQjB0l4l7zvsZdW9W/sYD/9LKwhIsRoXWN0UHa4rJs9A+gQHBVElqslHIFl9nNBt/QeDEl+EXHaqbVavy3f3Fg+5byc+VWYvHaCcinDwjIK71XPOr+5fPXroP7JxuR3WVL1DCM2/0TAqKGzd6R8s9XXfOSVfSuxRxTxr5uBvkX+FXTdbIQK7hzur256HuWFzuC0DCHxPbOv4iRYFlP0DDEg+tbAZibSQH6lWvR74FsBaLbqNfaShmFPudSJsvr8E0JbENzRlqXp7+9qfn2B9UYqIFWcnGEblZKxq2dgYgxY+Bgpzomdf0WEWRiG1vPoBr2HDnSL4Ioa0KF5HLXx696hqn6085xJd/PXVbsJ1g2vvtmfw5vclx+YKqPwNjz5oPRRjqUpKeYutyJfUmW1WmT90rRut0+TDyko1zZV2HDaxg== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 11:43:12.9191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40010e34-11f3-4c18-b712-08dc441bee29 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5615 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik mlx5dr_rule_create returns -ret, so internal functions should return rte_errno on failure. Fix return values of the function that creates rule in root table. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index f14e1e6ecd..7bcf2de55f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -733,7 +733,7 @@ static int mlx5dr_rule_create_root(struct mlx5dr_rule *rule, free_attr: simple_free(attr); - return -rte_errno; + return rte_errno; } static int mlx5dr_rule_destroy_root(struct mlx5dr_rule *rule,