diff mbox series

app/testpmd: fix unpassed RSS algorithm

Message ID 20240315030054.2976598-1-haijie1@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series app/testpmd: fix unpassed RSS algorithm |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Jie Hai March 15, 2024, 3 a.m. UTC 
  The RSS algorithm from user is parased but not passed to the
rte_eth_dev_rss_hash_update() API as we wanted, this patch
fixes it.

Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
Cc: stable@dpdk.org

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 app/test-pmd/cmdline.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit March 15, 2024, 11:17 a.m. UTC | #1 
On 3/15/2024 3:00 AM, Jie Hai wrote:
> The RSS algorithm from user is parased but not passed to the
> rte_eth_dev_rss_hash_update() API as we wanted, this patch
> fixes it.
> 
> Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.


Sorry to see we missed something this simple, wasn't this tested when
command is added?
Jie Hai March 19, 2024, 2:29 a.m. UTC | #2 
On 2024/3/15 19:17, Ferruh Yigit wrote:
> On 3/15/2024 3:00 AM, Jie Hai wrote:
>> The RSS algorithm from user is parased but not passed to the
>> rte_eth_dev_rss_hash_update() API as we wanted, this patch
>> fixes it.
>>
>> Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
> 
> Applied to dpdk-next-net/main, thanks.
> 
> 
> Sorry to see we missed something this simple, wasn't this tested when
> command is added?
> 
> .
I'm sorry for my mistake.
After the first round of functional tests passed,
I didn't double check it carefully after the second round of changes.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f521a1fe9e8a..b7759e38a871 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -2319,6 +2319,7 @@  cmd_config_rss_hash_algo_parsed(void *parsed_result,
 		return;
 	}
 
+	rss_conf.algorithm = algorithm;
 	ret = rte_eth_dev_rss_hash_update(res->port_id, &rss_conf);
 	if (ret != 0) {
 		fprintf(stderr, "failed to set port %u RSS hash algorithm\n",