From patchwork Wed Mar 20 13:02:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Jones X-Patchwork-Id: 138654 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E8B143D11; Thu, 21 Mar 2024 08:43:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D87B4028B; Thu, 21 Mar 2024 08:43:53 +0100 (CET) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mails.dpdk.org (Postfix) with ESMTP id F37FC4029F for ; Wed, 20 Mar 2024 14:03:15 +0100 (CET) Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4V080L63Gsz3rMZ; Wed, 20 Mar 2024 13:03:14 +0000 (UTC) (envelope-from thj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V080L51Lhz4qHS; Wed, 20 Mar 2024 13:03:14 +0000 (UTC) (envelope-from thj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710939794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AAvq6rrC5JyIADnEAej52HJ4Bp4Y/HH1nzpei6pjNDg=; b=JwjF3fHJaNHqc7KzkPWV+UIedWV1/V/8f9pTwwCPG/iLGM/SR/Iewl9Vk0kU+Gu/Y9x6ps /Fr342k2h49EN+EwJdGFmE/IbV4FpMiB1pTLdqeQvIr7xdEDJbEh65Iri7CpSa6lLuBPqh GN9N8lflL72tdkhl9er221vPm9CqzgrhcspyfcwMniT0/zXTyZL8AuTyVOry2tTnUfWgI4 ghsaaYvRUISgO7PMpVnbvjDCMQ17TN1epRZBtBVwktWeAhgw69pqsoNchB5KeEdRpMSABN EFmh+QiE5ZU5hrnTWb3dDCNW/UuS7lhTYPmWV7b4VkRgm8fBCYwZV+XFiTQzvQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710939794; a=rsa-sha256; cv=none; b=AKH56IiX9dQ9Xmv3rwFxHR6qZXQ1US7PczYaZ17RwoINj2+HaEI2HPTBhSDgoch5MjQN61 eHWZswxHJMn+X20HTHf5FES06WmBOQFHh1DFM6onF0XdPnmv0CjMNtzV2Y2gHmoH8EjVuk TGY/eEbT3lV8N1a0yNbT78HtgsUK6P++/bW2LDe3wIXqEyjneGSOgpoAl7nJvh98Cjsvme 3IJm75i+MJZ4NYM0BbkV6/OH3lbp1RToFWYc842IDN965KMmU7I2RZJIwwvRC/eKHDXxUD NGKk8PH1ZcdB1gR+kkjzQm8oz83ktvIzQWVHvu1K+iSogxXfCMssnq/TLROJvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710939794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AAvq6rrC5JyIADnEAej52HJ4Bp4Y/HH1nzpei6pjNDg=; b=XLuO77/Nz2OEvLwj5BoYqU4dnAN3PJNlB4onVW3mJIwHKnOGBybtJeZH1fanevFdaPAaEu Cj557LWy+JUXXV2ZL08ipjO8CCwysZiTPH/VyphSO8bklHjJuEgrpfJmjIHD4ilmmnriin Uz+xfHh7Bd2RfFAt7lp4UyGlREJ6rRLmvPsjIrVtHWAoepgLNWzPy0HazdqmCrAoThh6n4 BJKSZRy5hoCuI35KhsB70YHPyxQV+2U4iu9SldSoIYbwOg9v9N24iWafBUDrc8RSZhxtgT +j2GvlVxgdniCmTMHY88tRhD9IfpSAT0XlRbKrujUQEx1qtHZcPXzr3itdUs3g== Received: from vpp.my.domain (unknown [188.74.83.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: thj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V080L1JhJzGn6; Wed, 20 Mar 2024 13:03:14 +0000 (UTC) (envelope-from thj@freebsd.org) From: Tom Jones To: jbehrens@vmware.com Cc: dev@dpdk.org, thj@freebsd.org Subject: [PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD Date: Wed, 20 Mar 2024 13:02:55 +0000 Message-ID: <20240320130255.1526-1-thj@freebsd.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 21 Mar 2024 08:43:52 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 driver as they are not supported. Rx queue interrupts were missed by this change, don't attempt to enable them on FreeBSD. Without this change applications enabling interrupts encounter an immediate abort on FreeBSD. Signed-off-by: Tom Jones --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 2707b25148..8b12967fa2 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1938,9 +1938,11 @@ vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id) { struct vmxnet3_hw *hw = dev->data->dev_private; +#ifndef RTE_EXEC_ENV_FREEBSD vmxnet3_enable_intr(hw, rte_intr_vec_list_index_get(dev->intr_handle, queue_id)); +#endif return 0; }