From patchwork Thu Mar 21 10:31:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Jones X-Patchwork-Id: 138659 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58AE843D14; Thu, 21 Mar 2024 11:34:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F1A342830; Thu, 21 Mar 2024 11:34:31 +0100 (CET) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mails.dpdk.org (Postfix) with ESMTP id 015C040261; Thu, 21 Mar 2024 11:31:45 +0100 (CET) Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4V0hb50twKz4dxl; Thu, 21 Mar 2024 10:31:45 +0000 (UTC) (envelope-from thj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V0hb509r2z49Fb; Thu, 21 Mar 2024 10:31:45 +0000 (UTC) (envelope-from thj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711017105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TbjvRqAKzUwZk8EPXar+iuOlD5Pcb/8DAi5d4QQdceQ=; b=mVrIORDPUNdz7gEk5Q5nEKoC4njz2q4i75av9W7DfHLbZ/hKgAaKlMFGjwUm64tIDcM6un lNb6fksYbPEIHz1sioD9AAMNATM5YPUwdMgEMSQbDJnDohC2zQ+7eOjoMkno+z7oeWxJWY RwDn2proHbMZ0Z5JCImYToIUgCZRQBImWjM5KUI5Xosg9GSqAg/34vSuMX1gowXLFbRqZ0 GkI3F3M1Hl27VUzefpHyYnbNHIxreDX92LeDBmiPGaaYL7y88B5wlAb0tXm8obpYWgyM2U o3MvZ3F5m0h4N69sY4L+mha3HDyJ0QcvShysdr2m69aY41wMsuYWhIbmnu6bSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711017105; a=rsa-sha256; cv=none; b=xm+em1uESxUv6jyCsRkRxtm1UYHZVZd5rFkw7A+h1QnpnFWIkWVuRhwFRmtfg/1osTNmcf 66UyVIW62zSH5A6kafn3tS7fq9ewrUjMsJzHKQWPh2STYdzWPXeb7+90dIq/lgoU++9fFD NEO+JPNp7M9BM8NyaRmIHJF919L9UPyYDA4nCJMq5gGxwytT2kAdiA4ar131HmGw2zutVX 7U2AkZsU4D9e63caq9ZxGCvlbMRwrITBVkkZUdmurnCXJrksr3xe++LX34jsOkAAASKi1E g26sF8xUHgo/F4ii+CBbJZC168jeEZgyjeAV3rnvRADXTFSatv8oylef3Xl+GQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711017105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TbjvRqAKzUwZk8EPXar+iuOlD5Pcb/8DAi5d4QQdceQ=; b=HPX7tcAD5QytmLLhDZ8PhEwzkgttfvYi54b8tCXNGMc0upRDoXTZnPbv6XWSLsDjVadOwi 4xFXvCcIfJLyGaBTfhPuVrkbsINjRqd275EvjQ0cF/FAxVwnaoVFFnIKHmbeXt+MaXDaNP sqz0gYzyow3Iig/BXCUpRsSAeIsKk1F6CYqHDVpI+SPcvxbmEaNjI0e1/eYri2zx+SlHOa cteC8hxmQhtiAc6VcllT2Q6DKkw0UbABmhEpbnhPndaVxd7anf+Tr/Dcy6eK9i5CW6AWBl +NgO6ZndBrDSV/EX0sk6CfADKckBSR/c8oU9HRMREOm/QMj0qqU6CVPDPO7F1Q== Received: from vpp.my.domain (unknown [188.74.83.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: thj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V0hb43Sv7zhlW; Thu, 21 Mar 2024 10:31:44 +0000 (UTC) (envelope-from thj@freebsd.org) From: Tom Jones To: dev@dpdk.org Cc: Tom Jones , stable@dpdk.org Subject: [PATCH] net/vmxnet3: Don't enable rx queue interrupts on FreeBSD Date: Thu, 21 Mar 2024 10:31:33 +0000 Message-ID: <20240321103133.1531-1-thj@freebsd.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240320130255.1526-1-thj@freebsd.org> References: <20240320130255.1526-1-thj@freebsd.org> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 21 Mar 2024 11:34:30 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Commit 29a1c9107bb disabled interrupts on FreeBSD for the vmxnet3 driver as they are not supported. Rx queue interrupts were missed by this change, don't attempt to enable them on FreeBSD. Without this change applications enabling interrupts encounter an immediate abort on FreeBSD. Fixes: 40d5676ff1ea ("net/vmxnet3: fix initialization on FreeBSD") Cc: stable@dpdk.org Signed-off-by: Tom Jones Acked-by: Ferruh Yigit --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 2707b25148..ce7c347254 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1936,11 +1936,13 @@ vmxnet3_interrupt_handler(void *param) static int vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id) { +#ifndef RTE_EXEC_ENV_FREEBSD struct vmxnet3_hw *hw = dev->data->dev_private; vmxnet3_enable_intr(hw, rte_intr_vec_list_index_get(dev->intr_handle, queue_id)); +#endif return 0; }