net/cnxk: add RSS config via ethdev configure API

Message ID 20240410131127.2482240-1-skori@marvell.com (mailing list archive)
State Superseded
Delegated to: Jerin Jacob
Headers
Series net/cnxk: add RSS config via ethdev configure API |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Sunil Kumar Kori April 10, 2024, 1:11 p.m. UTC
  From: Sunil Kumar Kori <skori@marvell.com>

Currently user passed RSS configuration is ignored via
rte_eth_dev_configure() API. Instead default RSS setup is done by
driver.

Adding handling for user passed RSS configuration too via
rte_eth_dev_configure().

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 drivers/net/cnxk/cnxk_ethdev.c | 7 +++++++
 1 file changed, 7 insertions(+)
  

Comments

Jerin Jacob May 23, 2024, 2:13 p.m. UTC | #1
On Wed, Apr 10, 2024 at 6:41 PM <skori@marvell.com> wrote:
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> Currently user passed RSS configuration is ignored via
> rte_eth_dev_configure() API. Instead default RSS setup is done by
> driver.

Rewrite the git commit as fix and add Fixes: tag


>
> Adding handling for user passed RSS configuration too via
> rte_eth_dev_configure().
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
>  drivers/net/cnxk/cnxk_ethdev.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
> index 6b37bd877f..95a3d8aaf9 100644
> --- a/drivers/net/cnxk/cnxk_ethdev.c
> +++ b/drivers/net/cnxk/cnxk_ethdev.c
> @@ -1384,6 +1384,13 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)
>                 goto free_nix_lf;
>         }
>
> +       /* Overwrite default RSS setup if requested by user */
> +       rc = cnxk_nix_rss_hash_update(eth_dev, &conf->rx_adv_conf.rss_conf);
> +       if (rc) {
> +               plt_err("Failed to configure rss rc=%d", rc);
> +               goto free_nix_lf;
> +       }
> +
>         /* Init the default TM scheduler hierarchy */
>         rc = roc_nix_tm_init(nix);
>         if (rc) {
> --
> 2.25.1
>
  

Patch

diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index 6b37bd877f..95a3d8aaf9 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -1384,6 +1384,13 @@  cnxk_nix_configure(struct rte_eth_dev *eth_dev)
 		goto free_nix_lf;
 	}
 
+	/* Overwrite default RSS setup if requested by user */
+	rc = cnxk_nix_rss_hash_update(eth_dev, &conf->rx_adv_conf.rss_conf);
+	if (rc) {
+		plt_err("Failed to configure rss rc=%d", rc);
+		goto free_nix_lf;
+	}
+
 	/* Init the default TM scheduler hierarchy */
 	rc = roc_nix_tm_init(nix);
 	if (rc) {