diff mbox series

[v3,4/5] latencystats: fix log messages

Message ID	20240417170908.76701-5-stephen@networkplumber.org (mailing list archive)
State	Superseded
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Reshma Pattan <reshma.pattan@intel.com> Subject: [PATCH v3 4/5] latencystats: fix log messages Date: Wed, 17 Apr 2024 10:07:26 -0700 Message-ID: <20240417170908.76701-5-stephen@networkplumber.org> In-Reply-To: <20240417170908.76701-1-stephen@networkplumber.org> References: <0240408195036.182545-1-stephen@networkplumber.org> <20240417170908.76701-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	latencystats: cleanups \| [v3,0/5] latencystats: cleanups [v3,1/5] latencystats: replace use of VLA [v3,2/5] latencystats: handle fractional cycles per ns [v3,3/5] latencystats: do not use floating point [v3,4/5] latencystats: fix log messages [v3,5/5] latencystats: include file cleanup

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger April 17, 2024, 5:07 p.m. UTC

  All messages that because of an error should be at log level
NOTICE or above. Do not break log messages across lines.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/latencystats/rte_latencystats.c | 30 ++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

Comments

Tyler Retzlaff April 18, 2024, 12:13 a.m. UTC | #1

On Wed, Apr 17, 2024 at 10:07:26AM -0700, Stephen Hemminger wrote:
> All messages that because of an error should be at log level
> NOTICE or above. Do not break log messages across lines.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/latencystats/rte_latencystats.c | 30 ++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c
> index 11bd0ea4ae..62038a9f5d 100644
> --- a/lib/latencystats/rte_latencystats.c
> +++ b/lib/latencystats/rte_latencystats.c
> @@ -235,7 +235,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
>  	latency_stats_index = rte_metrics_reg_names(ptr_strings,
>  							NUM_LATENCY_STATS);
>  	if (latency_stats_index < 0) {
> -		LATENCY_STATS_LOG(DEBUG,
> +		LATENCY_STATS_LOG(ERR,
>  			"Failed to register latency stats names");
>  		return -1;
>  	}
> @@ -255,7 +255,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
>  
>  		ret = rte_eth_dev_info_get(pid, &dev_info);
>  		if (ret != 0) {
> -			LATENCY_STATS_LOG(INFO,
> +			LATENCY_STATS_LOG(NOTICE,
>  				"Error during getting device (port %u) info: %s",

nit: the level is notice, but the message says 'Error' same in a couple
of other instances below. arguably fine so you can ignore me.

>  				pid, strerror(-ret));
>  
> @@ -267,18 +267,18 @@ rte_latencystats_init(uint64_t app_samp_intvl,
>  			cbs->cb = rte_eth_add_first_rx_callback(pid, qid,
>  					add_time_stamps, user_cb);
>  			if (!cbs->cb)
> -				LATENCY_STATS_LOG(INFO, "Failed to "
> -					"register Rx callback for pid=%d, "
> -					"qid=%d", pid, qid);
> +				LATENCY_STATS_LOG(NOTICE,
> +					"Failed to register Rx callback for pid=%u, qid=%u",
> +					pid, qid);
>  		}
>  		for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
>  			cbs = &tx_cbs[pid][qid];
>  			cbs->cb =  rte_eth_add_tx_callback(pid, qid,
>  					calc_latency, user_cb);
>  			if (!cbs->cb)
> -				LATENCY_STATS_LOG(INFO, "Failed to "
> -					"register Tx callback for pid=%d, "
> -					"qid=%d", pid, qid);
> +				LATENCY_STATS_LOG(NOTICE,
> +					"Failed to register Tx callback for pid=%u, qid=%u",
> +					pid, qid);
>  		}
>  	}
>  	return 0;
> @@ -299,7 +299,7 @@ rte_latencystats_uninit(void)
>  
>  		ret = rte_eth_dev_info_get(pid, &dev_info);
>  		if (ret != 0) {
> -			LATENCY_STATS_LOG(INFO,
> +			LATENCY_STATS_LOG(NOTICE,
>  				"Error during getting device (port %u) info: %s",
>  				pid, strerror(-ret));
>  
> @@ -310,17 +310,17 @@ rte_latencystats_uninit(void)
>  			cbs = &rx_cbs[pid][qid];
>  			ret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);
>  			if (ret)
> -				LATENCY_STATS_LOG(INFO, "failed to "
> -					"remove Rx callback for pid=%d, "
> -					"qid=%d", pid, qid);
> +				LATENCY_STATS_LOG(NOTICE,
> +					"Failed to remove Rx callback for pid=%u, qid=%u",
> +					pid, qid);
>  		}
>  		for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
>  			cbs = &tx_cbs[pid][qid];
>  			ret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);
>  			if (ret)
> -				LATENCY_STATS_LOG(INFO, "failed to "
> -					"remove Tx callback for pid=%d, "
> -					"qid=%d", pid, qid);
> +				LATENCY_STATS_LOG(NOTICE,
> +					"Failed to remove Tx callback for pid=%u, qid=%u",
> +					pid, qid);
>  		}
>  	}
>  
> -- 

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

diff mbox series

Patch

diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c
index 11bd0ea4ae..62038a9f5d 100644
--- a/lib/latencystats/rte_latencystats.c
+++ b/lib/latencystats/rte_latencystats.c
@@ -235,7 +235,7 @@  rte_latencystats_init(uint64_t app_samp_intvl,
 	latency_stats_index = rte_metrics_reg_names(ptr_strings,
 							NUM_LATENCY_STATS);
 	if (latency_stats_index < 0) {
-		LATENCY_STATS_LOG(DEBUG,
+		LATENCY_STATS_LOG(ERR,
 			"Failed to register latency stats names");
 		return -1;
 	}
@@ -255,7 +255,7 @@  rte_latencystats_init(uint64_t app_samp_intvl,
 
 		ret = rte_eth_dev_info_get(pid, &dev_info);
 		if (ret != 0) {
-			LATENCY_STATS_LOG(INFO,
+			LATENCY_STATS_LOG(NOTICE,
 				"Error during getting device (port %u) info: %s",
 				pid, strerror(-ret));
 
@@ -267,18 +267,18 @@  rte_latencystats_init(uint64_t app_samp_intvl,
 			cbs->cb = rte_eth_add_first_rx_callback(pid, qid,
 					add_time_stamps, user_cb);
 			if (!cbs->cb)
-				LATENCY_STATS_LOG(INFO, "Failed to "
-					"register Rx callback for pid=%d, "
-					"qid=%d", pid, qid);
+				LATENCY_STATS_LOG(NOTICE,
+					"Failed to register Rx callback for pid=%u, qid=%u",
+					pid, qid);
 		}
 		for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
 			cbs = &tx_cbs[pid][qid];
 			cbs->cb =  rte_eth_add_tx_callback(pid, qid,
 					calc_latency, user_cb);
 			if (!cbs->cb)
-				LATENCY_STATS_LOG(INFO, "Failed to "
-					"register Tx callback for pid=%d, "
-					"qid=%d", pid, qid);
+				LATENCY_STATS_LOG(NOTICE,
+					"Failed to register Tx callback for pid=%u, qid=%u",
+					pid, qid);
 		}
 	}
 	return 0;
@@ -299,7 +299,7 @@  rte_latencystats_uninit(void)
 
 		ret = rte_eth_dev_info_get(pid, &dev_info);
 		if (ret != 0) {
-			LATENCY_STATS_LOG(INFO,
+			LATENCY_STATS_LOG(NOTICE,
 				"Error during getting device (port %u) info: %s",
 				pid, strerror(-ret));
 
@@ -310,17 +310,17 @@  rte_latencystats_uninit(void)
 			cbs = &rx_cbs[pid][qid];
 			ret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);
 			if (ret)
-				LATENCY_STATS_LOG(INFO, "failed to "
-					"remove Rx callback for pid=%d, "
-					"qid=%d", pid, qid);
+				LATENCY_STATS_LOG(NOTICE,
+					"Failed to remove Rx callback for pid=%u, qid=%u",
+					pid, qid);
 		}
 		for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
 			cbs = &tx_cbs[pid][qid];
 			ret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);
 			if (ret)
-				LATENCY_STATS_LOG(INFO, "failed to "
-					"remove Tx callback for pid=%d, "
-					"qid=%d", pid, qid);
+				LATENCY_STATS_LOG(NOTICE,
+					"Failed to remove Tx callback for pid=%u, qid=%u",
+					pid, qid);
 		}
 	}