From patchwork Mon Apr 22 15:40:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139623 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83E2843EDB; Mon, 22 Apr 2024 17:44:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE06C402F1; Mon, 22 Apr 2024 17:44:04 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id ACF13402F2 for ; Mon, 22 Apr 2024 17:44:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713800641; x=1745336641; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gEGlJrgFtgPpiwC2F/zpxpMBcoUQL3bsvUdNPq9HaZE=; b=JSSrUfy3eCkGqZR/mz1EyvFJbJzL9fZ3vwjWT83aDRdCC611ln7PM6PL 2rqZ6o+IEnoMPJX65Lapr8l3MRcconoRFYn18KqkxXwcfAEi22ASvhFes xk0WXHQKY1aDslJy/3oGUxdcFyrFK9li2Q8vjA+sfSzxPNCV2y8liyIuu YVlv+axBwzq2S4tShKcAOn33mjoalu3dtQwG/eLdFXM7IaQLdSuOqQ9nM LMW2dbfkpUIR6Bu7zL+UdFFIEJVNpg4YYMXU1vhzdbmyuvt6hqRybDjfY Pq8V9uV2sOgmoHDK9nY4vvXhaNMUyUDbpgGOUbpxWQp7uetIpiyqCdbpO A==; X-CSE-ConnectionGUID: 0uLsGGZBTEWSEoByYSBdJQ== X-CSE-MsgGUID: VeFTkzQnR82I7esj/eNbPA== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="20492710" X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="20492710" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 08:43:41 -0700 X-CSE-ConnectionGUID: BQHaJ0TzT9KvXw1AtmHvNQ== X-CSE-MsgGUID: OM89UAt3QdKFk0VaufOLmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="28567540" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by fmviesa003.fm.intel.com with ESMTP; 22 Apr 2024 08:43:40 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 4/5] baseband/acc: improve error description Date: Mon, 22 Apr 2024 08:40:07 -0700 Message-Id: <20240422154008.119800-5-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422154008.119800-1-hernan.vargas@intel.com> References: <20240422154008.119800-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove dead code for error and update description of one error print. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index f37722879c20..8ec521675f34 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -1152,7 +1152,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, uint16_t harq_out_length, harq_in_length, ncb_p, k0_p, parity_offset; uint32_t harq_index; uint32_t l; - uint32_t max_hc_in; fcw->qm = op->ldpc_dec.q_m; fcw->nfiller = op->ldpc_dec.n_filler; @@ -1222,21 +1221,6 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, fcw->hcin_size1 = 0; } - /* Enforce additional check on FCW validity */ - max_hc_in = RTE_ALIGN_CEIL(fcw->ncb - fcw->nfiller, ACC_HARQ_ALIGN_64B); - if ((fcw->hcin_size0 > max_hc_in) || - (fcw->hcin_size1 + fcw->hcin_offset > max_hc_in) || - ((fcw->hcin_size0 > fcw->hcin_offset) && - (fcw->hcin_size1 != 0))) { - rte_bbdev_log(ERR, " Invalid FCW : HCIn %d %d %d, Ncb %d F %d", - fcw->hcin_size0, fcw->hcin_size1, - fcw->hcin_offset, - fcw->ncb, fcw->nfiller); - /* Disable HARQ input in that case to carry forward */ - op->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE; - fcw->hcin_en = 0; - } - fcw->itmax = op->ldpc_dec.iter_max; fcw->itstop = check_bit(op->ldpc_dec.op_flags, RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE); @@ -1286,8 +1270,7 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, fcw->hcout_offset = 0; if (fcw->hcout_size0 == 0) { - rte_bbdev_log(ERR, " Invalid FCW : HCout %d", - fcw->hcout_size0); + rte_bbdev_log(ERR, " Disabling HARQ output as size is zero"); op->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE; fcw->hcout_en = 0; }