From patchwork Mon Apr 22 18:10:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ronak Doshi X-Patchwork-Id: 139626 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E77DA43EDD; Mon, 22 Apr 2024 20:11:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8020B40268; Mon, 22 Apr 2024 20:11:06 +0200 (CEST) Received: from EX-PRD-EDGE02.vmware.com (ex-prd-edge02.vmware.com [208.91.3.34]) by mails.dpdk.org (Postfix) with ESMTP id 75E5F40265; Mon, 22 Apr 2024 20:11:04 +0200 (CEST) Received: from sc9-mailhost1.vmware.com (10.113.161.71) by EX-PRD-EDGE02.vmware.com (10.188.245.7) with Microsoft SMTP Server id 15.1.2375.34; Mon, 22 Apr 2024 11:10:43 -0700 Received: from htb-1n-eng-dhcp122.eng.vmware.com (unknown [10.172.6.252]) by sc9-mailhost1.vmware.com (Postfix) with ESMTP id 09838202FE; Mon, 22 Apr 2024 11:10:52 -0700 (PDT) Received: by htb-1n-eng-dhcp122.eng.vmware.com (Postfix, from userid 0) id 05AA7AEC79; Mon, 22 Apr 2024 11:10:52 -0700 (PDT) From: Ronak Doshi To: Jochen Behrens , Ronak Doshi CC: , Ronak Doshi , Subject: [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command Date: Mon, 22 Apr 2024 11:10:50 -0700 Message-ID: <20240422181050.9661-1-ronak.doshi@broadcom.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Received-SPF: SoftFail (EX-PRD-EDGE02.vmware.com: domain of transitioning ronak.doshi@broadcom.com discourages use of 10.113.161.71 as permitted sender) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Vmxnet3 uses capability registers to advertise the supported capabilities of UPT device. It uses DCR0_REG command register for this purpose. However, the register command enum misses one command which technically is not used by dpdk vmxnet3 driver yet. This can cause issue for commands added later. For example, DCR0_REG and MAX_CAPABILITIES register commands when issued will lead to incorrect command being executed in the hypervisor. The return values can be unexpected and can result in some capabilities being disabled and affect vnics requesting Uniform Passthroguh (UPT) mode. This patch fixes this issue by adding a reserved command in its place. Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers") Cc: stable@dpdk.org Signed-off-by: Ronak Doshi --- Change log v2: fixed typo v3: updated commit message with more information --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h index 24c235876e..a6bb281d8d 100644 --- a/drivers/net/vmxnet3/base/vmxnet3_defs.h +++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h @@ -126,6 +126,7 @@ typedef enum { VMXNET3_CMD_RESERVED7, VMXNET3_CMD_RESERVED8, VMXNET3_CMD_GET_MAX_QUEUES_CONF, + VMXNET3_CMD_RESERVED11, VMXNET3_CMD_GET_MAX_CAPABILITIES, VMXNET3_CMD_GET_DCR0_REG, } Vmxnet3_Cmd;