From patchwork Mon Apr 22 19:07:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 139634 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FE5043EDD; Mon, 22 Apr 2024 21:12:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C6FC40A71; Mon, 22 Apr 2024 21:11:44 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 67E2D402F0 for ; Mon, 22 Apr 2024 21:11:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713813096; x=1745349096; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Yoja6VPQ2sIc9oxPMcik3HfIHnvvsfFXkFXnhcTn++w=; b=NUaHY9f8AZNb6e51cjW4MIz+omo8O208Aclb7kvDuIZKvffKm4W5Wlpu mwMpwqBClnJoAeVXbTo7LCY5Iix9K5pF4oa/+uKjlnlS7jUzqVbHpXC9m pfhsXNilN5J/FTJOviQuhtkGBPQQ7ay4pd0WdBrwAAP6dDsoE8F71yOsP q3ygVI/e1JM/EK8d/iTuyyMpYGu9DIKaFtjW3hnYO+V6MtHbed5O32zg/ a7oLmG2GeRdamnJLTAUR34nsorHQ/maI3wQcuS11dq7IamOeGW1FmnTrV FKTXog+1TDOJzvLu/+ni3nTGZAfPXS2ExznLDyE94uCu8LaSm0G01p7nq w==; X-CSE-ConnectionGUID: 8DLLYyFjQheq6FoM9Ccnog== X-CSE-MsgGUID: B7lmTq7VT9SRReJE3jO9ZQ== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="19922817" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="19922817" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 12:11:35 -0700 X-CSE-ConnectionGUID: g8n7etWGQGqvgE6D+PJfVg== X-CSE-MsgGUID: wr0a78ZeSZyfhL3nbQhSWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="24555972" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orviesa006.jf.intel.com with ESMTP; 22 Apr 2024 12:11:34 -0700 From: Hernan Vargas To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com, maxime.coquelin@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v1 7/9] test/bbdev: check assumptions on fft window Date: Mon, 22 Apr 2024 12:07:58 -0700 Message-Id: <20240422190800.123027-8-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20240422190800.123027-1-hernan.vargas@intel.com> References: <20240422190800.123027-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add check for FFT window width. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 26 ++++++++++++++++++++++---- app/test-bbdev/test_bbdev_vector.c | 14 ++++++++++++++ app/test-bbdev/test_bbdev_vector.h | 2 ++ 3 files changed, 38 insertions(+), 4 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 28d78e73a9c1..57b21730cab2 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -106,6 +106,8 @@ static int ldpc_llr_decimals; static int ldpc_llr_size; /* Keep track of the LDPC decoder device capability flag */ static uint32_t ldpc_cap_flags; +/* FFT window width predefined on device and on vector. */ +static int fft_window_width_dev; /* Represents tested active devices */ static struct active_device { @@ -881,6 +883,13 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, rte_bbdev_info_get(dev_id, info); if (info->drv.device_status == RTE_BBDEV_DEV_FATAL_ERR) printf("Device Status %s\n", rte_bbdev_device_status_str(info->drv.device_status)); + if (info->drv.fft_window_width != NULL) + fft_window_width_dev = info->drv.fft_window_width[0]; + else + fft_window_width_dev = 0; + if (fft_window_width_dev != 0) + printf(" FFT Window0 width %d\n", fft_window_width_dev); + nb_queues = RTE_MIN(rte_lcore_count(), info->drv.max_num_queues); nb_queues = RTE_MIN(nb_queues, (unsigned int) MAX_QUEUES); @@ -2583,7 +2592,8 @@ validate_ldpc_enc_op(struct rte_bbdev_enc_op **ops, const uint16_t n, } static inline int -validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op) +validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig_op, + bool skip_validate_output) { struct rte_mbuf *m = op->data; uint8_t i, nb_dst_segments = orig_op->nb_segments; @@ -2613,7 +2623,7 @@ validate_op_fft_chain(struct rte_bbdev_op_data *op, struct op_data_entries *orig abs_delt = delt > 0 ? delt : -delt; error_num += (abs_delt > thres_hold ? 1 : 0); } - if (error_num > 0) { + if ((error_num > 0) && !skip_validate_output) { rte_memdump(stdout, "Buffer A", ref_out, data_len); rte_memdump(stdout, "Buffer B", op_out, data_len); TEST_ASSERT(error_num == 0, @@ -2686,16 +2696,24 @@ validate_fft_op(struct rte_bbdev_fft_op **ops, const uint16_t n, int ret; struct op_data_entries *fft_data_orig = &test_vector.entries[DATA_HARD_OUTPUT]; struct op_data_entries *fft_pwr_orig = &test_vector.entries[DATA_SOFT_OUTPUT]; + bool skip_validate_output = false; + + if ((test_vector.fft_window_width_vec > 0) && + (test_vector.fft_window_width_vec != fft_window_width_dev)) { + printf("The vector FFT width doesn't match with device - skip %d %d\n", + test_vector.fft_window_width_vec, fft_window_width_dev); + skip_validate_output = true; + } for (i = 0; i < n; ++i) { ret = check_fft_status_and_ordering(ops[i], i, ref_op->status); TEST_ASSERT_SUCCESS(ret, "Checking status and ordering for FFT failed"); TEST_ASSERT_SUCCESS(validate_op_fft_chain( - &ops[i]->fft.base_output, fft_data_orig), + &ops[i]->fft.base_output, fft_data_orig, skip_validate_output), "FFT Output buffers (op=%u) are not matched", i); if (check_bit(ops[i]->fft.op_flags, RTE_BBDEV_FFT_POWER_MEAS)) TEST_ASSERT_SUCCESS(validate_op_fft_chain( - &ops[i]->fft.power_meas_output, fft_pwr_orig), + &ops[i]->fft.power_meas_output, fft_pwr_orig, skip_validate_output), "FFT Power Output buffers (op=%u) are not matched", i); } diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index b3e9d4bb7504..e48947b211ac 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/test-bbdev/test_bbdev_vector.c @@ -1050,6 +1050,20 @@ parse_fft_params(const char *key_token, char *token, } } ret = ((err == NULL) || (*err != '\0')) ? -1 : 0; + } else if (!strcmp(key_token, "fft_window_width")) { + tok = strtok(token, VALUE_DELIMITER); + if (tok == NULL) + return -1; + for (i = 0; i < FFT_WIN_SIZE; i++) { + if (i == 0) + vector->fft_window_width_vec = (uint32_t) strtoul(tok, &err, 0); + if (i < (FFT_WIN_SIZE - 1)) { + tok = strtok(NULL, VALUE_DELIMITER); + if (tok == NULL) + return -1; + } + } + ret = ((err == NULL) || (*err != '\0')) ? -1 : 0; } else if (!strcmp(key_token, "op_flags")) { vector->mask |= TEST_BBDEV_VF_OP_FLAGS; ret = parse_turbo_flags(token, &op_flags, vector->op_type); diff --git a/app/test-bbdev/test_bbdev_vector.h b/app/test-bbdev/test_bbdev_vector.h index 14b8ef2764ad..ba1d0d20f9ea 100644 --- a/app/test-bbdev/test_bbdev_vector.h +++ b/app/test-bbdev/test_bbdev_vector.h @@ -69,6 +69,8 @@ struct test_bbdev_vector { }; /* Additional storage for op data entries */ struct op_data_entries entries[DATA_NUM_TYPES]; + /* Vector FFT window width assumption. */ + uint16_t fft_window_width_vec; }; /* fills test vector parameters based on test file */