From patchwork Mon Apr 29 09:51:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mattias_R=C3=B6nnblom?= X-Patchwork-Id: 139720 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 417D543F49; Mon, 29 Apr 2024 12:02:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFE5E402EB; Mon, 29 Apr 2024 12:02:12 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2042.outbound.protection.outlook.com [40.107.8.42]) by mails.dpdk.org (Postfix) with ESMTP id E8453402D0 for ; Mon, 29 Apr 2024 12:02:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bP/9wu0FKmp/zj09tCyP8uTY3eEq+pmk830sRGekS0RS1V2h0fn49JdT6SdfzbJbpUxMgtykc2xQz1KhEWzCVtp1GveOtaewdwFxaK+vkvlHuljyXHXqEhW1hOAd6Ec0tC3zK5YtW/jiA4PxXJ3l/J73r07Iz+yF6bclNhr+F6ccQMtYK7DnTWERlRsFVdj/c6gZBESQ/jpHlTxMuzleyqSLgTEGKnIo7NcJskE9y36RIH057rjicfCi/BEtzL9BZPq/Sm+RqN7ao6KNImje/xY7MbuD6J/Xb7uPnmEzEvUCbpW/xT8gWms7R4vxP6uc/MTHRc/RU7Ls+aKqJWei1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vV0MxvxvrsgxLRzfbnzW7OwWkR3i8PuvgA6na5XXKQo=; b=W/SOdHsj3wE6BOC1aBfR/5WihWGkcZOc21vHfEwyaBSnBf9OiSHIRxbrVVxe66l3gxeBf8vjG3APPOhBc3/MLGqOi4SGFf0jgoe9uSCaV2uaYD8BzEjZyR9EAQ+4xZviCKF8TolmSwq+029qtZDbhVbMCSpDcg+mQOogwBaFylLNwdR8X/C7+lf4KjG5cGlrsmnZsDExXyKFo7i5jYpZzpyh3asoIfoX3WuWJUnF5JFrXSXVnkOJGcw6NqCeuYWVofuw+pai/SArgQuzRe2dEN1QS98tQWIj55i0Vmx3HgEdJqiT+HdTGSRuf2OmzCVwbSMsIjGcUY2aDEguVDmcyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vV0MxvxvrsgxLRzfbnzW7OwWkR3i8PuvgA6na5XXKQo=; b=YkjhvR/MUbu2qwrekLMEbWW/gq8dv7AT7R8UAunas2nemWixPVz7j6HiUqLZTNj77qf4ph8oZAOGnRrFlxTaYlmN5irPFk/78q1ZPX1NU+GMT9ad4JWKjHqb7h8ax3AKBfYHTyuOYzrGGgYSYhSOQb1+emHAHaCaJk4FZK6aUzIkZdnCVazwqpQlWsbEcwkvH/1kLOFf1gwWmJgO/9xAAqNElTEKGJ2josVZPoWfpdnDbfPJCZ+1AKVvXC14lSyUlkN2C+e8KuX7b7xbVnhP1Ted25I9PoRmwTSDpCYPzruAXMT4A1+3nKsw4AQcyxCqx+dq9Ad/HjZW+mj0KKzNLA== Received: from DU2PR04CA0069.eurprd04.prod.outlook.com (2603:10a6:10:232::14) by AM7PR07MB6232.eurprd07.prod.outlook.com (2603:10a6:20b:135::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Mon, 29 Apr 2024 10:02:07 +0000 Received: from DB1PEPF00039231.eurprd03.prod.outlook.com (2603:10a6:10:232:cafe::ed) by DU2PR04CA0069.outlook.office365.com (2603:10a6:10:232::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34 via Frontend Transport; Mon, 29 Apr 2024 10:02:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DB1PEPF00039231.mail.protection.outlook.com (10.167.8.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.19 via Frontend Transport; Mon, 29 Apr 2024 10:02:07 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.66) with Microsoft SMTP Server id 15.2.1544.9; Mon, 29 Apr 2024 12:02:06 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id B50331C006A; Mon, 29 Apr 2024 12:02:06 +0200 (CEST) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?utf-8?q?Morten_Br=C3=B8rup?= , =?utf-8?q?Mattia?= =?utf-8?q?s_R=C3=B6nnblom?= Subject: [RFC v3 3/6] eal: add exactly-once bit access functions Date: Mon, 29 Apr 2024 11:51:35 +0200 Message-ID: <20240429095138.106849-4-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240429095138.106849-1-mattias.ronnblom@ericsson.com> References: <20240425085853.97888-2-mattias.ronnblom@ericsson.com> <20240429095138.106849-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF00039231:EE_|AM7PR07MB6232:EE_ X-MS-Office365-Filtering-Correlation-Id: 5124dfca-bda7-494c-1f61-08dc68336d9f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?utf-8?q?LMTMLkkKVTwIUsYdTFVk4++eIHdC5Mx?= =?utf-8?q?TnC+ZYybsfp1EDYiAg4MVQ8L+JMIl1Dun4zVwTGMRmkyPH1LDLNbgunLU4Z9b6tA9?= =?utf-8?q?UwtIMFwi9bzPGO+vBsJl5qmKSBdP25wktCC5Teux+5fDZOJGDQHx3Mm1AzwRHzRnF?= =?utf-8?q?/lgtBbOJkZxBUr0g5FVxDE4oaN+FV/jSAvAIRYEv+iWgT2q3Goh4SB7YfeGj198cw?= =?utf-8?q?SLFRuVLLJKF8sazj8lyYDCPFplJtP54k/yqgEwbOZUKzDlJhQ3cKSOgl6QO2WxfZo?= =?utf-8?q?Ss/7FKpOAmrUXypwS8ADPS0+i6OrS3KJOnBfPzYsanrv66j8ydH4ihCayCgp83dNN?= =?utf-8?q?Bhf4YDwLkom9+ewspNwlJxSf3Pd3AKTI8NkwNTNtuZe4y67QSso1lJHm8iG4mPzAX?= =?utf-8?q?KzKL4Q3FGfrNYBUfDMITUH6PcoPYVGSXHVBHoWBAWehxE9/CHwWDbEoHDzJ/ixjM6?= =?utf-8?q?ZF2zNEh1dZUtc8M8/7DYH60TRuPh+YbSwnB78DoggY/utLjJC4jHUigOLt0WbpCEq?= =?utf-8?q?mBfxwi0Ww399/7f+FcWp7ZTFL1q08CIRndMj86M7+c75VPtcqnEU567ryIc45AIRR?= =?utf-8?q?clv/3kX2NXlZR4/xH8YG6/BkIzwyyfYG+mg9EirTB7n2ebRDAQaLOpRPCCknTA8LV?= =?utf-8?q?qe4Y/alyZJiIVlnwnmPdg6W7XHhxPOQoqXKayoR0oR3Hrn026fSAETX03snHpno2Q?= =?utf-8?q?9ALPNTsCpEsPp2DG067CBRfGr07hz5tYc5I3LYmoUMWAZhorUx4umpaS95UKEDFZ1?= =?utf-8?q?uGy8uIdSvL0WlAX3jPO5Gl/O10pbpdyU+9+8ztOj6HK6EfV/cFPvC+jX12smqVgGa?= =?utf-8?q?vzWdulE/7r3PlGCPX0s5Y4Q7qUqR9W06hA0QGGqifD7BCKcIkhB9ujUd5GTEN869R?= =?utf-8?q?Ho1g4rhBcwSy1xe/JVflL/s3fQwcXie8yR07m7HF8Y5KuEL6pBLSRN7SdGRWlA2rb?= =?utf-8?q?0L8ypWBN9aq2a22DhFbat4mGsk4yRrvpSSlZWCKs0ZbPl7zyaUJBUthg9bZieNf+5?= =?utf-8?q?rWqEPP+caPZBEGf4KSdPG9nKvw1Cr2Nslk/2Vvix5LxGk4h0yjSrtR00f+anS/hST?= =?utf-8?q?LYAEzICsZrxcAwG+q3Tx7pBZgUpQQbe6GfFAynqMXy0rLlrbCiNq9hG/F0HlVDHVI?= =?utf-8?q?h5umcT2Tp4WztpRmpGTuLAWM286rB6FBqj0dj5SmrRd5rRgWvBD1tt/22DFBye5j0?= =?utf-8?q?oOMoCiVjQKUB2GWdV2S0H3o3urHICBWFup6kQ0Q1U88u9SKlK+KgAuAKobH8VaVpd?= =?utf-8?q?3X23Dyx/XWv1W9qEK3wpC/PEcaJsUohHJ3sc1oWci/jgh2nKLLLyO4FCuRMCjT7HO?= =?utf-8?q?NaVd2hYEG7fx?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 10:02:07.0595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5124dfca-bda7-494c-1f61-08dc68336d9f X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00039231.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6232 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add bit test/set/clear/assign functions which prevents certain compiler optimizations and guarantees that program-level memory loads and/or stores will actually occur. These functions are useful when interacting with memory-mapped hardware devices. The "once" family of functions does not promise atomicity and provides no memory ordering guarantees beyond the C11 relaxed memory model. RFC v3: * Work around lack of C++ support for _Generic (Tyler Retzlaff). Signed-off-by: Mattias Rönnblom --- lib/eal/include/rte_bitops.h | 180 +++++++++++++++++++++++++++++++++++ 1 file changed, 180 insertions(+) diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index fb2e3dae7b..eac3f8b86a 100644 --- a/lib/eal/include/rte_bitops.h +++ b/lib/eal/include/rte_bitops.h @@ -201,6 +201,147 @@ extern "C" { uint32_t *: __rte_bit_assign32, \ uint64_t *: __rte_bit_assign64)(addr, nr, value) +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Generic selection macro to test exactly once the value of a bit in + * a 32-bit or 64-bit word. The type of operation depends on the type + * of the @c addr parameter. + * + * This function is guaranteed to result in exactly one memory load + * (e.g., it may not be eliminate or merged by the compiler). + * + * \code{.c} + * rte_bit_once_set(addr, 17); + * if (rte_bit_once_test(addr, 17)) { + * ... + * } + * \endcode + * + * In the above example, rte_bit_once_set() may not be removed by + * the compiler, which would be allowed in case rte_bit_set() and + * rte_bit_test() was used. + * + * \code{.c} + * while (rte_bit_once_test(addr, 17); + * ; + * \endcode + * + * In case rte_bit_test(addr, 17) was used instead, the resulting + * object code could (and in many cases would be) replaced with + * the equivalent to + * \code{.c} + * if (rte_bit_test(addr, 17)) { + * for (;;) // spin forever + * ; + * } + * \endcode + * + * rte_bit_once_test() does not give any guarantees in regards to + * memory ordering or atomicity. + * + * The regular bit set operations (e.g., rte_bit_test()) should be + * preferred over the "once" family of operations (e.g., + * rte_bit_once_test()) if possible, since the latter may prevent + * optimizations crucial for run-time performance. + * + * @param addr + * A pointer to the word to query. + * @param nr + * The index of the bit. + * @return + * Returns true if the bit is set, and false otherwise. + */ + +#define rte_bit_once_test(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_test32, \ + uint64_t *: __rte_bit_once_test64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Set bit in word exactly once. + * + * Set bit specified by @c nr in the word pointed to by @c addr to '1' + * exactly once. + * + * This function is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit set operation. + * + * See rte_bit_test_once32() for more information and uses cases for + * the "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ +#define rte_bit_once_set(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_set32, \ + uint64_t *: __rte_bit_once_set64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Clear bit in word exactly once. + * + * Set bit specified by @c nr in the word pointed to by @c addr to '0' + * exactly once. + * + * This function is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit clear operation. + * + * See rte_bit_test_once32() for more information and uses cases for + * the "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ +#define rte_bit_once_clear(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_clear32, \ + uint64_t *: __rte_bit_once_clear64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Assign a value to bit in a word exactly once. + * + * Set bit specified by @c nr in the word pointed to by @c addr to the + * value indicated by @c value exactly once. + * + * This function is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit clear operation. + * + * This function does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + * @param value + * The new value of the bit - true for '1', or false for '0'. + */ +#define rte_bit_once_assign(addr, nr, value) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_assign32, \ + uint64_t *: __rte_bit_once_assign64)(addr, nr, value) + #define __RTE_GEN_BIT_TEST(name, size, qualifier) \ static inline bool \ name(const qualifier uint ## size ## _t *addr, unsigned int nr) \ @@ -239,6 +380,14 @@ __RTE_GEN_BIT_TEST(__rte_bit_test64, 64, ) __RTE_GEN_BIT_SET(__rte_bit_set64, 64, ) __RTE_GEN_BIT_CLEAR(__rte_bit_clear64, 64, ) +__RTE_GEN_BIT_TEST(__rte_bit_once_test32, 32, volatile) +__RTE_GEN_BIT_SET(__rte_bit_once_set32, 32, volatile) +__RTE_GEN_BIT_CLEAR(__rte_bit_once_clear32, 32, volatile) + +__RTE_GEN_BIT_TEST(__rte_bit_once_test64, 64, volatile) +__RTE_GEN_BIT_SET(__rte_bit_once_set64, 64, volatile) +__RTE_GEN_BIT_CLEAR(__rte_bit_once_clear64, 64, volatile) + __rte_experimental static inline void __rte_bit_assign32(uint32_t *addr, unsigned int nr, bool value) @@ -259,6 +408,27 @@ __rte_bit_assign64(uint64_t *addr, unsigned int nr, bool value) __rte_bit_clear64(addr, nr); } + +__rte_experimental +static inline void +__rte_bit_once_assign32(uint32_t *addr, unsigned int nr, bool value) +{ + if (value) + __rte_bit_once_set32(addr, nr); + else + __rte_bit_once_clear32(addr, nr); +} + +__rte_experimental +static inline void +__rte_bit_once_assign64(volatile uint64_t *addr, unsigned int nr, bool value) +{ + if (value) + __rte_bit_once_set64(addr, nr); + else + __rte_bit_once_clear64(addr, nr); +} + /*------------------------ 32-bit relaxed operations ------------------------*/ /** @@ -953,6 +1123,11 @@ rte_log2_u64(uint64_t v) #undef rte_bit_clear #undef rte_bit_assign +#undef rte_bit_once_test +#undef rte_bit_once_set +#undef rte_bit_once_clear +#undef rte_bit_once_assign + #define __RTE_BIT_OVERLOAD_SZ_2(fun, qualifier, size, arg1_type, arg1_name) \ static inline void \ rte_bit_ ## fun(qualifier uint ## size ## _t *addr, \ @@ -1001,6 +1176,11 @@ __RTE_BIT_OVERLOAD_2(set, , unsigned int, nr) __RTE_BIT_OVERLOAD_2(clear, , unsigned int, nr) __RTE_BIT_OVERLOAD_3(assign, , unsigned int, nr, bool, value) +__RTE_BIT_OVERLOAD_2R(once_test, const volatile, bool, unsigned int, nr) +__RTE_BIT_OVERLOAD_2(once_set, volatile, unsigned int, nr) +__RTE_BIT_OVERLOAD_2(once_clear, volatile, unsigned int, nr) +__RTE_BIT_OVERLOAD_3(once_assign, volatile, unsigned int, nr, bool, value) + #endif #endif /* _RTE_BITOPS_H_ */