From patchwork Thu May 2 21:31:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 139823 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D870943F6C; Thu, 2 May 2024 23:37:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53C5D40A6C; Thu, 2 May 2024 23:36:46 +0200 (CEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id B2F8340633 for ; Thu, 2 May 2024 23:36:36 +0200 (CEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6ed01c63657so8113528b3a.2 for ; Thu, 02 May 2024 14:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714685796; x=1715290596; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pBUTB7LGR7a993dAW8ThIQSZmRdd6JCQSUmUkmSqdo8=; b=PlrMuUN+Xwvq9jrpOSU+dUUElp5ck945vIPbOq3TUWTUvcku0BLJxKvLFyK+RkvZcu VDQhL/lKr/kHElpZyKmixTzj4Px3RSKgiijpG/rZ5mzADU1VegK+R2Avwd3Q1LyDfg62 WliYJkWs+IsEOtqnxJrIKfBbbUdKF2guEgedXnCW+qVLpZmk/WB8rYfYRNKnlnz0emFQ FmHUuuRWSW8mpyuuY/iuVegHcip0N9CmMe4IcqOHCTBVNFQ7h0Uo0GJSFb4YEAx3JSLb rpnULyL+p43VZFQT885C52SNvhsMdUmoZj6qzHIYzbwrwV/WWofPsB1taYOTzirGrX7B ZvBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714685796; x=1715290596; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pBUTB7LGR7a993dAW8ThIQSZmRdd6JCQSUmUkmSqdo8=; b=O1qfcTdBnCDX60fieyrldRxLBNF8YqEhUnaQmJjVltxeyLPH3LHAjKH0xW6P/Cjj1c LBT946ySAHYuXJ/4cAHZgLdSt/qp3FcZex6TwH3M0Tw7TnwTj8rYmgKirVaQ6PPO3P4P nVLvmngRUqHlInNHhm7L6XTN2hneVEFXGuJ+sgdrsfQQd1+1fgeCYKBrSQzwOzEjCRrK 9VU5Wpog2OAptoM8MvRlZRuw6xVQ2isUq4zKw+UnvXqe/AyRcIELiGgtI7VhBSyb5sjN l5QZ1znFfIslsADEQBQgMdp5AMd/POy7b2yxOYHolc+PFMk9XJBUJN2JLfNIj4IlamOI JDcw== X-Gm-Message-State: AOJu0YwB18FcmseM5OqQibZOkik05sseiHBT19We9XwSaAbZ/6WhxePR iQUUsu6AOVk0W8kYO6rmOJiVGe/6iOsVQG5P+kBbh4BVK20+6pB9VdSCk0berWMTexKCIPwE4N4 GYZfscw== X-Google-Smtp-Source: AGHT+IHfpSafloeZT8mvhK4VwTumnxrM6EYBpYZprvfrIpV/Hv1UqBG9HhsaklYXDWrOGN4HLEM8BQ== X-Received: by 2002:a05:6a00:17a7:b0:6ea:bb66:9448 with SMTP id s39-20020a056a0017a700b006eabb669448mr1067598pfg.22.1714685795834; Thu, 02 May 2024 14:36:35 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id f14-20020a056a001ace00b006f3eee787d5sm1804829pfv.18.2024.05.02.14.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 14:36:35 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v12 10/12] net/tap: remove extraneous newlines Date: Thu, 2 May 2024 14:31:46 -0700 Message-ID: <20240502213618.11391-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240502213618.11391-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Some log messages contained extra newlines. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 3614aaf1dc..2484a82ccb 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -235,9 +235,8 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) flags = fcntl(fd, F_GETFL); if (flags == -1) { - TAP_LOG(WARNING, - "Unable to get %s current flags\n", - ifr.ifr_name); + TAP_LOG(WARNING, "Unable to get %s current flags: %s", + ifr.ifr_name, strerror(errno)); goto error; } @@ -279,7 +278,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) if (sigaction(signo, &sa, NULL) == -1) { TAP_LOG(WARNING, - "Unable to set rt-signal %d handler\n", signo); + "Unable to set rt-signal %d handler", signo); goto error; } @@ -290,11 +289,11 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) } if (signo == SIGRTMAX) { - TAP_LOG(WARNING, "All rt-signals are in use\n"); + TAP_LOG(WARNING, "All rt-signals are in use"); /* Disable trigger globally in case of error */ tap_trigger = 0; - TAP_LOG(NOTICE, "No Rx trigger signal available\n"); + TAP_LOG(NOTICE, "No Rx trigger signal available"); } else { /* Enable signal on file descriptor */ if (fcntl(fd, F_SETSIG, signo) < 0) { @@ -920,7 +919,7 @@ tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void } process_private = dev->process_private; - TAP_LOG(DEBUG, "tap_attach q:%d\n", request_param->q_count); + TAP_LOG(DEBUG, "tap_attach q:%d", request_param->q_count); for (int q = 0; q < request_param->q_count; q++) process_private->fds[q] = request->fds[q]; @@ -1463,7 +1462,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) if (ret < 0 || ret >= (int)sizeof(pool_name)) { TAP_LOG(ERR, "%s: failed to create mbuf pool name for device %s," - "device name too long or output error, ret: %d\n", + "device name too long or output error, ret: %d", pmd->name, dev->device->name, ret); return -ENAMETOOLONG; } @@ -1473,7 +1472,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) SOCKET_ID_ANY); if (!pmd->gso_ctx_mp) { TAP_LOG(ERR, - "%s: failed to create mbuf pool for device %s\n", + "%s: failed to create mbuf pool for device %s", pmd->name, dev->device->name); return -1; }