From patchwork Mon May 6 11:44:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 139884 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB7DC43FB4; Mon, 6 May 2024 13:45:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29BFB4068A; Mon, 6 May 2024 13:44:57 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2067.outbound.protection.outlook.com [40.107.244.67]) by mails.dpdk.org (Postfix) with ESMTP id 38E75402F1 for ; Mon, 6 May 2024 13:44:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fqq8nRawxhKnuS87h8zMCQC8ZHPF7ZzaAuCRHh1gJtuskCYnU97J/UJoCUnEQ8K5T4a5x9nVXxUG2Xvk1S0yDgXm41AzlHTnHRGc2p4jV/fnCB0AjqrAdSAnGT4BUmP7h6GMUFx22MJKHNC6+UNzSw7R74S7CjiY0z9njUvUA7qejZe6Iwz0g77hlM/AwrPIYELX/xQxYlumveq/9uvi1uABeQgPaetefF9kYQG8N9wZeCxYpxSbGW3vgGE0buoeElTSOuY8E5qd37pQ8earmlu507kzLYGcjssT1rSz0FWE/crp8RFW81pVfqyQRU3VTYMHRTTYkL3MBaucyD/xRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=DX0bwOqC11FRCKlNrt08EvZjJLZk1dl7dgKDFxnVzl/i0AvikFO6iIz+Wuk+ogXBxGiqN9A21TSfYsi5SqwVHCUDP/QyUH0/fdFTJBPPj7poGkaFynRAl1VIHCJQHmw1UE5JhM9e+TVK3txOhNC5E2V97manlpSrKBTR52JLgKJD15ODldkWxet90SrNYK7xEww916nvqdjuZ/d//IokPJLQrLv7c0G6kB/x9ONkHW4CqS5lwh14oT1gRMcJWOr9izz0f218sGExzImyS4K76y5LGra5imclwVWsD7iQliANl2rV52KcLo6+UcAabf9zzWWq+JgdWF8Cxpssduf9Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dg8CYyZLCYkg9LxB3PxgWsBz7NUD10OcQyeraMVBi9E=; b=OBMCijqHE8LCv7yUY2F0v7ACPAgwX2FMQKQJKc91SdM1Uvgk0ZVYfFC+E6cmYiSa9tSyiVENzbfpYy8A71strxwYJRu8VauTsUVXE228GpKg9o1vfpp1EKIqOSRmhlvNmxGv6C3+7qIf1I6VeLXFGd+/lwtf/Xt2FvIDqNVWOfnHUJE4ZPcGe8/7608q0qgaqKE24Znp1r2tbJUIzJn3cLWuKYUoni3cNLPWY8XbHQgDw9ct/941m45IHSyZN+FLnM3fKa0HbuV/OTVHHrQYvwgfTHaBmr7KVYkPLNoJmkId9bPUxAzfF7ahKRPC30Ea5ux9yHl/m5MwGTXfCEqyHg== Received: from PH8PR05CA0020.namprd05.prod.outlook.com (2603:10b6:510:2cc::27) by SJ1PR12MB6100.namprd12.prod.outlook.com (2603:10b6:a03:45d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 11:44:52 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:510:2cc:cafe::54) by PH8PR05CA0020.outlook.office365.com (2603:10b6:510:2cc::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Mon, 6 May 2024 11:44:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 11:44:51 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:44 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 6 May 2024 04:44:43 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 6 May 2024 04:44:41 -0700 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: Subject: [v2 05/16] net/mlx5/hws: negating rte errno on rule creation failure Date: Mon, 6 May 2024 14:44:08 +0300 Message-ID: <20240506114419.966498-5-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240506114419.966498-1-igozlan@nvidia.com> References: <20240314114220.203241-1-igozlan@nvidia.com> <20240506114419.966498-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|SJ1PR12MB6100:EE_ X-MS-Office365-Filtering-Correlation-Id: c0c39298-8211-4166-dedc-08dc6dc1f0fb X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017|921011; X-Microsoft-Antispam-Message-Info: TfL0VoxEVzFtuaYrOuWUe9rM02IRL+yTyow1SkuZYjYhA38l2tk6Wfy1PmhsyXikjx0uf+twi7eqUG9lFSXeixTCsL2T84xaznbhVdod+mA3eYDxmeqQiBeXa8h4yohVhoxpDMj5q2FlxxsXtG8RT6zsmkgNWg1d/LB7xvM2/AdMYEtUxpSWm+JtkLCTsfcBmKT9DLwEwK/qn+yjknWakFOwNde2UfHGJdmmTvHY0TMYlagk34feYhT3LAgaARlxEtS3plNx3hoRMticPoWCATlkSC+2VwleptINxnQ+5avUZOW6IaKPpvqEVfak+ux/ulG3/vxQtHFZdLmz9iVOlCVi6/nEA2I4hoou5Fy85D0gih19PQieSVa47vrM3LRNwYfh2La00cQ4+CKEYMdOAlQ5Ov6Kf6SFsZRrwL8ZbROte9VKFuT+rXZ2DG0B2H+4lQflCXSXblRHu6KbOFbVqZ+vK82mP6ABlkP1KbMoVsdaHl90HeGZfiPMZPUSD8oKGS94M6VOlrqyZANYHqT2xZzZd72+IhHd4eytcSkC/ZWsil+aGa3n5HCDlERkEOTJ59XdAe8XJk71/xjHpuEeSGJIXjh+KSTgSea8qAaayA3scYmA47HoilCYHWzgP5urx9oFUAvETMPNKjK+WRiQbvVvHljtpItsjKuQVF2BHso0+pzgxoXNi0n9JCcpbwBDOXND/T0ooowghJVYVbeniAo71OeMtYwFgnqLN78qf/Cr6yHEE6Mu2o36Y2fBXlJ3VD3szqf1OL/m/op2Zn95ZkxeKuojVnGAM5ttHrd23IGxBMRxizIWnbliH7j0PUOJjfGfyJadW2JyoeM83atvlbeFFWFHfUQbfC9VEIWH3MXLqXEtqNsx1/jJY1Rez8CfbJ7S6UXqWQ2J9PoC2yQCZDrebwjTjOSvZY6YuGPkHKtB7lPuLkjIp/ot+AkJjVY3uJPjBombU1uToEX/oGWBgCxTnNsEdP/ehbqzripjCT1ToRbPnAK3n2XTHvotz+wa6yXATt5//j9PWRo2n/Ff76OBTAQb/06mPWlK1m6EUMqcQxiY8ceZ9wnDL1gt/6a0kLGqbcxwRgDp4+0SBQi5/RiXDGrFbwaQuUZ/q1FKmy3or+BbHQdq+ILEsity/1NFrkewnLI2RBwtIGVygWk/9TJfSxY92v9QQ9IfkpfipKFzaKTgCQxBWW1Jx5YwmzIH0WeXRklp7sEfua1LSekaFciBGX2r44+itnh/oTW4PRFsYihneSRA3Ca/VEnfL9Qtn8Den9yakfKTJcSbFJVPQNGdBSaeoTpFlnSU5DQ1slOkfnFD0PnC7bAso9JBQIfJtF2WY0t6C6KsiNNwQRuo4h73kGDqIEzKPIMwws29nm9vr1tY6HE/YQQXq7yGu90E X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017)(921011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 11:44:51.7828 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0c39298-8211-4166-dedc-08dc6dc1f0fb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Yevgeny Kliteynik mlx5dr_rule_create returns -ret, so internal functions should return rte_errno on failure. Fix return values of the function that creates rule in root table. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index f14e1e6ecd..7bcf2de55f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -733,7 +733,7 @@ static int mlx5dr_rule_create_root(struct mlx5dr_rule *rule, free_attr: simple_free(attr); - return -rte_errno; + return rte_errno; } static int mlx5dr_rule_destroy_root(struct mlx5dr_rule *rule,