From patchwork Tue May 14 20:14:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Spewock X-Patchwork-Id: 140121 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC8004402B; Tue, 14 May 2024 22:15:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CB9940608; Tue, 14 May 2024 22:15:07 +0200 (CEST) Received: from mail-pg1-f226.google.com (mail-pg1-f226.google.com [209.85.215.226]) by mails.dpdk.org (Postfix) with ESMTP id C5D2B402EB for ; Tue, 14 May 2024 22:15:05 +0200 (CEST) Received: by mail-pg1-f226.google.com with SMTP id 41be03b00d2f7-5f415fd71f8so4682331a12.3 for ; Tue, 14 May 2024 13:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1715717705; x=1716322505; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MvFGL8WBsjoDVlBxmU+Bv3MADnwlrIBrEUarWOJ4S9g=; b=DHLMhmfJaUcHUlf2tX5CxjVm0gYwzTO/NvUpfWa+a6Tj15PR4eguGQthSGYFjhX0XC GjMjrPOFRGOucTyONGNKuzGO3Il0FV9VUONqSUU778vB0nBE7/J+ruW+f6l7rioqMoyy Rb9UnF6tDfprZ+slrZpJMNaZ7Xc/6Pg8C5CNs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715717705; x=1716322505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MvFGL8WBsjoDVlBxmU+Bv3MADnwlrIBrEUarWOJ4S9g=; b=q2JonthumKGnxeRqG4BqpY1yBNuIpX4PQcgYpXA5SxKjv9fAb8nBP275LKt+ob0ZUt 4qCe7+M6wnMEER+hW9ik2x1KKIRTBrrigYug9wH5T1Oa0q/nNl1miBqUSj0Osr5F4OP5 zrf8ghGs9hCWNUThbpfbYVU/Cahy7WELO9HZdC50jdSCEOTYQHPX14lIs6hBw9BYUG4C Mk/CC6yimtpAVCvDHW86f9IbjaQZNHem9MFWJXm9+p5Se1LtwnQEzVTS0iZymXZ146f4 9YThErWZTC/Bqrf6DUjfF1Bdr4G6LlZwVjlUq+kmECN6DJJXVL3xPSfeIJffp7ynXPVj XCJw== X-Gm-Message-State: AOJu0YzxtVMc7JaYceCCCEDR40yDRMTvojTs8XDmJFiYBM0iyutR7NiA sEj8fa2ltnuRZ75KQ97lovndhoRNKuYjbenZsGzeohpeSeA/smrODa4LIPDFv7ZyBZGL2IeMYYm m2x+F0RDVtp3f6rR6cFgU8uKgRtyl+vog X-Google-Smtp-Source: AGHT+IFw8p6qOy06wPqnXRI6CF5KRsJSd2UgjEVuax9MsnnfW/mcoNrkUC5jzfYrrkZxYAE8JLDZholQtOOB X-Received: by 2002:a17:90a:bb89:b0:2b9:c7ad:c99f with SMTP id 98e67ed59e1d1-2b9c7adca08mr427528a91.9.1715717704957; Tue, 14 May 2024 13:15:04 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-1ef0b9cce37sm3890935ad.20.2024.05.14.13.15.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2024 13:15:04 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f]) by postal.iol.unh.edu (Postfix) with ESMTP id 014EF605C373; Tue, 14 May 2024 16:15:04 -0400 (EDT) From: jspewock@iol.unh.edu To: yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, thomas@monjalon.net Cc: dev@dpdk.org, Jeremy Spewock Subject: [PATCH v1 3/4] dts: add methods for modifying MTU to testpmd shell Date: Tue, 14 May 2024 16:14:35 -0400 Message-ID: <20240514201436.2496-4-jspewock@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240514201436.2496-1-jspewock@iol.unh.edu> References: <20240514201436.2496-1-jspewock@iol.unh.edu> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there needs to be a way to modify the value while bound to said driver as well. This is done by using testpmd to modify the MTU. Signed-off-by: Jeremy Spewock Reviewed-by: Patrick Robb --- dts/framework/remote_session/testpmd_shell.py | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index 33b3e7c5a3..4e608998f9 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -227,6 +227,74 @@ def set_forward_mode(self, mode: TestPmdForwardingModes, verify: bool = True): f"Test pmd failed to set fwd mode to {mode.value}" ) + def _stop_port(self, port_id: int, verify: bool = True) -> None: + """Stop port `port_id` in testpmd. + + Depending on the PMD, the port may need to be stopped before configuration can take place. + This method wraps the command needed to properly stop ports and take their link down. + + Args: + port_id: ID of the port to take down. + verify: If :data:`True` the output will be scanned in an attempt to verify that the + stopping of ports was successful. Defaults to True. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:'True` and the port did not + successfully stop. + """ + stop_port_output = self.send_command(f"port stop {port_id}") + if verify and ("Done" not in stop_port_output): + self._logger.debug(f"Failed to stop port {port_id}. Output was:\n{stop_port_output}") + raise InteractiveCommandExecutionError(f"Test pmd failed to stop port {port_id}.") + + def _start_port(self, port_id: int, verify: bool = True) -> None: + """Start port `port_id` in testpmd. + + Because the port may need to be stopped to make some configuration changes, it naturally + follows that it will need to be started again once those changes have been made. + + Args: + port_id: ID of the port to start. + verify: If :data:`True` the output will be scanned in an attempt to verify that the + port came back up without error. Defaults to True. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the port did not come + back up. + """ + start_port_output = self.send_command(f"port start {port_id}") + if verify and ("Done" not in start_port_output): + self._logger.debug(f"Failed to start port {port_id}. Output was:\n{start_port_output}") + raise InteractiveCommandExecutionError(f"Test pmd failed to start port {port_id}.") + + def set_port_mtu(self, port_id: int, mtu: int, verify: bool = True) -> None: + """Change the MTU of a port using testpmd. + + Some PMDs require that the port be stopped before changing the MTU, and it does no harm to + stop the port before configuring in cases where it isn't required, so we first stop ports, + then update the MTU, then start the ports again afterwards. + + Args: + port_id: ID of the port to adjust the MTU on. + mtu: Desired value for the MTU to be set to. + verify: If `verify` is :data:`True` then the output will be scanned in an attempt to + verify that the mtu was properly set on the port. Defaults to True. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the MTU was not + properly updated on the port matching `port_id`. + """ + self._stop_port(port_id, verify) + set_mtu_output = self.send_command(f"port config mtu {port_id} {mtu}") + self._start_port(port_id, verify) + if verify and (f"MTU: {mtu}" not in self.send_command(f"show port info {port_id}")): + self._logger.debug( + f"Failed to set mtu to {mtu} on port {port_id}." f" Output was:\n{set_mtu_output}" + ) + raise InteractiveCommandExecutionError( + f"Test pmd failed to update mtu of port {port_id} to {mtu}" + ) + def _close(self) -> None: """Overrides :meth:`~.interactive_shell.close`.""" self.send_command("quit", "")