From patchwork Tue May 14 20:14:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Spewock X-Patchwork-Id: 140122 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCD344402B; Tue, 14 May 2024 22:15:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9510540693; Tue, 14 May 2024 22:15:08 +0200 (CEST) Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) by mails.dpdk.org (Postfix) with ESMTP id 5395C402EC for ; Tue, 14 May 2024 22:15:07 +0200 (CEST) Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-1ed904c2280so32021505ad.2 for ; Tue, 14 May 2024 13:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1715717706; x=1716322506; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LAUPBkQJvt7S4aewCgi4DDmdlyGjSpBEjEZoeoR3lYc=; b=fBkkgtLyNYgs+em/slme4K4iCRJu4rHttVK1aXMNvQki57XS8FeUKaCcSsvFoMnsR9 95V2uMnkqY0oooD83wWAvyW4WvJiP2MnHilVJ3slmMEF+SbUU43+/l+t5HCoQ0H3gaxm xOdyvpRqTnywORGs9V265vyXyiaGMMxb3/uPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715717706; x=1716322506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LAUPBkQJvt7S4aewCgi4DDmdlyGjSpBEjEZoeoR3lYc=; b=cgIJUloIX5ppbuZfMwLGTgW0v+gAq4CY6l36+WlYhiJi02t8zy3z6DYi0FO/9+bUEk jmWiRyPs2lcuQzsbdIs0av84fob+tS8BenG4uClWIwF55QR4O/ps9lW9jRMUT0IR08R+ nxrz1liYdTNLEkCaa1royAFKVqLv6WGbppWLN/dcgf35k96wANK8hZ/A/JWuXerf8/3+ 1hItw3VrxV3CaFND0gzo4RhddUm1O1Lvjh5Xn9K9nIcafhtvyuFCTOkpyPAt7Yf+vX3q utXHA3GjdOR6ttecvAGzZ4je5/2OMBGCKaOZbxYdz81f73GD3ih31ahOPW3MBsFRwgE7 Ms9Q== X-Gm-Message-State: AOJu0YzwDSo0mPZ/U7+g++K44HYfuu4bs7TXKNrbayMP8w33MgI9TtBU ZwXdOI819zZswYEyn9eQ1cENHxPhXvTxAtGuixkJgA28BHscPZ7+ND5cD7le0aouTdEnlZ5AgGc bhJnF1GR7cqvjnLBIIdrf4CPHg2+j8wauSt2Qwp56APLvQ6rt X-Google-Smtp-Source: AGHT+IHSlOEw+X8lWObTASRN2BeaSlGiHUNpHaI1urC2s9NJpQPuwlw4deIPxIBF6tdSAWMIbCRik/8XwGTf X-Received: by 2002:a17:902:d64a:b0:1e7:eeb3:e295 with SMTP id d9443c01a7336-1ef4404cc0emr123811795ad.69.1715717706518; Tue, 14 May 2024 13:15:06 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-1ef0c02e585sm3722345ad.128.2024.05.14.13.15.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2024 13:15:06 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f]) by postal.iol.unh.edu (Postfix) with ESMTP id AD472605C373; Tue, 14 May 2024 16:15:05 -0400 (EDT) From: jspewock@iol.unh.edu To: yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, thomas@monjalon.net Cc: dev@dpdk.org, Jeremy Spewock Subject: [PATCH v1 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter Date: Tue, 14 May 2024 16:14:36 -0400 Message-ID: <20240514201436.2496-5-jspewock@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240514201436.2496-1-jspewock@iol.unh.edu> References: <20240514201436.2496-1-jspewock@iol.unh.edu> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jeremy Spewock Some NICs tested in DPDK allow for the scattering of packets without an offload and others enforce that you enable the scattered_rx offload in testpmd. The current version of the suite for testing support of scattering packets only tests the case where the NIC supports testing without the offload, so an expansion of coverage is needed to cover the second case as well. depends-on: patch-139227 ("dts: skip test cases based on capabilities") Signed-off-by: Jeremy Spewock --- dts/tests/TestSuite_pmd_buffer_scatter.py | 49 ++++++++++++++++++----- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSuite_pmd_buffer_scatter.py index 41f6090a7e..6d04663c8a 100644 --- a/dts/tests/TestSuite_pmd_buffer_scatter.py +++ b/dts/tests/TestSuite_pmd_buffer_scatter.py @@ -16,14 +16,19 @@ """ import struct +from typing import ClassVar from scapy.layers.inet import IP # type: ignore[import] from scapy.layers.l2 import Ether # type: ignore[import] from scapy.packet import Raw # type: ignore[import] from scapy.utils import hexstr # type: ignore[import] -from framework.remote_session.testpmd_shell import TestPmdForwardingModes, TestPmdShell -from framework.test_suite import TestSuite +from framework.remote_session.testpmd_shell import ( + NicCapability, + TestPmdForwardingModes, + TestPmdShell, +) +from framework.test_suite import TestSuite, requires class TestPmdBufferScatter(TestSuite): @@ -48,6 +53,14 @@ class TestPmdBufferScatter(TestSuite): and a single byte of packet data stored in a second buffer alongside the CRC. """ + #: Parameters for testing scatter using testpmd which are universal across all test cases. + base_testpmd_parameters: ClassVar[list[str]] = [ + "--mbcache=200", + "--max-pkt-len=9000", + "--port-topology=paired", + "--tx-offloads=0x00008000", + ] + def set_up_suite(self) -> None: """Set up the test suite. @@ -91,7 +104,7 @@ def scatter_pktgen_send_packet(self, pktsize: int) -> str: return load - def pmd_scatter(self, mbsize: int) -> None: + def pmd_scatter(self, mbsize: int, testpmd_params: list[str]) -> None: """Testpmd support of receiving and sending scattered multi-segment packets. Support for scattered packets is shown by sending 5 packets of differing length @@ -103,17 +116,14 @@ def pmd_scatter(self, mbsize: int) -> None: """ testpmd_shell = self.sut_node.create_interactive_shell( TestPmdShell, - app_parameters=( - "--mbcache=200 " - f"--mbuf-size={mbsize} " - "--max-pkt-len=9000 " - "--port-topology=paired " - "--tx-offloads=0x00008000" - ), + app_parameters=" ".join(testpmd_params), privileged=True, ) with testpmd_shell as testpmd: testpmd.set_forward_mode(TestPmdForwardingModes.mac) + # adjust the MTU of the SUT ports + testpmd.set_port_mtu(0, 9000) + testpmd.set_port_mtu(1, 9000) testpmd.start() for offset in [-1, 0, 1, 4, 5]: @@ -127,10 +137,27 @@ def pmd_scatter(self, mbsize: int) -> None: f"{offset}.", ) testpmd.stop() + # reset the MTU of the SUT ports + testpmd.set_port_mtu(0, 1500) + testpmd.set_port_mtu(1, 1500) + @requires(NicCapability.scattered_rx) def test_scatter_mbuf_2048(self) -> None: """Run the :meth:`pmd_scatter` test with `mbsize` set to 2048.""" - self.pmd_scatter(mbsize=2048) + self.pmd_scatter( + mbsize=2048, testpmd_params=[*(self.base_testpmd_parameters), "--mbuf-size=2048"] + ) + + def test_scatter_mbuf_2048_with_offload(self) -> None: + """Run the :meth:`pmd_scatter` test with `mbsize` set to 2048 and rx_scatter offload.""" + self.pmd_scatter( + mbsize=2048, + testpmd_params=[ + *(self.base_testpmd_parameters), + "--mbuf-size=2048", + "--enable-scatter", + ], + ) def tear_down_suite(self) -> None: """Tear down the test suite.