From patchwork Tue May 21 17:06:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 140207 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F01B44408C; Tue, 21 May 2024 19:08:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B768640693; Tue, 21 May 2024 19:08:00 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 6E11D40693 for ; Tue, 21 May 2024 19:07:59 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1ed012c1afbso326565ad.1 for ; Tue, 21 May 2024 10:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716311278; x=1716916078; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AGpJg+nlLFbo4O33x+kIoz4PhRIXH2wjGYgnST2anU0=; b=Ogw58ESSUh/E7zaI9lvFZKb7OMb/3LalIZ/ZxLVVOGPN++u03XZn0WreJcthyDgsC5 049l2DOT8ryCbVRi6AnIxwcdDSkhTNDKAjfUGHRT5KnyJ9x9HvqSH8ORYTxPPhmyycfQ j7qv2KLyYG3r0PwyBMu+FG8SUEelGa6qrh/ve4T3IiTYK3ctLIbzIMiOScUm8p+6oTdk w0jg9wLyN7sqLmmlV2qyq6F7UfsoFKMdwRSUVdGNFQpMzc6S5v+B3R8+3r8FLA+q9lBI SgV3xyhB/US13oXf1nomv9VheByoGP6YbXQtU72045OWymo4cBeV/qGtSJ9jizTLu2+o T/2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716311278; x=1716916078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AGpJg+nlLFbo4O33x+kIoz4PhRIXH2wjGYgnST2anU0=; b=beBtc8zePbEj+UVjbL/mPz4vSvJbLUprDhsS8MkIz+SLHoDeh0AlxwoCvaa3MxtAvi V7TtNKIhxwxkoZ8Vr3gTXN6upG1PNAHz3So9ncM9+RBVkalGgKWRa++gmlr2pP33Gdzk xG152FcG08F6dlKd4xPSDNTDUIWBAxmzqmu5YtSDyiaCSth/qqlfnSJxtkcz2SZHdAjy shwb7k3dahOw+NZyZ3JRP/jsrYDAQBWYytqyLPHxgSBLtfhdLbmk3JH8hp5RtYRpghi9 WapiLB4QIebc08SxM/kC7hCmboxs+s6b6A93xdJifV1XyTtw9QguYZRgAhCQsgsrBzax v+zw== X-Gm-Message-State: AOJu0Yz80w/6HiyHM7rTd6Sh6PBF2MbY0/eon08q7LFBVsd/zxlv4wQq jV5YnNYBQJoRYfoQS+ehlMtuXlfw3WxIFmNbVT4JgbCJs3ZvyNbLfn19yvFukbSasSWnndQ8p5w s X-Google-Smtp-Source: AGHT+IEN3lyY8JoP+puixlnMv5jgXD1HhJLAfYBNgJ6D+GHfnvvzfDAmfVB0NGGCgtRKmgabe5RRMw== X-Received: by 2002:a17:902:f552:b0:1f3:137a:37ad with SMTP id d9443c01a7336-1f3137a3af2mr14905645ad.26.1716311277890; Tue, 21 May 2024 10:07:57 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2af52b4sm21634041b3a.174.2024.05.21.10.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 10:07:57 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ferruh Yigit Subject: [PATCH v14 01/11] net/tap: fix fd check in flow_isolate Date: Tue, 21 May 2024 10:06:01 -0700 Message-ID: <20240521170746.119330-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240521170746.119330-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240521170746.119330-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The check for receive queue fd in flow_isolate is incorrect. If queue has not been setup then fd will be -1 not 0. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/tap_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index fa50fe45d7..79cd6a12ca 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1595,7 +1595,7 @@ tap_flow_isolate(struct rte_eth_dev *dev, * If netdevice is there, setup appropriate flow rules immediately. * Otherwise it will be set when bringing up the netdevice (tun_alloc). */ - if (!process_private->rxq_fds[0]) + if (process_private->rxq_fds[0] == -1) return 0; if (set) { struct rte_flow *remote_flow;