app/eventdev: increase default queue depth for cryptodev

Message ID 20240627051524.1682347-1-asasidharan@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series app/eventdev: increase default queue depth for cryptodev |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Aakash Sasidharan June 27, 2024, 5:15 a.m. UTC
With crypto adapter, larger queue depths are desirable since same queue
could be used from multiple cores at the same time. With devices that
are capable of doing large bursts, larger queues would help in multi
core management of same queue.

Increase default queue depth in cryptodev to cater to such use cases.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
---
 app/test-eventdev/test_perf_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Gujjar, Abhinandan S June 27, 2024, 12:04 p.m. UTC | #1
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

> -----Original Message-----
> From: Aakash Sasidharan <asasidharan@marvell.com>
> Sent: Thursday, June 27, 2024 10:45 AM
> To: Jerin Jacob <jerinj@marvell.com>
> Cc: gakhil@marvell.com; anoobj@marvell.com; vvelumuri@marvell.com;
> asasidharan@marvell.com; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; dev@dpdk.org
> Subject: [PATCH] app/eventdev: increase default queue depth for cryptodev
> 
> With crypto adapter, larger queue depths are desirable since same queue could
> be used from multiple cores at the same time. With devices that are capable of
> doing large bursts, larger queues would help in multi core management of same
> queue.
> 
> Increase default queue depth in cryptodev to cater to such use cases.
> 
> Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> ---
>  app/test-eventdev/test_perf_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-
> eventdev/test_perf_common.c
> index db0f9c1f3b..66d22cd559 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -6,7 +6,7 @@
> 
>  #include "test_perf_common.h"
> 
> -#define NB_CRYPTODEV_DESCRIPTORS 1024
> +#define NB_CRYPTODEV_DESCRIPTORS 4096
>  #define DATA_SIZE		512
>  #define IV_OFFSET (sizeof(struct rte_crypto_op) + \
>  		   sizeof(struct rte_crypto_sym_op) + \
> --
> 2.25.1
  
Jerin Jacob July 2, 2024, 1:55 p.m. UTC | #2
On Thu, Jun 27, 2024 at 5:39 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

Applied to dpdk-next-eventdev/for-main. Thanks



>
> > -----Original Message-----
> > From: Aakash Sasidharan <asasidharan@marvell.com>
> > Sent: Thursday, June 27, 2024 10:45 AM
> > To: Jerin Jacob <jerinj@marvell.com>
> > Cc: gakhil@marvell.com; anoobj@marvell.com; vvelumuri@marvell.com;
> > asasidharan@marvell.com; Gujjar, Abhinandan S
> > <abhinandan.gujjar@intel.com>; dev@dpdk.org
> > Subject: [PATCH] app/eventdev: increase default queue depth for cryptodev
> >
> > With crypto adapter, larger queue depths are desirable since same queue could
> > be used from multiple cores at the same time. With devices that are capable of
> > doing large bursts, larger queues would help in multi core management of same
> > queue.
> >
> > Increase default queue depth in cryptodev to cater to such use cases.
> >
> > Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> > ---
> >  app/test-eventdev/test_perf_common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-eventdev/test_perf_common.c b/app/test-
> > eventdev/test_perf_common.c
> > index db0f9c1f3b..66d22cd559 100644
> > --- a/app/test-eventdev/test_perf_common.c
> > +++ b/app/test-eventdev/test_perf_common.c
> > @@ -6,7 +6,7 @@
> >
> >  #include "test_perf_common.h"
> >
> > -#define NB_CRYPTODEV_DESCRIPTORS 1024
> > +#define NB_CRYPTODEV_DESCRIPTORS 4096
> >  #define DATA_SIZE            512
> >  #define IV_OFFSET (sizeof(struct rte_crypto_op) + \
> >                  sizeof(struct rte_crypto_sym_op) + \
> > --
> > 2.25.1
>
  

Patch

diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
index db0f9c1f3b..66d22cd559 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -6,7 +6,7 @@ 
 
 #include "test_perf_common.h"
 
-#define NB_CRYPTODEV_DESCRIPTORS 1024
+#define NB_CRYPTODEV_DESCRIPTORS 4096
 #define DATA_SIZE		512
 #define IV_OFFSET (sizeof(struct rte_crypto_op) + \
 		   sizeof(struct rte_crypto_sym_op) + \