From patchwork Tue Jul 30 10:03:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakesh Kudurumalla X-Patchwork-Id: 142753 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A57AF456F4; Tue, 30 Jul 2024 13:16:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30AB74025C; Tue, 30 Jul 2024 13:16:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id AF5974025C; Tue, 30 Jul 2024 12:03:45 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46U0TE5m001913; Tue, 30 Jul 2024 03:03:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=t XSG2UHGAxJv8bbWV9DEtMOo375ulMSdf/SDMpSoNms=; b=Tqam4GWhgITXbf+6L +/kSBUwZQfAnz1bTF1hPHfLg9v6ffgcBQCalnnOZa42WrosZeuXNfthDJ5saTlhk nw9FgyvXrn+itCGxzUVupQmFw27SV6aylaHvyk1PeY6iYXw9gjGQMHTT7h0708QB nCXF7MdsU/YEbbWRku7tytHbIuzqe7FtgQ0WTYW3sb70Nlc0/v+MdojZNkyvRwBP J/IRmPCBpi3hpGje9UqM0//cJYQQQY+6NYiq19JQN3RNeROi4/siGznbwWaZXaM/ Wj2tvXHcdqUZVGT8/ltQBoUiorK+7ivAajJpBBtXIqpSzrO4A98fiXOKp8hfv6H9 S/DNA== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 40pnp5hpk0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jul 2024 03:03:42 -0700 (PDT) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 30 Jul 2024 03:03:41 -0700 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Tue, 30 Jul 2024 03:03:41 -0700 Received: from localhost.localdomain (unknown [10.28.36.154]) by maili.marvell.com (Postfix) with ESMTP id 610DC5B692C; Tue, 30 Jul 2024 03:03:38 -0700 (PDT) From: Rakesh Kudurumalla To: , , , CC: , , , "Rakesh Kudurumalla" , Subject: [PATCH v3 1/1] examples/l2fwd-jobstats: fix lock availability Date: Tue, 30 Jul 2024 15:33:35 +0530 Message-ID: <20240730100335.3734796-1-rkudurumalla@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240729061026.3729690-1-rkudurumalla@marvell.com> References: <20240729061026.3729690-1-rkudurumalla@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: Z4bkMdifDt05kakgOiGVT1-w7PfySC67 X-Proofpoint-ORIG-GUID: Z4bkMdifDt05kakgOiGVT1-w7PfySC67 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-30_09,2024-07-26_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch addresses the issue by introducing a delay before acquiring the lock in the loop. This delay allows for better availability of the lock, ensuring that show_lcore_stats() can periodically update the statistics even when forwarding jobs are running. Fixes: 204896f8d66c ("examples/l2fwd-jobstats: add new example") Cc: stable@dpdk.org Signed-off-by: Rakesh Kudurumalla --- v3: updated subject message v2: updated commit description examples/l2fwd-jobstats/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 308b8edd20..7bb38b290f 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -542,7 +542,7 @@ l2fwd_main_loop(void) } while (likely(stats_read_pending == 0)); rte_spinlock_unlock(&qconf->lock); - rte_pause(); + rte_delay_us(10); } /* >8 End of minimize impact of stats reading. */ }