[v1] Revert "doc: extension of crypto event callback announced"

Message ID 20240801073607.3026414-1-schalla@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v1] Revert "doc: extension of crypto event callback announced" |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing pending Testing pending
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing pending Testing pending
ci/iol-unit-amd64-testing fail Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Srujana Challa Aug. 1, 2024, 7:36 a.m. UTC
The previously planned update to the `rte_cryptodev_cb_fn` function
prototype is being reverted. The introduction of the
`rte_cryptodev_queue_pair_event_error_query` API provides a means for
applications to retrieve the queue pair ID that encountered an error
interrupt. This makes the addition of the `qp_id` parameter to the
`rte_cryptodev_cb_fn` function unnecessary, and as such, the proposed
extension is no longer required.

Signed-off-by: Srujana Challa <schalla@marvell.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 -----
 1 file changed, 5 deletions(-)
  

Comments

Stephen Hemminger Oct. 7, 2024, 5:31 p.m. UTC | #1
On Thu, 1 Aug 2024 13:06:07 +0530
Srujana Challa <schalla@marvell.com> wrote:

> The previously planned update to the `rte_cryptodev_cb_fn` function
> prototype is being reverted. The introduction of the
> `rte_cryptodev_queue_pair_event_error_query` API provides a means for
> applications to retrieve the queue pair ID that encountered an error
> interrupt. This makes the addition of the `qp_id` parameter to the
> `rte_cryptodev_cb_fn` function unnecessary, and as such, the proposed
> extension is no longer required.
> 
> Signed-off-by: Srujana Challa <schalla@marvell.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
  
Akhil Goyal Oct. 9, 2024, 7:46 p.m. UTC | #2
> On Thu, 1 Aug 2024 13:06:07 +0530
> Srujana Challa <schalla@marvell.com> wrote:
> 
> > The previously planned update to the `rte_cryptodev_cb_fn` function
> > prototype is being reverted. The introduction of the
> > `rte_cryptodev_queue_pair_event_error_query` API provides a means for
> > applications to retrieve the queue pair ID that encountered an error
> > interrupt. This makes the addition of the `qp_id` parameter to the
> > `rte_cryptodev_cb_fn` function unnecessary, and as such, the proposed
> > extension is no longer required.
> >
> > Signed-off-by: Srujana Challa <schalla@marvell.com>
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied to dpdk-next-crypto
Thanks.
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 211f59fdc9..4dd592c371 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -169,11 +169,6 @@  Deprecation Notices
 * fib: A new flag field will be introduced in ``rte_fib_conf`` structure
   in DPDK 24.11. This field will be used to pass extra configuration settings.
 
-* cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
-  to have another parameter ``qp_id`` to return the queue pair ID
-  which got error interrupt to the application,
-  so that application can reset that particular queue pair.
-
 * cryptodev: The structure ``rte_cryptodev_qp_conf`` will be updated
   to have a new parameter to set priority of that particular queue pair.