diff mbox series

[v1] dts: correct typos in conf.yaml

Message ID 20240813171745.24049-1-dmarx@iol.unh.edu (mailing list archive)
State Superseded
Delegated to: Juraj Linkeš
Headers
Series [v1] dts: correct typos in conf.yaml |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Dean Marx Aug. 13, 2024, 5:17 p.m. UTC 
correct docstring error in conf.yaml showing incorrect
example pci address for TG nodes

Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
 dts/conf.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Nicholas Pratte Aug. 13, 2024, 6:20 p.m. UTC | #1 
Good catch!

Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>

On Tue, Aug 13, 2024 at 1:17 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
>  dts/conf.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/dts/conf.yaml b/dts/conf.yaml
> index 7d95016e68..ca5e87636e 100644
> --- a/dts/conf.yaml
> +++ b/dts/conf.yaml
> @@ -39,13 +39,13 @@ nodes:
>          number_of: 256
>          force_first_numa: false
>      ports:
> -      # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
> +      # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
>        - pci: "0000:00:08.0"
>          os_driver_for_dpdk: vfio-pci # OS driver that DPDK will use
>          os_driver: i40e              # OS driver to bind when the tests are not running
>          peer_node: "TG 1"
>          peer_pci: "0000:00:08.0"
> -      # sets up the physical link between "SUT 1"@000:00:08.1 and "TG 1"@0000:00:08.1
> +      # sets up the physical link between "SUT 1"@0000:00:08.1 and "TG 1"@0000:00:08.1
>        - pci: "0000:00:08.1"
>          os_driver_for_dpdk: vfio-pci
>          os_driver: i40e
> @@ -59,13 +59,13 @@ nodes:
>      arch: x86_64
>      os: linux
>      ports:
> -      # sets up the physical link between "TG 1"@000:00:08.0 and "SUT 1"@0000:00:08.0
> +      # sets up the physical link between "TG 1"@0000:00:08.0 and "SUT 1"@0000:00:08.0
>        - pci: "0000:00:08.0"
>          os_driver_for_dpdk: rdma
>          os_driver: rdma
>          peer_node: "SUT 1"
>          peer_pci: "0000:00:08.0"
> -      # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
> +      # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
>        - pci: "0000:00:08.1"
>          os_driver_for_dpdk: rdma
>          os_driver: rdma
> --
> 2.44.0
>
Luca Vizzarro Aug. 19, 2024, 9:29 a.m. UTC | #2 
Nice one.

Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
Jeremy Spewock Aug. 19, 2024, 1:29 p.m. UTC | #3 
Took me a few reads to even find the differences, haha.

On Tue, Aug 13, 2024 at 1:17 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>

Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
Juraj Linkeš Sept. 10, 2024, 8:16 a.m. UTC | #4 
The subject should be more specific. We don't want a bunch of commits 
with the same subject.

On 13. 8. 2024 19:17, Dean Marx wrote:
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
> 

This should be a regular sentence that starts with a capital letter and 
ends with a dot

> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>

With those two changes,
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
diff mbox series

Patch

diff --git a/dts/conf.yaml b/dts/conf.yaml
index 7d95016e68..ca5e87636e 100644
--- a/dts/conf.yaml
+++ b/dts/conf.yaml
@@ -39,13 +39,13 @@  nodes:
         number_of: 256
         force_first_numa: false
     ports:
-      # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+      # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
       - pci: "0000:00:08.0"
         os_driver_for_dpdk: vfio-pci # OS driver that DPDK will use
         os_driver: i40e              # OS driver to bind when the tests are not running
         peer_node: "TG 1"
         peer_pci: "0000:00:08.0"
-      # sets up the physical link between "SUT 1"@000:00:08.1 and "TG 1"@0000:00:08.1
+      # sets up the physical link between "SUT 1"@0000:00:08.1 and "TG 1"@0000:00:08.1
       - pci: "0000:00:08.1"
         os_driver_for_dpdk: vfio-pci
         os_driver: i40e
@@ -59,13 +59,13 @@  nodes:
     arch: x86_64
     os: linux
     ports:
-      # sets up the physical link between "TG 1"@000:00:08.0 and "SUT 1"@0000:00:08.0
+      # sets up the physical link between "TG 1"@0000:00:08.0 and "SUT 1"@0000:00:08.0
       - pci: "0000:00:08.0"
         os_driver_for_dpdk: rdma
         os_driver: rdma
         peer_node: "SUT 1"
         peer_pci: "0000:00:08.0"
-      # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+      # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
       - pci: "0000:00:08.1"
         os_driver_for_dpdk: rdma
         os_driver: rdma