diff mbox series

[v2,03/14] net/dpaa: remove broken debug macros

Message ID	20240912082643.1532679-4-david.marchand@redhat.com (mailing list archive)
State	Accepted
Delegated to:	David Marchand
Headers	From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com> Subject: [PATCH v2 03/14] net/dpaa: remove broken debug macros Date: Thu, 12 Sep 2024 10:26:29 +0200 Message-ID: <20240912082643.1532679-4-david.marchand@redhat.com> In-Reply-To: <20240912082643.1532679-1-david.marchand@redhat.com> References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Use RTE_LOG_LINE in drivers \| [v2,00/14] Use RTE_LOG_LINE in drivers [v2,01/14] devtools: fix forbidden token check with multiple files [v2,02/14] devtools: report all warnings in forbidden token check [v2,03/14] net/dpaa: remove broken debug macros [v2,04/14] net/sfc: fix driver logtype token [v2,05/14] drivers: reuse default logtype for SFC drivers [v2,06/14] drivers: move log wrappers to Intel base drivers [v2,07/14] net/txgbe: move wrapper to base driver [v2,08/14] event/dlb2: fix base driver logs [v2,09/14] event/dsw: use a dynamic logtype [v2,10/14] drivers: replace logging helpers [v2,11/14] drivers: remove redundant newline from logs [v2,12/14] drivers: split multilines log messages [v2,13/14] net/octeon_ep: avoid warning on uninitialized variable [v2,14/14] drivers: use per line logging in helpers

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

David Marchand Sept. 12, 2024, 8:26 a.m. UTC

Those debug macros never worked as existing callers never passed a
'level' argument.
Remove them.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/dpaa/fmlib/fm_ext.h | 21 ++-------------------
 1 file changed, 2 insertions(+), 19 deletions(-)

Comments

Thomas Monjalon Oct. 1, 2024, 10:18 a.m. UTC | #1

12/09/2024 10:26, David Marchand:
> Those debug macros never worked as existing callers never passed a
> 'level' argument.
> Remove them.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/dpaa/fmlib/fm_ext.h | 21 ++-------------------
>  1 file changed, 2 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/net/dpaa/fmlib/fm_ext.h b/drivers/net/dpaa/fmlib/fm_ext.h
> index 8e7153bdaf..4666fa3b0b 100644
> --- a/drivers/net/dpaa/fmlib/fm_ext.h
> +++ b/drivers/net/dpaa/fmlib/fm_ext.h
> @@ -15,25 +15,8 @@
>  #define MODULE_FM		0x00010000
>  #define __ERR_MODULE__		MODULE_FM
>  
> -/* #define FM_LIB_DBG */
> -
> -#if defined(FM_LIB_DBG)
> -	#define _fml_dbg(fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmlib:%s(): " fmt "\n", \
> -			__func__, ##args)
> -#else
> -	#define _fml_dbg(arg...)
> -#endif
> -
> -/*#define FM_IOCTL_DBG*/
> -
> -#if defined(FM_IOCTL_DBG)
> -	#define _fm_ioctl_dbg(fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmioc:%s(): " fmt "\n", \
> -				__func__, ##args)
> -#else
> -	#define _fm_ioctl_dbg(arg...)
> -#endif
> +#define _fml_dbg(...)
> +#define _fm_ioctl_dbg(...)

Why not removing the calls to these macros?

David Marchand Oct. 1, 2024, 12:08 p.m. UTC | #2

On Tue, Oct 1, 2024 at 12:19 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 12/09/2024 10:26, David Marchand:
> > Those debug macros never worked as existing callers never passed a
> > 'level' argument.
> > Remove them.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Why not removing the calls to these macros?

I was unclear if the fmlib enters the "base driver" category.
So I simply removed macros from the header providing wrappers to dpdk API.

Relooking, I see other changes in this directory, so I agree I may as
well remove those calls.

Hemant, opinion?

Hemant Agrawal Oct. 1, 2024, 1 p.m. UTC | #3

On 01-10-2024 17:38, David Marchand wrote:
> On Tue, Oct 1, 2024 at 12:19 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>> 12/09/2024 10:26, David Marchand:
>>> Those debug macros never worked as existing callers never passed a
>>> 'level' argument.
>>> Remove them.
>>>
>>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> Why not removing the calls to these macros?
> I was unclear if the fmlib enters the "base driver" category.
> So I simply removed macros from the header providing wrappers to dpdk API.
>
> Relooking, I see other changes in this directory, so I agree I may as
> well remove those calls.
>
> Hemant, opinion?
>
Yes, fmlib is a common base library. So, it is better to not remove the 
calls.  Otherwise, we have to maintain the changes from base.

with that

Reviewed-by:  Hemant Agrawal <hemant.agrawal@nxp.com>

diff mbox series

Patch

diff --git a/drivers/net/dpaa/fmlib/fm_ext.h b/drivers/net/dpaa/fmlib/fm_ext.h
index 8e7153bdaf..4666fa3b0b 100644
--- a/drivers/net/dpaa/fmlib/fm_ext.h
+++ b/drivers/net/dpaa/fmlib/fm_ext.h
@@ -15,25 +15,8 @@ 
 #define MODULE_FM		0x00010000
 #define __ERR_MODULE__		MODULE_FM
 
-/* #define FM_LIB_DBG */
-
-#if defined(FM_LIB_DBG)
-	#define _fml_dbg(fmt, args...) \
-	rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmlib:%s(): " fmt "\n", \
-			__func__, ##args)
-#else
-	#define _fml_dbg(arg...)
-#endif
-
-/*#define FM_IOCTL_DBG*/
-
-#if defined(FM_IOCTL_DBG)
-	#define _fm_ioctl_dbg(fmt, args...) \
-	rte_log(RTE_LOG_ ## level, dpaa_logtype_pmd, "fmioc:%s(): " fmt "\n", \
-				__func__, ##args)
-#else
-	#define _fm_ioctl_dbg(arg...)
-#endif
+#define _fml_dbg(...)
+#define _fm_ioctl_dbg(...)
 
 /*
  * @Group	lnx_ioctl_ncsw_grp	NetCommSw Linux User-Space (IOCTL) API