From patchwork Tue Jan 21 16:35:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 150325 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16BCD460D5; Tue, 21 Jan 2025 17:35:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FCAB402A4; Tue, 21 Jan 2025 17:35:52 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 4C27A4027D for ; Tue, 21 Jan 2025 17:35:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737477352; x=1769013352; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=P88yabctyfEXwUqukoOQArbFRxka63YNHPw+ePr4LHY=; b=d6N1gfwC7SOt1eR1rjbg8XaSN8raaGPbmkE2u7RCahiM7nA416lhlFB/ hNMRc44luyJ1RT9Lyi/Tv9WGih5Yb47zf7i69F57rZWcccdiI00Q0aDFm T/tMfN1BhCQwDBdQYyI4dI8UjclkG6bmZT/Xs19vvS2XCihy6AP/R7Las yOJINuPaU3XO8v0FB43WL6S0fUkVGBG0SqG5GgElhUa61DA1R1+GlNL/x a8oEBS0J6tQQbD/mzUhYuxCo8qmOtFWkEc71q7KN3Qr9bUglS/rJVsDNB h5h22fiZW+4TVLaQOHJr4rFp7dYxBE9DWdyKp/UuVflWjIOERTMq0BJoD Q==; X-CSE-ConnectionGUID: u7+YUbeVQLqKeXwkpvGEcw== X-CSE-MsgGUID: JGj8hEryQcCKct1hEt7l8w== X-IronPort-AV: E=McAfee;i="6700,10204,11322"; a="48566868" X-IronPort-AV: E=Sophos;i="6.13,222,1732608000"; d="scan'208";a="48566868" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2025 08:35:49 -0800 X-CSE-ConnectionGUID: 5DRRzKtWR1+Gp3m6tiogAQ== X-CSE-MsgGUID: 20vfaRKJQUKCtTsNINf8SQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="111849475" Received: from silpixa00401197coob.ir.intel.com (HELO silpixa00401385.ir.intel.com) ([10.237.214.45]) by orviesa003.jf.intel.com with ESMTP; 21 Jan 2025 08:35:47 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Subject: [PATCH] net/i40e: reduce log level of global register update msg Date: Tue, 21 Jan 2025 16:35:39 +0000 Message-ID: <20250121163539.2308702-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The modifying of a global register value, which has an affect on multiple ports is an important change to HW. However, the actual details of that change is only relevant to developers and not general users. Therefore reduce the log level from "warning" - which implies something is wrong - to "info". Signed-off-by: Bruce Richardson Acked-by: David Marchand --- drivers/net/i40e/i40e_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 30dcdc68a8..39b6e28aad 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -750,7 +750,7 @@ i40e_write_global_rx_ctl(struct i40e_hw *hw, uint32_t reg_addr, ori_reg_val = i40e_read_rx_ctl(hw, reg_addr); i40e_write_rx_ctl(hw, reg_addr, reg_val); if (ori_reg_val != reg_val) - PMD_DRV_LOG(WARNING, + PMD_DRV_LOG(INFO, "i40e device %s changed global register [0x%08x]." " original: 0x%08x, new: 0x%08x", dev->device->name, reg_addr, ori_reg_val, reg_val); @@ -1352,7 +1352,7 @@ i40e_aq_debug_write_global_register(struct i40e_hw *hw, } if (ori_reg_val != reg_val) - PMD_DRV_LOG(WARNING, + PMD_DRV_LOG(INFO, "i40e device %s changed global register [0x%08x]." " original: 0x%"PRIx64", after: 0x%"PRIx64, dev->device->name, reg_addr, ori_reg_val, reg_val); @@ -9774,7 +9774,7 @@ i40e_check_write_global_reg(struct i40e_hw *hw, uint32_t addr, uint32_t val) if (reg != val) { i40e_write_rx_ctl(hw, addr, val); - PMD_DRV_LOG(WARNING, + PMD_DRV_LOG(INFO, "i40e device %s changed global register [0x%08x]." " original: 0x%08x, new: 0x%08x", dev->device->name, addr, reg,