diff mbox series

[22/32] net/nfp: replace memcpy with assignment

Message ID	20250208203142.242284-23-stephen@networkplumber.org (mailing list archive)
State	New
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Chaoyong He <chaoyong.he@corigine.com> Subject: [PATCH 22/32] net/nfp: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:14 -0800 Message-ID: <20250208203142.242284-23-stephen@networkplumber.org> In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Use structure assignment instead of memcpy \| [00/32] Use structure assignment instead of memcpy [01/32] devtools/cocci: prefer structure assignment over memcpy [02/32] app/testpmd: replace memcpy with assignment [03/32] app/graph: replace memcpy with structure assignment [04/32] crypto/dpaa_sec: replace memcpy with assignment [05/32] dma/dpaa2: replace memcpy with assignment [06/32] eventdev: replace memcpy with assignment [07/32] event/dpaa2: replace memcpy with structure assignment [08/32] event/dsw: replace memcpy with assignment [09/32] ml/cnxk: replace memcpy with assignment [10/32] examples: replace memcpy with assignment [11/32] node: replace memcpy with assignment [12/32] pipeline: replace memcpy with assignment [13/32] sched: replace memcpy with structure assignment [14/32] table: replace memcpy with structure assignment [15/32] net/ntnic: replace memcpy with structure assignment [16/32] net/bnxt: replace memcpy with structure assignment [17/32] crypto/qat: replace memcpy with structure assignment [18/32] mempool/cnxk: replace memcpy with structure assignment [19/32] net/dpaa2: replace memcpy with assignment [20/32] net/enic: replace memcpy with assignment [21/32] net/intel/i40e: replace memcpy with structure assignment [22/32] net/nfp: replace memcpy with assignment [23/32] net/txgbe: replace memcpy with assignment [24/32] net/bnx2x: replace memcpy with structure assignment [25/32] net/dpaa2: replace memcpy with structure assignment [26/32] net/bonding: replace memcpy with structure assignment [27/32] net/cnxk: replace memcpy with structure assignment [28/32] net/enic: replace memcpy with structure assignment [29/32] net/iavf: replace memcpy with structure assignment [30/32] net/ice: replace memcpy with structure assignment [31/32] test: replace memcpy with structure assignment [32/32] test/cryptodev: replace memcpy with structure assignment

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Feb. 8, 2025, 8:22 p.m. UTC

Prefer structure assignment over memcpy.
Found by cocci/struct_assign.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/nfp/flower/nfp_flower_representor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chaoyong He Feb. 10, 2025, 1:13 a.m. UTC | #1

Thanks.

Acked-by: Chaoyong He <chaoyong.he@corigine.com>

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Sunday, February 9, 2025 4:22 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Chaoyong He
> <chaoyong.he@corigine.com>
> Subject: [PATCH 22/32] net/nfp: replace memcpy with assignment
> 
> Prefer structure assignment over memcpy.
> Found by cocci/struct_assign.cocci
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/nfp/flower/nfp_flower_representor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c
> b/drivers/net/nfp/flower/nfp_flower_representor.c
> index 9601aa5f96..ae0f082eb9 100644
> --- a/drivers/net/nfp/flower/nfp_flower_representor.c
> +++ b/drivers/net/nfp/flower/nfp_flower_representor.c
> @@ -318,7 +318,7 @@ nfp_flower_repr_stats_get(struct rte_eth_dev
> *ethdev,
>  	struct nfp_flower_representor *repr;
> 
>  	repr = ethdev->data->dev_private;
> -	rte_memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats));
> +	*stats = repr->repr_stats;
> 
>  	return 0;
>  }
> --
> 2.47.2

diff mbox series

Patch

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
index 9601aa5f96..ae0f082eb9 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -318,7 +318,7 @@  nfp_flower_repr_stats_get(struct rte_eth_dev *ethdev,
 	struct nfp_flower_representor *repr;
 
 	repr = ethdev->data->dev_private;
-	rte_memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats));
+	*stats = repr->repr_stats;
 
 	return 0;
 }